diff --git a/.env.template b/.env.template index 53b69ef..373527d 100644 --- a/.env.template +++ b/.env.template @@ -83,6 +83,17 @@ PRISM_ASSETS="/flare///assets" # the Stage 1 projector named by src/conf/training/bioreason_sft.yaml. PRISM_OUTPUT_ROOT="/flare///outputs" +# Shell-script variables (optional) +# Read by the bioreason / GRPO submit scripts and scripts/smoke_test_grpo.sh, +# which fail with a "set " message when they are unset. These are plain +# shell variables, not part of src/site_paths.py. + +# Conda environment those scripts activate. +# PRISM_CONDA_ENV="////conda_env/prism" + +# Checkout the scripts cd into (scripts/smoke_test_grpo.sh). +# PRISM_REPO_ROOT="/flare///PRISM" + # Model & Dataset Path Overrides (optional) # These override placeholder defaults baked into src/config.py and # src/encoders/geometry.py. Leave unset to use the placeholder paths — this diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 699e4ce..0f49f08 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -64,8 +64,9 @@ See *Guidelines for AI/LLM-Assisted Contributions* in accountable for the review — a project norm, not yet enforced by branch protection. -- [ ] AI/LLM tools were primarily used to generate code or artifacts in this PR -- [ ] I have reviewed all such output line-by-line and understand it +- **AI tools used:** None, or list the tools. +- **Scope of assistance:** What was generated, edited, or reviewed? +- **Human validation:** What did you review or test? ## Additional Context diff --git a/.github/workflows/pr_quality.yml b/.github/workflows/pr_quality.yml index a6d47c5..f41c4cc 100644 --- a/.github/workflows/pr_quality.yml +++ b/.github/workflows/pr_quality.yml @@ -5,6 +5,12 @@ on: push: branches: - main + workflow_dispatch: + inputs: + check_external_urls: + description: Check external documentation URLs (advisory only) + type: boolean + default: false permissions: contents: read @@ -60,6 +66,37 @@ jobs: python-version: "3.10" - name: Check relative Markdown links run: python tools/ci/check_doc_links.py + - name: List tracked Markdown files + id: markdown + run: | + git ls-files '*.md' > "$RUNNER_TEMP/prism-markdown.txt" + echo "files=$(paste -sd ' ' "$RUNNER_TEMP/prism-markdown.txt")" >> "$GITHUB_OUTPUT" + - name: Check spelling + uses: crate-ci/typos@4c8b7f51ca60df14e3c5ca82770dfbbe6c3dae85 # v1.52.0 + with: + files: ${{ steps.markdown.outputs.files }} + - name: Check local Markdown links and anchors + uses: lycheeverse/lychee-action@e7477775783ea5526144ba13e8db5eec57747ce8 # v2 + with: + args: --offline --include-fragments=anchor-only --no-progress --files-from ${{ runner.temp }}/prism-markdown.txt + + external_urls: + if: github.event_name == 'workflow_dispatch' && inputs.check_external_urls + runs-on: ubuntu-latest + timeout-minutes: 15 + continue-on-error: true + steps: + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 + with: + persist-credentials: false + - name: List tracked Markdown files + run: git ls-files '*.md' > "$RUNNER_TEMP/prism-markdown.txt" + - name: Check external documentation URLs + continue-on-error: true + uses: lycheeverse/lychee-action@e7477775783ea5526144ba13e8db5eec57747ce8 # v2 + with: + fail: false + args: --exclude-all-private --timeout 20 --max-retries 2 --no-progress --files-from ${{ runner.temp }}/prism-markdown.txt types: runs-on: ubuntu-latest diff --git a/CHANGELOG.md b/CHANGELOG.md index 3b79aef..8b56a9f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,12 @@ will make up v0.1.0. ### Changed +- Site-path gate now also flags internal identities (usernames, the old repo + name) and scans `experiments/`, `scaling-study/`, + `requirements/`, `.github/` and root-level files, and the `grand`, `gpfs` + and `lustre` roots; the bioreason/GRPO scripts and `experiments/prism_designs.yaml` + take locations from `PRISM_*` variables (`PRISM_CONDA_ENV` and `PRISM_REPO_ROOT` + are new, see `.env.template`) - Corrected the `src/libs/walrus` submodule URL to the upstream `PolymathicAI/walrus` organization (#186) - `requirements/base.txt` now installs `h5py`, which `src/data/multimodal.py` @@ -51,6 +57,9 @@ will make up v0.1.0. ### Removed +- `experiments/stage_a_round1_olmo3_1b.yaml`, `ablation_catalog.yaml` and + `qwen3_siglip_smokes.yaml` — study records tied to internal paths with no + code dependents. Remaining study files carry `TODO(release)` notes. - `docs/plans/` (9 files) and `docs/historical/` (5 files) — dated design plans and bring-up debug journals whose work has all landed. Plans are tracking artifacts and belong in the issue tracker rather than the source tree. diff --git a/_typos.toml b/_typos.toml new file mode 100644 index 0000000..b421392 --- /dev/null +++ b/_typos.toml @@ -0,0 +1,9 @@ +[default.extend-identifiers] +unparseable_response = "unparseable_response" +nature_comunication = "nature_comunication" +hsa_var = "hsa_var" +ABL = "ABL" +ABL1 = "ABL1" +arange = "arange" +HPE = "HPE" +PNGs = "PNGs" diff --git a/applications/bioreason/scripts/eval/submit_eval_kegg.sh b/applications/bioreason/scripts/eval/submit_eval_kegg.sh index 249d6b9..eacec41 100755 --- a/applications/bioreason/scripts/eval/submit_eval_kegg.sh +++ b/applications/bioreason/scripts/eval/submit_eval_kegg.sh @@ -14,8 +14,8 @@ PROJ_DIR="${PROJ_DIR:-$(cd "$(dirname "${BASH_SOURCE[0]}")/../../../.." 2>/dev/n if [ -n "${PBS_O_WORKDIR:-}" ] && [ ! -f "${PROJ_DIR}/src/train.py" ]; then PROJ_DIR="${PBS_O_WORKDIR}" fi -CHECKPOINT_DIR="/lus/eagle/projects/argonne_tpc/abalaji/modcon/genome/output/GENOME-SFT-1B/2026-06-29/07-41-10/checkpoints/step_8000" -# SFT with sample weigting and answer structure : /lus/eagle/projects/argonne_tpc/abalaji/modcon/genome/output/GENOME-SFT-1B/2026-06-29/07-41-10/checkpoints/step_3000 +CHECKPOINT_DIR="${PRISM_OUTPUT_ROOT:?set PRISM_OUTPUT_ROOT}/GENOME-SFT-1B//