From c87b2bb5002c43b451e75447c20d1482e3df5190 Mon Sep 17 00:00:00 2001 From: Daniel Ari Friedman Date: Mon, 16 Nov 2026 15:44:12 -0800 Subject: [PATCH] Adopt the v5.1.0 GNN upstream pin Move gnn/upstream.json from v5.0.3 (8f293d9b) to v5.1.0 (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf) and keep the duplicated pin references in step: gnn/README.md, .github/GNN.md, docs/gates.md, the CANONICAL_PIN record in tests/test_gnn_conformance.py, and the README.md GNN documentation links, which now resolve at the v5.1.0 tag. Close asf-gnn-upstream-5-1-adoption in tasks.yaml and regenerate TODO.md with scripts/validate_roadmap.py --write-todo. Co-Authored-By: Claude Opus 5.5 --- .github/GNN.md | 4 +- README.md | 10 ++-- TODO.md | 4 -- docs/gates.md | 4 +- docs/todo/asf-gnn-upstream-5-1-adoption.md | 56 ---------------------- gnn/README.md | 4 +- gnn/upstream.json | 6 +-- tasks.yaml | 32 ++++++------- tests/test_gnn_conformance.py | 4 +- 9 files changed, 31 insertions(+), 93 deletions(-) delete mode 100644 docs/todo/asf-gnn-upstream-5-1-adoption.md diff --git a/.github/GNN.md b/.github/GNN.md index ef0fad4..4671285 100644 --- a/.github/GNN.md +++ b/.github/GNN.md @@ -2,8 +2,8 @@ `gnn conformance (pinned)` is defined in `.github/workflows/gates.yml` as the `gnn-conformance` job and reads `gnn/upstream.json` (schema `gnn-importer-pin/v1`), which -pins `ActiveInferenceInstitute/Generalized_Notation_Notation` at `v5.0.3` -(`8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`). The job's only gate step is +pins `ActiveInferenceInstitute/Generalized_Notation_Notation` at `v5.1.0` +(`75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`). The job's only gate step is `./gates.sh gnn`, the same arm a contributor runs locally. The job fetches that commit into its own checkout, then runs `./gates.sh gnn`, which is diff --git a/README.md b/README.md index ac3c679..dbb65f5 100644 --- a/README.md +++ b/README.md @@ -271,13 +271,13 @@ gh pr checks "$PR_NUMBER" --repo "$repo" --required --json name,bucket GNN_PYTHON= ./gates.sh gnn`; `uv run pytest tests/test_gnn_conformance.py -q` - - Scholarship lanes: delivery_and_reporting ### Major Improvements diff --git a/docs/gates.md b/docs/gates.md index 6565086..60ad4e7 100644 --- a/docs/gates.md +++ b/docs/gates.md @@ -44,8 +44,8 @@ pay for a full artifact rebuild. Both use the same pytest selection mechanism `./gates.sh gnn` validates `gnn/discrete_active_inference_agent.gnn.md` against the parser revision pinned in `gnn/upstream.json` (required schema `gnn-importer-pin/v1`; missing or -unsupported discriminators are rejected): tag `v5.0.3`, -commit `8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`. It needs a prepared +unsupported discriminators are rejected): tag `v5.1.0`, +commit `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`. It needs a prepared pinned checkout and fails — never skips — when `GNN_ROOT` is missing or unusable. The preparation commands are in [`../README.md`](../README.md#required-local-gnn-check); the job that runs this arm in CI is `gnn-conformance`, displayed as diff --git a/docs/todo/asf-gnn-upstream-5-1-adoption.md b/docs/todo/asf-gnn-upstream-5-1-adoption.md deleted file mode 100644 index 69568d7..0000000 --- a/docs/todo/asf-gnn-upstream-5-1-adoption.md +++ /dev/null @@ -1,56 +0,0 @@ -# Adopt the v5.1.0 GNN upstream pin (currently v5.0.3) - - - -## Roadmap Link - -- Task id: `asf-gnn-upstream-5-1-adoption` -- Status: `todo` -- Scale: `minor` -- Surface: `validation` -- Owner: `gnn/upstream.json` -- Top-level TODO: [`TODO.md`](../../TODO.md) - -## Scope - -gnn/upstream.json pins Generalized_Notation_Notation at v5.0.3 (8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1), while the estate cutover moved the importer repositories to v5.1.0 (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf); this repository was not part of that cutover, so its pin is accurate but behind. The tag is duplicated in five places that must move together: gnn/upstream.json, gnn/README.md, docs/gates.md, .github/GNN.md, and the pinned-record constant plus the scratch-checkout tag in tests/test_gnn_conformance.py, with README.md linking the v5.0.3 tag at three places. scripts/validate_gnn_spec.py extracts the pinned commit with git archive and parses the specification with that checkout's parser, so a metadata-only edit would be drift rather than proof: the bump counts only once ./gates.sh gnn passes against a v5.1.0 checkout. Blocker: the arm fails, never skips, without a prepared v5.1.0 checkout and interpreter (GNN_ROOT/GNN_PYTHON), and the hosted `gnn conformance (pinned)` job cannot stand in for it while Actions is billing-locked org-wide. A local Generalized_Notation_Notation checkout at v5.1.0 already exists on the working host (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf), so the maintainer who runs it can close this. - -## Deliverables - -- Update the `validation` surface owned by `gnn/upstream.json` only as needed for this task. -- Refresh generated artifacts or documentation surfaces named by the evidence commands. -- Keep `tasks.yaml` canonical and regenerate `TODO.md` rather than hand-editing it. - -## Out of Scope - -- Do not stage, commit, push, publish, or mint a DOI as part of this task unless a later request explicitly asks for it. -- Do not weaken validators, coverage thresholds, provenance checks, or source-role requirements to make evidence pass. - -## Dependencies and Blockers - -- Depends on: none declared in `tasks.yaml`. -- Current blocker: none; this item is open for implementation. - -## Evidence Commands - -- `git ls-remote --tags https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation.git (v5.1.0 = 75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf)` -- `GNN_ROOT= GNN_PYTHON= ./gates.sh gnn` -- `uv run pytest tests/test_gnn_conformance.py -q` - -## Acceptance Criteria - -- All evidence commands listed above pass, or the task remains blocked with exact blocker evidence. -- Generated roadmap surfaces validate with `uv run python scripts/validate_roadmap.py`. -- Live counts remain current with `uv run python scripts/validate_live_counts.py`. - -## Scholarship and Evidence Plan - -- Lanes: delivery_and_reporting -- Existing source keys: none -- Planned source targets: -- none -- Claim-support types: scope_limit -- Boundaries: -- A pin bump is specification-conformance maintenance, not scientific or learner-outcome evidence. -- Phase exit: -- gnn/upstream.json records tag v5.1.0 and commit 75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf, the five duplicated pin references agree, and `./gates.sh gnn` reports clean against that checkout with no skips. diff --git a/gnn/README.md b/gnn/README.md index eff2be4..bf2bde0 100644 --- a/gnn/README.md +++ b/gnn/README.md @@ -3,8 +3,8 @@ `discrete_active_inference_agent.gnn.md` is the Generalized Notation Notation specification of the discrete-agent kernel's generative model. `upstream.json` records the parser pin: repository -`ActiveInferenceInstitute/Generalized_Notation_Notation`, tag `v5.0.3`, commit -`8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`. +`ActiveInferenceInstitute/Generalized_Notation_Notation`, tag `v5.1.0`, commit +`75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`. `scripts/validate_gnn_spec.py` extracts that pinned commit with `git archive` and validates the specification. `tests/test_gnn_conformance.py` checks the diff --git a/gnn/upstream.json b/gnn/upstream.json index f625b94..e972bfb 100644 --- a/gnn/upstream.json +++ b/gnn/upstream.json @@ -1,7 +1,7 @@ { "schema": "gnn-importer-pin/v1", "repository": "ActiveInferenceInstitute/Generalized_Notation_Notation", - "tag": "v5.0.3", - "commit": "8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1", - "recorded": "2026-11-12" + "tag": "v5.1.0", + "commit": "75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf", + "recorded": "2026-11-16" } diff --git a/tasks.yaml b/tasks.yaml index 09727c8..2ee7e77 100644 --- a/tasks.yaml +++ b/tasks.yaml @@ -2150,8 +2150,8 @@ tasks: phase_exit: - "PLW1510 resolved via explicit checks or a justified targeted noqa; ruff check returns 0." - id: asf-gnn-upstream-5-1-adoption - title: Adopt the v5.1.0 GNN upstream pin (currently v5.0.3) - status: todo + title: Adopt the v5.1.0 GNN upstream pin + status: done scale: minor surface: validation owner: gnn/upstream.json @@ -2161,21 +2161,19 @@ tasks: - GNN_ROOT= GNN_PYTHON= ./gates.sh gnn - uv run pytest tests/test_gnn_conformance.py -q notes: >- - gnn/upstream.json pins Generalized_Notation_Notation at v5.0.3 - (8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1), while the estate cutover moved the importer - repositories to v5.1.0 (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf); this repository was not part - of that cutover, so its pin is accurate but behind. The tag is duplicated in five places that - must move together: gnn/upstream.json, gnn/README.md, docs/gates.md, .github/GNN.md, and the - pinned-record constant plus the scratch-checkout tag in tests/test_gnn_conformance.py, with - README.md linking the v5.0.3 tag at three places. scripts/validate_gnn_spec.py extracts the - pinned commit with git archive and parses the specification with that checkout's parser, so a - metadata-only edit would be drift rather than proof: the bump counts only once - ./gates.sh gnn passes against a v5.1.0 checkout. Blocker: the arm fails, never skips, without a - prepared v5.1.0 checkout and interpreter (GNN_ROOT/GNN_PYTHON), and the hosted - `gnn conformance (pinned)` job cannot stand in for it while Actions is billing-locked - org-wide. A local Generalized_Notation_Notation checkout at v5.1.0 already exists on the - working host (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf), so the maintainer who runs it can - close this. + gnn/upstream.json now pins Generalized_Notation_Notation at v5.1.0 + (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf, recorded 2026-11-16), replacing v5.0.3 + (8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1) and joining the estate importer cutover. The + duplicated pin references moved together: gnn/upstream.json, gnn/README.md, docs/gates.md, + .github/GNN.md, the CANONICAL_PIN record in tests/test_gnn_conformance.py, and the README.md + GNN documentation links, which now resolve at the v5.1.0 tag (the downstream adoption guide + exists at that tag, so it no longer links the default branch). The scratch-checkout fixture + in tests/test_gnn_conformance.py builds its own stub tag and never reads the real pin, so it + was left as is. Proof is the required local check rather than a metadata-only edit: + scripts/validate_gnn_spec.py and tests/test_gnn_conformance.py passed with no skips against + a v5.1.0 checkout (GNN_ROOT/GNN_PYTHON) in an offline run, and that result is published as the + `gnn conformance (local)` commit status because the hosted `gnn conformance (pinned)` job + remains billing-locked. scholarship_plan: lanes: - delivery_and_reporting diff --git a/tests/test_gnn_conformance.py b/tests/test_gnn_conformance.py index 8adef9d..55ff181 100644 --- a/tests/test_gnn_conformance.py +++ b/tests/test_gnn_conformance.py @@ -53,8 +53,8 @@ CANONICAL_PIN = { "repository": "ActiveInferenceInstitute/Generalized_Notation_Notation", - "tag": "v5.0.3", - "commit": "8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1", + "tag": "v5.1.0", + "commit": "75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf", }