From 5542f8ca5066583bf1e951c01958bd423d9e03e8 Mon Sep 17 00:00:00 2001 From: Daniel Ari Friedman Date: Mon, 16 Nov 2026 15:32:59 -0800 Subject: [PATCH 1/2] Move the GNN importer pin to v5.1.0 (75c834bd) Pin .github/gnn-pin.json to tag v5.1.0 at its exact tag commit 75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf (recorded 2026-11-16), and move the pin tables in .github/GNN.md, .github/README.md and docs/RUN_GUIDE.md plus the gnn-pin.json digest in docs/workflows/publishing.md with it. Close the TO-DO item that tracked the bump. Co-Authored-By: Claude Opus 5.5 --- .github/GNN.md | 4 ++-- .github/README.md | 4 ++-- .github/gnn-pin.json | 6 +++--- TO-DO.md | 4 ++-- docs/RUN_GUIDE.md | 6 +++--- docs/workflows/publishing.md | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/GNN.md b/.github/GNN.md index 7e2ba87..fb15243 100644 --- a/.github/GNN.md +++ b/.github/GNN.md @@ -6,8 +6,8 @@ pinned parser first). It is the same command the CI job see [`docs/RUN_GUIDE.md`](../docs/RUN_GUIDE.md) for every arm. The conformance arm reads `.github/gnn-pin.json` (`gnn-importer-pin/v1`), which -pins `ActiveInferenceInstitute/Generalized_Notation_Notation` at tag `v5.0.3`, -revision `8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1` (recorded `2026-11-12`). +pins `ActiveInferenceInstitute/Generalized_Notation_Notation` at tag `v5.1.0`, +revision `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf` (recorded `2026-11-16`). What it validates, in order: diff --git a/.github/README.md b/.github/README.md index 681619d..5821e3e 100644 --- a/.github/README.md +++ b/.github/README.md @@ -17,8 +17,8 @@ tests, run by the `tests` arm. - [`dependabot.yml`](dependabot.yml) — dependency update configuration. - [`gnn-pin.json`](gnn-pin.json) — the `gnn-importer-pin/v1` pin used by the - conformance arm: repository, tag `v5.0.3`, revision - `8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`, recorded `2026-11-12`. + conformance arm: repository, tag `v5.1.0`, revision + `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`, recorded `2026-11-16`. - [`GNN.md`](GNN.md) — what the pinned GNN conformance arm parses. Arms, job commands, and measured wall times are documented in diff --git a/.github/gnn-pin.json b/.github/gnn-pin.json index 0ed97f6..601da43 100644 --- a/.github/gnn-pin.json +++ b/.github/gnn-pin.json @@ -1,7 +1,7 @@ { "schema": "gnn-importer-pin/v1", "repository": "ActiveInferenceInstitute/Generalized_Notation_Notation", - "revision": "8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1", - "tag": "v5.0.3", - "recorded": "2026-11-12" + "revision": "75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf", + "tag": "v5.1.0", + "recorded": "2026-11-16" } diff --git a/TO-DO.md b/TO-DO.md index 19a5c41..6706856 100644 --- a/TO-DO.md +++ b/TO-DO.md @@ -29,7 +29,7 @@ Sections: - [x] **Harden PDF_Scrape entrypoint behavior** — `streamingExport.py` prompted at import time and `manager.py` executed at import. Now: lazy export configuration (import-safe), `if __name__ == "__main__"` guard, and failure logs include the exception message. Verified end-to-end in a throwaway venv (257-record run via stdin). ✓ commit `5bb023f` (fix: guard manager entrypoint and make streaming export configuration lazy) - [x] **Point at the canonical ontology home** — `Ontology_Snapshot/` is a frozen December 2022 export, so the README, `docs/provenance.md`, and the area README now name [`Active_Inference_Ontology`](https://github.com/ActiveInferenceInstitute/Active_Inference_Ontology) as the published home: current v5 release (May 25, 2023, 429 terms) with stable identities and typed relations, the archived December 12, 2022 snapshot of the same 411-row export, and the GNN vocabulary bridge for `ActInfOntologyAnnotation` labels. 402 of the 408 terms in the snapshot appear verbatim in the v5 release the canonical repository publishes. The snapshot CSVs were not touched. Verified: the canonical paths exist on that repository's `main` branch, the term overlap was measured from the committed CSVs, and every relative link in the edited files resolves. ✓ commit `fbaefeb` - [x] **Compose the gate into one entry point** — the archive checks moved into `.github/scripts/archive_checks.py` and the GNN job body moved out of `ci.yml` into `.github/scripts/gnn_conformance.py`; `.github/scripts/gate.py` is now the only command line, with separately runnable arms (`links`, `python`, `notebooks`, `checkpoints`, `archive`, `tests`, `gnn`, `fast`, `full`, `timings`). Both CI jobs run one arm each, so no check body is duplicated in the workflow, and the pin is validated against schema `gnn-importer-pin/v1` in code instead of two inline heredocs. The gate gained tests (`.github/scripts/tests/test_gate.py`) and a generated wall-time page (`docs/gate-timings.md`); `docs/RUN_GUIDE.md` and `docs/documentation-index.md` document them. ✓ PR #9, commit `7ab2b6b` (2026-11-12) -- [x] **Adopt the canonical GNN importer pin schema** — `.github/gnn-pin.json` now declares `schema: gnn-importer-pin/v1` and a `recorded` date, so the estate-wide reader no longer reports the pin as unversioned; the existing keys and values were left byte-identical. The pin body is still `v5.0.3` — see [Open](#open--deferred). ✓ PR #8, commit `a05864a` +- [x] **Adopt the canonical GNN importer pin schema** — `.github/gnn-pin.json` now declares `schema: gnn-importer-pin/v1` and a `recorded` date, so the estate-wide reader no longer reports the pin as unversioned; the existing keys and values were left byte-identical. The pin body stayed `v5.0.3` until it moved to `v5.1.0` on 2026-11-16 — see [Open](#open--deferred) item 1. ✓ PR #8, commit `a05864a` - [x] **Check reference-style links on every line** — the archive-checks refactor dropped `re.MULTILINE` from `REFERENCE_LINK`, so a reference definition below a page's first line (e.g. `[appendix]: missing.md`) stopped being checked; the flag is restored and `test_gate.py` now covers both a missing and a resolving definition below a heading. ✓ PR #10, commit `438b281` - [x] **Record the Publishing member contract and identity pins** — `docs/workflows/publishing.md` points at the ActiveInferenceJournal contract (revision `d8ec888a8f3051a66bed9af047ee4b206050bdce`) and carries the `name sha256` block for `record-identity.schema.json`, `scripts/gate/identity.py` and `.github/gnn-pin.json`; the `links` arm runs the copied module's `--verify-copy` for all three and `test_publishing.py` proves a drifted copy fails the docs gate. Digests were checked against the files (`identity: … matches publishing.md`). ✓ PR #11, commit `a6d282c` - [x] **Correct the sidecar document paths** — `.aii/config.yaml` listed `.aii/docs/INTEGRATION.md` and `.aii/docs/AGENTS.md` under `docs:`, but the validator resolves entries relative to `.aii/`, so those pointed at `.aii/.aii/docs/…`; they are now `docs/INTEGRATION.md`, `docs/AGENTS.md`, `../docs/documentation-index.md` and `../docs/workflows/publishing.md`, and `aii_sidecar validate` reports `OK: .`. ✓ PR #12, commit `d5bf61c` @@ -48,7 +48,7 @@ Sections: No scoped finding from the 2026-08-02 review is still open. Everything below is either newly found or deliberately deferred; each line names what blocks it and who clears it. -1. **The GNN pin is still `v5.0.3`** — `.github/gnn-pin.json` records tag `v5.0.3`, revision `8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`, while the estate cutover revision is `v5.1.0` = `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf` (`git ls-remote --tags` against `Generalized_Notation_Notation`, 2026-11-12). A bump is three coordinated edits — the pin's `tag`/`revision`/`recorded`, the `gnn-pin.json` digest in the [Publishing digest block](docs/workflows/publishing.md), and the pin tables in `.github/GNN.md` and `docs/RUN_GUIDE.md` — plus a green `python .github/scripts/gate.py gnn --install`. The `links` arm fails until the digest is refreshed, and `test_publishing.py` encodes that. That run needs a CPython 3.11–3.14 interpreter (recipe: [`docs/RUN_GUIDE.md`](docs/RUN_GUIDE.md#running-the-gnn-arm-locally)), because the pinned release declares `>=3.11,<3.15` and this host's default Python is 3.15.2. Owner: the maintainer who next touches the pin; nothing outside the repository blocks it. +1. **GNN pin moved to `v5.1.0` (2026-11-16)** — `.github/gnn-pin.json` now records tag `v5.1.0`, revision `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf` (the commit the annotated `v5.1.0` tag resolves to), recorded `2026-11-16`; the pin tables in `.github/GNN.md`, `.github/README.md` and `docs/RUN_GUIDE.md` and the `gnn-pin.json` digest in the [Publishing digest block](docs/workflows/publishing.md) moved with it. `python .github/scripts/gate.py fast` and the `gnn` arm against an installed 5.1.0 parser (CPython 3.12) passed locally before the change was proposed. Nothing open. 2. **Hosted CI gives no verdict** — every workflow run fails before its jobs start: run `43244620261` (push to `main`, 2026-11-12) carries "The job was not started because your account is locked due to a billing issue" on both `docs and scripts` and `gnn conformance (pinned)`, and the same annotation appears on the pull-request runs for #11 and #12. Until the organisation's Actions billing is restored, a local `python .github/scripts/gate.py fast` is the only gate evidence and a merge cannot wait on a hosted check. Blocked outside this repository on ActiveInferenceInstitute GitHub billing; its owner clears it. 3. **Rendered docs site** with a static-site generator and CI (MkDocs/Jekyll) — deferred by the decision recorded under Major; unblock when the archive gains a build step or an installable package. Owner: repository maintainer. 4. **Code modernization beyond the entrypoint fix** — the `dataImport.py`/`docResults.py` reads that resolve `resc/params/*.csv` against the working directory (deliberate for a run-from-here archive) and `formatFileId` edge cases. Unscheduled: the scrapers only run against a PDF corpus that is not committed, so there is no reproducible test input. Owner: whoever revives PDF_Scrape. (`docResults1` legacy variant was removed on 2026-11-06, PR #6, commit `9b7658e`.) diff --git a/docs/RUN_GUIDE.md b/docs/RUN_GUIDE.md index fdbdec7..cf604f1 100644 --- a/docs/RUN_GUIDE.md +++ b/docs/RUN_GUIDE.md @@ -87,9 +87,9 @@ arm gains a locked dependency set. | Pin file | `.github/gnn-pin.json` | | Schema | `gnn-importer-pin/v1` | | Repository | `ActiveInferenceInstitute/Generalized_Notation_Notation` | -| Tag | `v5.0.3` | -| Revision | `8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1` | -| Recorded | `2026-11-12` | +| Tag | `v5.1.0` | +| Revision | `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf` | +| Recorded | `2026-11-16` | `.github/GNN.md` records what the conformance arm parses. The arm validates the schema and repository identity, installs diff --git a/docs/workflows/publishing.md b/docs/workflows/publishing.md index 56c29b2..d088458 100644 --- a/docs/workflows/publishing.md +++ b/docs/workflows/publishing.md @@ -28,7 +28,7 @@ schema, not mirrored in prose here. The existing GNN pin is also digest-bound. ```text record-identity.schema.json 84f6c4df6efc3f15f0d8a9a05c8aabd0cbdc08b0f4feac5fcc8ae860a81e306b identity.py 847328ff163fa90c869495164869caf4e83313748e8a444dbab8d4e459b11074 -gnn-pin.json eb83f7f1b73eb31e116bd05b1f457dd07e6874a2a4ba0e9e95e5bc91f094cd55 +gnn-pin.json 4e4a455875c7afdf21312d4de1bce6d6695c48dea01d90d6132e2545b14ba276 ``` The `links` arm invokes the canonical module's `--verify-copy` command for every From 32be0f88945dc1c0055ba235572e576dcc2422c5 Mon Sep 17 00:00:00 2001 From: Daniel Ari Friedman Date: Mon, 16 Nov 2026 15:33:45 -0800 Subject: [PATCH 2/2] Derive the conformance test stub version from the pin _stub_modules hard-coded gnn.__version__ = "5.0.3", so any pin move failed two verdict cases on the version check before they reached the verdict under test. Read the version from the pin's tag instead; explicit overrides still work. Co-Authored-By: Claude Opus 5.5 --- .github/scripts/tests/test_gnn_conformance.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/scripts/tests/test_gnn_conformance.py b/.github/scripts/tests/test_gnn_conformance.py index f3f4703..602d8f2 100644 --- a/.github/scripts/tests/test_gnn_conformance.py +++ b/.github/scripts/tests/test_gnn_conformance.py @@ -40,10 +40,14 @@ class _Parsed: parse_errors: list[str] = [] -def _stub_modules(verdict: object, *, version: str = "5.0.3") -> dict[str, object]: - """Return ``sys.modules`` entries implementing the pinned parser surface.""" +def _stub_modules(verdict: object, *, version: str | None = None) -> dict[str, object]: + """Return ``sys.modules`` entries implementing the pinned parser surface. + + The stub reports the version the pin declares unless a case overrides it, so + moving the pin does not also require editing every verdict case. + """ gnn = types.ModuleType("gnn") - gnn.__version__ = version # type: ignore[attr-defined] + gnn.__version__ = version if version is not None else str(PIN["tag"]).removeprefix("v") # type: ignore[attr-defined] parsers = types.ModuleType("gnn.parsers") basic = types.ModuleType("gnn.parsers.basic")