Skip to content

Assess refactor of code hydrating DbType for MsSql #1914

Description

The only additional step that MsSqlMetadataProvider.PopulateColumnDefinitionWithHasDefaultAndDbType performs different than its base class's definition is:

if (columnDefinition.SystemType == typeof(DateTime) || columnDefinition.SystemType == typeof(DateTimeOffset))

and same for MsSqlMetadataProvider.FillSchemaForStoredProcedureAsync:

if (paramDefinition.SystemType == typeof(DateTime) || paramDefinition.SystemType == typeof(DateTimeOffset))

Need to assess this code duplication later and refactor accordingly if required.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions