Refactor the applyChatResponse command by extracting complex response processing, configuration retrieval, file checking, and review cleanup logic into dedicated utility modules to improve maintainability and separation of concerns

Author: robertpiosik

packages/vscode/src/commands/apply-chat-response-command/apply-chat-response-command.ts

@@ -0,0 +1,185 @@
+import * as vscode from 'vscode'
+import {
+  ModelProvidersManager,
+  get_tool_config_id
+} from '@/services/model-providers-manager'
+import { LAST_SELECTED_INTELLIGENT_UPDATE_CONFIG_ID_STATE_KEY } from '@/constants/state-keys'
+import { dictionary } from '@shared/constants/dictionary'
+import { Logger } from '@shared/utils/logger'
+
+export const get_intelligent_update_config = async (
+  api_providers_manager: ModelProvidersManager,
+  show_quick_pick: boolean = false,
+  context: vscode.ExtensionContext
+): Promise<{ provider: any; config: any } | undefined> => {
+  const intelligent_update_configs =
+    await api_providers_manager.get_intelligent_update_tool_configs()
+
+  if (intelligent_update_configs.length == 0) {
+    vscode.commands.executeCommand('codeWebChat.settings')
+    vscode.window.showInformationMessage(
+      dictionary.information_message.NO_INTELLIGENT_UPDATE_CONFIGURATIONS_FOUND
+    )
+    return
+  }
+
+  let selected_config = null
+
+  if (!show_quick_pick) {
+    selected_config =
+      await api_providers_manager.get_default_intelligent_update_config()
+  }
+
+  if (!selected_config || show_quick_pick) {
+    const set_default_button = {
+      iconPath: new vscode.ThemeIcon('star'),
+      tooltip: 'Set as default'
+    }
+
+    const unset_default_button = {
+      iconPath: new vscode.ThemeIcon('star-full'),
+      tooltip: 'Unset default'
+    }
+
+    const create_items = async () => {
+      const default_config =
+        await api_providers_manager.get_default_intelligent_update_config()
+
+      return intelligent_update_configs.map((config, index) => {
+        const buttons = []
+
+        const is_default =
+          default_config &&
+          default_config.provider_type == config.provider_type &&
+          default_config.provider_name == config.provider_name &&
+          default_config.model == config.model
+
+        if (is_default) {
+          buttons.push(unset_default_button)
+        } else {
+          buttons.push(set_default_button)
+        }
+
+        return {
+          label: config.model,
+          description: `${
+            config.reasoning_effort ? `${config.reasoning_effort}` : ''
+          }${
+            config.reasoning_effort
+              ? ` · ${config.provider_name}`
+              : `${config.provider_name}`
+          }`,
+          config,
+          index,
+          id: get_tool_config_id(config),
+          buttons
+        }
+      })
+    }
+
+    const quick_pick = vscode.window.createQuickPick()
+    const items = await create_items()
+    quick_pick.items = items
+    quick_pick.placeholder = 'Select intelligent update configuration'
+    quick_pick.matchOnDescription = true
+
+    const last_selected_id =
+      context.workspaceState.get<string>(
+        LAST_SELECTED_INTELLIGENT_UPDATE_CONFIG_ID_STATE_KEY
+      ) ??
+      context.globalState.get<string>(
+        LAST_SELECTED_INTELLIGENT_UPDATE_CONFIG_ID_STATE_KEY
+      )
+    const last_selected_item = items.find((item) => item.id == last_selected_id)
+
+    if (last_selected_item) {
+      quick_pick.activeItems = [last_selected_item]
+    } else if (items.length > 0) {
+      quick_pick.activeItems = [items[0]]
+    }
+
+    return new Promise<{ provider: any; config: any } | undefined>(
+      (resolve) => {
+        quick_pick.onDidTriggerItemButton(async (event) => {
+          const item = event.item as any
+          const button = event.button
+          const index = item.index
+
+          if (button === set_default_button) {
+            await api_providers_manager.set_default_intelligent_update_config(
+              intelligent_update_configs[index]
+            )
+            quick_pick.items = await create_items()
+          } else if (button === unset_default_button) {
+            await api_providers_manager.set_default_intelligent_update_config(
+              null as any
+            )
+            quick_pick.items = await create_items()
+          }
+        })
+
+        quick_pick.onDidAccept(async () => {
+          const selected = quick_pick.selectedItems[0] as any
+          quick_pick.hide()
+
+          if (!selected) {
+            resolve(undefined)
+            return
+          }
+
+          context.workspaceState.update(
+            LAST_SELECTED_INTELLIGENT_UPDATE_CONFIG_ID_STATE_KEY,
+            selected.id
+          )
+          context.globalState.update(
+            LAST_SELECTED_INTELLIGENT_UPDATE_CONFIG_ID_STATE_KEY,
+            selected.id
+          )
+
+          const provider = await api_providers_manager.get_provider(
+            selected.config.provider_name
+          )
+          if (!provider) {
+            vscode.window.showErrorMessage(
+              dictionary.error_message.API_PROVIDER_FOR_CONFIG_NOT_FOUND
+            )
+            resolve(undefined)
+            return
+          }
+
+          resolve({
+            provider,
+            config: selected.config
+          })
+        })
+
+        quick_pick.onDidHide(() => {
+          quick_pick.dispose()
+          resolve(undefined)
+        })
+
+        quick_pick.show()
+      }
+    )
+  }
+
+  const provider = await api_providers_manager.get_provider(
+    selected_config.provider_name
+  )
+
+  if (!provider) {
+    vscode.window.showErrorMessage(
+      dictionary.error_message.API_PROVIDER_NOT_FOUND
+    )
+    Logger.warn({
+      function_name: 'get_intelligent_update_config',
+      message: 'API provider not found for Intelligent Update API tool.'
+    })
+    return
+  }
+
+  return {
+    provider,
+    config: selected_config
+  }
+}

packages/vscode/src/commands/apply-chat-response-command/response-processor.ts

@@ -0,0 +1,29 @@
+import * as vscode from 'vscode'
+import * as fs from 'fs'
+import { ClipboardFile } from './clipboard-parser'
+import { create_safe_path } from '@/utils/path-sanitizer'
+
+export const check_if_all_files_new = async (
+  files: ClipboardFile[]
+): Promise<boolean> => {
+  const workspace_map = new Map<string, string>()
+  vscode.workspace.workspaceFolders!.forEach((folder) => {
+    workspace_map.set(folder.name, folder.uri.fsPath)
+  })
+  const default_workspace = vscode.workspace.workspaceFolders![0].uri.fsPath
+
+  for (const file of files) {
+    let workspace_root = default_workspace
+    if (file.workspace_name && workspace_map.has(file.workspace_name)) {
+      workspace_root = workspace_map.get(file.workspace_name)!
+    }
+
+    const safe_path = create_safe_path(workspace_root, file.file_path)
+
+    if (safe_path && fs.existsSync(safe_path)) {
+      return false
+    }
+  }
+
+  return true
+}

packages/vscode/src/commands/apply-chat-response-command/utils/config-picker.ts

@@ -0,0 +1,106 @@
+import * as vscode from 'vscode'
+import { Logger } from '@shared/utils/logger'
+import { OriginalFileState } from '../types/original-file-state'
+import { undo_files } from './file-operations'
+import { review } from './review/review'
+import { PanelProvider } from '@/views/panel/backend/panel-provider'
+import { update_undo_button_state } from './state-manager'
+
+export let ongoing_review_cleanup_promise: Promise<void> | null = null
+
+export const handle_code_review_and_cleanup = async (params: {
+  original_states: OriginalFileState[]
+  chat_response: string
+  panel_provider: PanelProvider
+  context: vscode.ExtensionContext
+  original_editor_state?: {
+    file_path: string
+    position: { line: number; character: number }
+  }
+  raw_instructions?: string
+}): Promise<boolean> => {
+  let resolve_cleanup_promise: () => void
+  ongoing_review_cleanup_promise = new Promise((resolve) => {
+    resolve_cleanup_promise = resolve
+  })
+
+  try {
+    const review_result = await review({
+      original_states: params.original_states,
+      panel_provider: params.panel_provider,
+      raw_instructions: params.raw_instructions
+    })
+
+    if (review_result === null || review_result.accepted_files.length == 0) {
+      if (params.original_editor_state) {
+        try {
+          const uri = vscode.Uri.file(params.original_editor_state.file_path)
+          const document = await vscode.workspace.openTextDocument(uri)
+          const editor = await vscode.window.showTextDocument(document, {
+            preview: false
+          })
+          const position = new vscode.Position(
+            params.original_editor_state.position.line,
+            params.original_editor_state.position.character
+          )
+          editor.selection = new vscode.Selection(position, position)
+          editor.revealRange(
+            new vscode.Range(position, position),
+            vscode.TextEditorRevealType.InCenter
+          )
+        } catch (error) {
+          Logger.error({
+            function_name: 'handle_code_review_and_cleanup',
+            message: 'Error restoring original editor state',
+            data: error
+          })
+        }
+      }
+      await undo_files({
+        original_states: params.original_states
+      })
+      update_undo_button_state({
+        context: params.context,
+        panel_provider: params.panel_provider,
+        states: null
+      })
+      return false
+    }
+
+    if (review_result.rejected_states.length > 0) {
+      await undo_files({
+        original_states: review_result.rejected_states
+      })
+    }
+
+    const accepted_states = params.original_states.filter((state) =>
+      review_result.accepted_files.some(
+        (accepted) =>
+          accepted.file_path == state.file_path &&
+          accepted.workspace_name == state.workspace_name
+      )
+    )
+
+    if (accepted_states.length > 0) {
+      update_undo_button_state({
+        context: params.context,
+        panel_provider: params.panel_provider,
+        states: accepted_states,
+        applied_content: params.chat_response,
+        original_editor_state: params.original_editor_state
+      })
+
+      return true
+    } else {
+      update_undo_button_state({
+        context: params.context,
+        panel_provider: params.panel_provider,
+        states: null
+      })
+      return false
+    }
+  } finally {
+    resolve_cleanup_promise!()
+    ongoing_review_cleanup_promise = null
+  }
+}

packages/vscode/src/commands/apply-chat-response-command/utils/file-checks.ts

@@ -0,0 +1,42 @@
+import { createTwoFilesPatch } from 'diff'
+
+export const get_diff_stats = (params: {
+  original_content: string
+  new_content: string
+}): { lines_added: number; lines_removed: number } => {
+  const original_content_processed = params.original_content
+    .split(/\r?\n/)
+    .map((line) => line.trim())
+    .join('\n')
+  const new_content_processed = params.new_content
+    .split(/\r?\n/)
+    .map((line) => line.trim())
+    .join('\n')
+  if (original_content_processed === new_content_processed) {
+    return { lines_added: 0, lines_removed: 0 }
+  }
+
+  const patch = createTwoFilesPatch(
+    'original',
+    'modified',
+    original_content_processed,
+    new_content_processed,
+    undefined,
+    undefined,
+    { context: 0 }
+  )
+
+  let lines_added = 0
+  let lines_removed = 0
+
+  const lines = patch.split('\n')
+  for (const line of lines) {
+    if (line.startsWith('+') && !line.startsWith('+++')) {
+      lines_added++
+    } else if (line.startsWith('-') && !line.startsWith('---')) {
+      lines_removed++
+    }
+  }
+
+  return { lines_added, lines_removed }
+}