Skip to content

Commit 03e6639

Browse files
committed
Remove instructions_placement from API tool configuration comparisons and type definitions
1 parent c2b0fbc commit 03e6639

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

‎packages/vscode/src/views/panel/backend/message-handlers/handle-get-api-tool-configurations.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ export const handle_get_api_tool_configurations = async (
3333
default_config.model == config.model &&
3434
default_config.temperature == config.temperature &&
3535
default_config.reasoning_effort == config.reasoning_effort &&
36-
default_config.max_concurrency == config.max_concurrency &&
37-
default_config.instructions_placement == config.instructions_placement
36+
default_config.max_concurrency == config.max_concurrency
3837
)
3938
}
4039

‎packages/vscode/src/views/panel/types/messages.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ export type ApiToolConfiguration = {
2222
provider_type: string
2323
provider_name: string
2424
model: string
25-
temperature: number
25+
temperature?: number
2626
reasoning_effort?: string
27+
max_concurrency?: number
2728
is_default?: boolean
2829
is_pinned?: boolean
2930
}

‎packages/vscode/src/views/settings/backend/message-handlers/handle-get-edit-context-configurations.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ const create_description = (config: ToolConfig): string => {
1414
if (config.reasoning_effort) {
1515
description_parts.push(`${config.reasoning_effort}`)
1616
}
17-
if (config.instructions_placement == 'below-only') {
18-
description_parts.push('cache-enabled')
19-
}
2017
return description_parts.join(' · ')
2118
}
2219

0 commit comments

Comments
 (0)