Skip to content

Commit 0a1e13d

Browse files
committed
Refactor the settings layout to use an absolute positioned sidebar and responsive content padding
1 parent bbd28f7 commit 0a1e13d

3 files changed

Lines changed: 36 additions & 11 deletions

File tree

‎packages/ui/src/components/editor/settings/Layout/Layout.module.scss‎

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,29 @@
11
.container {
22
display: flex;
3-
gap: var(--padding-60px);
43
width: 100%;
54
height: 100%;
6-
padding-left: var(--padding-60px);
75
overflow: hidden;
8-
@media (min-width: 920px) {
9-
padding-left: calc((100vw - 800px) / 2);
6+
--sidebar-width: 150px;
7+
@media (min-width: 770px) {
8+
--sidebar-width: 180px;
109
}
1110
}
1211

1312
.sidebar {
14-
width: 180px;
15-
padding-top: var(--padding-60px);
13+
position: absolute;
14+
z-index: 1;
1615
display: flex;
1716
flex-direction: column;
1817
gap: 30px;
18+
width: var(--sidebar-width);
19+
top: var(--padding-60px);
20+
left: var(--padding-30px);
21+
@media (min-width: 770px) {
22+
left: var(--padding-60px);
23+
}
24+
@media (min-width: 920px) {
25+
left: calc(calc((100vw - 800px) / 2));
26+
}
1927

2028
&__title {
2129
font-size: 22px;
@@ -38,10 +46,17 @@
3846
&__inner {
3947
display: flex;
4048
flex-direction: column;
41-
gap: var(--padding-60px);
42-
padding: var(--padding-60px) var(--padding-60px) 0 0;
49+
padding: 0 var(--padding-30px) 0
50+
calc(var(--sidebar-width) + var(--padding-30px) + var(--padding-30px));
51+
@media (min-width: 770px) {
52+
padding: 0 var(--padding-60px) 0
53+
calc(var(--sidebar-width) + var(--padding-60px) + var(--padding-60px));
54+
}
4355
@media (min-width: 920px) {
44-
padding-right: calc((100vw - 800px) / 2);
56+
padding: 0 calc((100vw - 800px) / 2) 0
57+
calc(
58+
calc((100vw - 800px) / 2) + var(--sidebar-width) + var(--padding-60px)
59+
);
4560
}
4661
}
4762
}

‎packages/ui/src/components/editor/settings/Section/Section.module.scss‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,26 @@
11
.container {
2-
scroll-margin-top: var(--padding-60px);
32
display: flex;
43
flex-direction: column;
54
gap: var(--padding-24px);
6-
padding-top: var(--padding-2px); // to align with the sidebar title
5+
6+
&--stuck {
7+
box-shadow: var(--vscode-scrollbar-shadow) 0 6px 6px -6px;
8+
}
79
}
810

911
.header {
12+
position: sticky;
13+
z-index: 1;
14+
top: 0;
1015
display: flex;
1116
flex-direction: column;
1217
gap: var(--padding-4px);
18+
padding-top: calc(
19+
var(--padding-60px) + var(--padding-2px)
20+
); // to align with the sidebar title
1321
border-bottom: 2px solid var(--vscode-editorWidget-border);
1422
padding-bottom: var(--padding-10px);
23+
background-color: var(--vscode-editor-background);
1524
}
1625

1726
.title {

‎packages/ui/src/styles/foundation/_variables.scss‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
--padding-18px: 18px;
1616
--padding-20px: 20px;
1717
--padding-24px: 24px;
18+
--padding-30px: 30px;
1819
--padding-60px: 60px;
1920

2021
--font-size-11px: 11px;

0 commit comments

Comments
 (0)