Refactor chat history navigation to correctly restore the caret position after updating the input value

Author: robertpiosik

packages/ui/src/components/editor/panel/ChatInput/hooks/use-handlers.ts

@@ -362,20 +362,30 @@ export const use_handlers = (
 
     e.preventDefault()
 
+    const update_and_set_caret = (value: string) => {
+      props.on_change(value)
+      set_caret_position_after_change(
+        input_ref,
+        value.length,
+        value,
+        props.context_file_paths ?? []
+      )
+    }
+
     if (e.key === 'ArrowUp') {
       if (history_index < active_history.length - 1) {
         const new_index = history_index + 1
         set_history_index(new_index)
-        props.on_change(active_history[new_index])
+        update_and_set_caret(active_history[new_index])
       }
     } else if (e.key === 'ArrowDown') {
       if (history_index > 0) {
         const new_index = history_index - 1
         set_history_index(new_index)
-        props.on_change(active_history[new_index])
+        update_and_set_caret(active_history[new_index])
       } else if (history_index === 0) {
         set_history_index(-1)
-        props.on_change('')
+        update_and_set_caret('')
       }
     }
   }

packages/vscode/package.json

@@ -591,7 +591,7 @@
           "type": "string",
           "scope": "resource",
           "description": "System instructions for the Edit Context API tool.",
-          "default": "You're a helpful coding assistant. Don't introduce redundant comments in code."
+          "default": "You're a helpful coding assistant. Don't explain changes in inline comments."
         },
         "codeWebChat.chatPresetsForAskAboutContext": {
           "type": "array",

packages/vscode/src/views/panel/backend/message-handlers/handle-at-sign-quick-pick/handle-at-sign-quick-pick.ts

@@ -68,7 +68,7 @@ const at_sign_quick_pick = async (params: {
     })
 
     if (filtered_paths.length == 1) {
-      return `\`${filtered_paths[0]}\` `
+      return `\`${filtered_paths[0]}\``
     } else if (filtered_paths.length > 1) {
       const filtered_paths_set = new Set(filtered_paths)
       quick_pick_items_to_show = all_quick_pick_items.filter((item) =>
@@ -94,7 +94,7 @@ const at_sign_quick_pick = async (params: {
   )
 
   if (selected_path_item) {
-    return `\`${selected_path_item.fullPath}\` `
+    return `\`${selected_path_item.fullPath}\``
   }
   return
 }