Skip to content

Commit 1390dbf

Browse files
committed
Add delay_visibility support to progress modal and reduce visibility delay to 500ms
- some responses are really quick to parse and don't use 'Prompt view', with them we should not show progress modal. example responses: commit messages, code at cursor, intelligent search ├── apps │ └── editor │ └── src │ ├── commands │ │ └── apply-response-command │ │ ├── apply-response-command.ts │ │ ├── response-processor │ │ │ ├── handlers │ │ │ │ ├── diff-handler.ts │ │ │ │ ├── fast-replace-handler.ts │ │ │ │ ├── patch-repair-handler.ts │ │ │ │ ├── restore-preview-handler.ts │ │ │ │ ├── search-replace-handler.ts │ │ │ │ └── truncated-handler.ts │ │ │ ├── index.ts │ │ │ └── response-processor.ts │ │ └── utils │ │ └── response-parser │ │ ├── parsers │ │ │ ├── code-at-cursor-parser │ │ │ │ ├── code-at-cursor-parser.ts │ │ │ │ └── test │ │ │ │ └── code-at-cursor-parser.spec.ts │ │ │ ├── commit-message-parser │ │ │ │ ├── commit-message-parser.ts │ │ │ │ └── test │ │ │ │ └── commit-message-parser.spec.ts │ │ │ ├── index.ts │ │ │ └── intelligent-file-search-results-parser │ │ │ └── intelligent-file-search-results-parser.ts │ │ └── response-parser.ts │ └── views │ └── prompt │ ├── frontend │ │ ├── Prompt.tsx │ │ └── hooks │ │ └── use-modal-manager.ts │ └── types │ └── messages.ts └── packages └── ui └── src └── components └── editor └── prompt-view └── modals └── ProgressModal └── ProgressModal.tsx
1 parent c4203ea commit 1390dbf

4 files changed

Lines changed: 6 additions & 3 deletions

File tree

‎apps/editor/src/commands/apply-response-command/apply-response-command.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ export const apply_response_command = (params: {
103103
params.prompt_view_provider.send_message({
104104
command: 'SHOW_PROGRESS',
105105
title: t('common.progress.response-preview'),
106-
subtitle: t('common.progress.preparing')
106+
subtitle: t('common.progress.preparing'),
107+
delay_visibility: true
107108
})
108109
}
109110

‎apps/editor/src/views/prompt/frontend/hooks/use-modal-manager.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ export const use_modal_manager = () => {
3232
title: message.title,
3333
subtitle: message.subtitle,
3434
progress: message.progress,
35-
cancellable: message.cancellable ?? false
35+
cancellable: message.cancellable ?? false,
36+
delay_visibility: message.delay_visibility
3637
})
3738
} else if (message.command === 'HIDE_PROGRESS') {
3839
set_progress_state(undefined)

‎apps/editor/src/views/prompt/types/messages.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -963,6 +963,7 @@ export interface ShowProgressMessage extends BaseMessage {
963963
subtitle?: string
964964
progress?: number
965965
cancellable?: boolean
966+
delay_visibility?: boolean
966967
}
967968

968969
export interface HideProgressMessage extends BaseMessage {

‎packages/ui/src/components/editor/prompt-view/modals/ProgressModal/ProgressModal.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const ProgressModal: React.FC<Props> = (props) => {
2929
set_is_visible(false)
3030
visibility_timer = setTimeout(() => {
3131
set_is_visible(true)
32-
}, 1500)
32+
}, 500)
3333
} else {
3434
set_is_visible(true)
3535
}

0 commit comments

Comments
 (0)