Simplify caret position restoration logic in PromptField and remove redundant task forwarding handler

Author: robertpiosik

packages/ui/src/components/editor/panel/PromptField/PromptField.tsx

@@ -170,19 +170,10 @@ export const PromptField: React.FC<PromptFieldProps> = (props) => {
 
   useEffect(() => {
     if (input_ref.current && input_ref.current.innerHTML !== highlighted_html) {
-      const selection = window.getSelection()
-      const should_restore_caret =
-        document.activeElement === input_ref.current &&
-        selection &&
-        selection.rangeCount > 0 &&
-        selection.anchorNode &&
-        input_ref.current.contains(selection.anchorNode)
-
-      const selection_start = should_restore_caret
-        ? get_caret_position_from_div(input_ref.current)
-        : 0
+      const is_focused = document.activeElement === input_ref.current
+      const selection_start = get_caret_position_from_div(input_ref.current)
       input_ref.current.innerHTML = highlighted_html
-      if (should_restore_caret) {
+      if (is_focused) {
         set_caret_position_for_div(input_ref.current, selection_start)
       }
     }

packages/vscode/src/views/panel/frontend/Home/Home.tsx

@@ -55,13 +55,8 @@ export const Home: React.FC<Props> = (props) => {
     handle_change,
     handle_add,
     handle_add_subtask,
-    handle_delete,
-    handle_forward
-  } = use_tasks(
-    props.on_tasks_change,
-    props.on_task_delete,
-    props.on_task_forward
-  )
+    handle_delete
+  } = use_tasks(props.on_tasks_change, props.on_task_delete)
 
   const { is_timeline_reached, timeline_ref, handle_scroll_to_timeline } =
     use_timeline_scroll()
@@ -247,7 +242,7 @@ export const Home: React.FC<Props> = (props) => {
                           handle_delete(workspace_root_folder, timestamp)
                         }}
                         on_forward={(text) => {
-                          handle_forward(text)
+                          props.on_task_forward(text)
                         }}
                       />
                     )}

packages/vscode/src/views/panel/frontend/Home/hooks/use-tasks.ts

@@ -37,8 +37,7 @@ const add_subtask_to_tree = (
 
 export const use_tasks = (
   on_tasks_change: (root: string, tasks: Task[]) => void,
-  on_task_delete: (root: string, timestamp: number) => void,
-  on_task_forward: (text: string) => void
+  on_task_delete: (root: string, timestamp: number) => void
 ) => {
   const handle_reorder = (root: string, new_tasks: Task[]) => {
     on_tasks_change(root, new_tasks)
@@ -82,16 +81,11 @@ export const use_tasks = (
     on_task_delete(root, timestamp)
   }
 
-  const handle_forward = (text: string) => {
-    on_task_forward(text)
-  }
-
   return {
     handle_reorder,
     handle_change,
     handle_add,
     handle_add_subtask,
-    handle_delete,
-    handle_forward
+    handle_delete
   }
 }