Refactor checkpoint lifespan to use a centralized constant and support undefined values in configuration

Author: robertpiosik

apps/editor/src/commands/checkpoints-command/actions/get-checkpoints.ts

@@ -2,15 +2,15 @@ import * as vscode from 'vscode'
 import { CHECKPOINTS_STATE_KEY } from '../../../constants/state-keys'
 import type { Checkpoint } from '../types'
 import { get_checkpoint_path } from '../utils'
-
 import { Logger } from '@shared/utils/logger'
+import { CHECKPOINT_DEFAULT_LIFESPAN } from '@/constants/values'
 
 export const remove_old_checkpoints = async (
   checkpoints: Checkpoint[]
 ): Promise<Checkpoint[]> => {
   const config = vscode.workspace.getConfiguration('codeWebChat')
   const checkpoint_lifespan_hours =
-    config.get<number>('checkpointLifespan') || 24
+    config.get<number>('checkpointLifespan') || CHECKPOINT_DEFAULT_LIFESPAN
   const checkpoint_lifespan_ms = checkpoint_lifespan_hours * 60 * 60 * 1000
 
   const now = Date.now()

apps/editor/src/constants/values.ts

@@ -0,0 +1 @@
+export const CHECKPOINT_DEFAULT_LIFESPAN = 24

apps/editor/src/views/settings/backend/message-handlers/handle-get-checkpoint-lifespan.ts

@@ -1,10 +1,12 @@
 import * as vscode from 'vscode'
 import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import { CHECKPOINT_DEFAULT_LIFESPAN } from '@/constants/values'
 
 export const handle_get_checkpoint_lifespan = async (
   provider: SettingsProvider
 ): Promise<void> => {
   const config = vscode.workspace.getConfiguration('codeWebChat')
-  const hours = config.get<number>('checkpointLifespan', 24)
+  const hours =
+    config.get<number>('checkpointLifespan') || CHECKPOINT_DEFAULT_LIFESPAN
   provider.postMessage({ command: 'CHECKPOINT_LIFESPAN', hours })
 }

apps/editor/src/views/settings/backend/message-handlers/handle-update-checkpoint-lifespan.ts

@@ -0,0 +1,14 @@
+import * as vscode from 'vscode'
+import { UpdateCheckpointLifespanMessage } from '@/views/settings/types/messages'
+
+export const handle_update_checkpoint_lifespan = async (
+  message: UpdateCheckpointLifespanMessage
+) => {
+  await vscode.workspace
+    .getConfiguration('codeWebChat')
+    .update(
+      'checkpointLifespan',
+      message.hours ?? undefined,
+      vscode.ConfigurationTarget.Global
+    )
+}

apps/editor/src/views/settings/backend/message-handlers/index.ts

@@ -25,6 +25,7 @@ export * from './handle-update-context-size-warning-threshold'
 export * from './handle-get-are-automatic-checkpoints-disabled'
 export * from './handle-update-are-automatic-checkpoints-disabled'
 export * from './handle-get-checkpoint-lifespan'
+export * from './handle-update-checkpoint-lifespan'
 export * from './handle-upsert-configuration'
 export * from './handle-open-ignore-patterns-settings'
 export * from './handle-open-allow-patterns-settings'

apps/editor/src/views/settings/backend/settings-provider.ts

@@ -22,6 +22,7 @@ import {
   handle_get_ai_studio_user_id,
   handle_get_model_providers,
   handle_get_send_with_shift_enter,
+  handle_update_checkpoint_lifespan,
   handle_get_checkpoint_lifespan,
   handle_reorder_configuration,
   handle_reorder_model_providers,
@@ -273,13 +274,7 @@ export class SettingsProvider {
         ) {
           await handle_update_are_automatic_checkpoints_disabled(message)
         } else if (message.command == 'UPDATE_CHECKPOINT_LIFESPAN') {
-          await vscode.workspace
-            .getConfiguration('codeWebChat')
-            .update(
-              'checkpointLifespan',
-              message.hours,
-              vscode.ConfigurationTarget.Global
-            )
+          await handle_update_checkpoint_lifespan(message)
         } else if (message.command == 'OPEN_EDITOR_SETTINGS') {
           await vscode.commands.executeCommand('workbench.action.openSettings')
         } else if (message.command == 'OPEN_IGNORE_PATTERNS_SETTINGS') {

apps/editor/src/views/settings/frontend/Home/Home.tsx

@@ -101,7 +101,7 @@ type Props = {
   ) => void
   on_edit_context_system_instructions_change: (instructions: string) => void
   on_automatic_checkpoints_toggle: (disabled: boolean) => void
-  on_checkpoint_lifespan_change: (hours: number) => void
+  on_checkpoint_lifespan_change: (hours: number | undefined) => void
   on_gemini_user_id_change: (id: number | null) => void
   on_ai_studio_user_id_change: (id: number | null) => void
   on_send_with_shift_enter_change: (enabled: boolean) => void

apps/editor/src/views/settings/frontend/Home/sections/GeneralSection.tsx

@@ -29,7 +29,7 @@ type Props = {
   on_automatic_checkpoints_toggle: (disabled: boolean) => void
   on_send_with_shift_enter_change: (enabled: boolean) => void
   on_check_new_files_change: (enabled: boolean) => void
-  on_checkpoint_lifespan_change: (hours: number) => void
+  on_checkpoint_lifespan_change: (hours: number | undefined) => void
   clear_checks_in_workspace_behavior: ClearChecksBehavior
   edit_format_instructions: EditFormatInstructions
   on_context_size_warning_threshold_change: (threshold: number) => void
@@ -109,6 +109,8 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
       const num_hours = parseInt(checkpoint_lifespan_str, 10)
       if (!isNaN(num_hours) && num_hours > 0) {
         props.on_checkpoint_lifespan_change(num_hours)
+      } else {
+        props.on_checkpoint_lifespan_change(undefined)
       }
     }
 
@@ -241,7 +243,6 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
                 on_change={set_checkpoint_lifespan_str}
                 on_blur={handle_checkpoint_lifespan_blur}
                 max_width={100}
-                min={1}
               />
             }
           />

apps/editor/src/views/settings/frontend/hooks/use-settings.ts

@@ -298,10 +298,10 @@ export const use_settings = (vscode: any) => {
     })
   }
 
-  const handle_checkpoint_lifespan_change = (hours: number) =>
+  const handle_checkpoint_lifespan_change = (hours: number | undefined) =>
     post_message(vscode, {
       command: 'UPDATE_CHECKPOINT_LIFESPAN',
-      hours
+      hours: hours ?? null
     })
 
   const handle_gemini_user_id_change = (geminiUserId: number | null) =>

apps/editor/src/views/settings/types/messages.ts

@@ -218,7 +218,7 @@ export interface GetCheckpointLifespanMessage {
 
 export interface UpdateCheckpointLifespanMessage {
   command: 'UPDATE_CHECKPOINT_LIFESPAN'
-  hours: number
+  hours: number | null
 }
 
 export interface GetGeminiUserIdMessage {