Remove duplicate recent presets tracking and consolidate state updates in update_last_used_preset_or_group

Author: robertpiosik

packages/vscode/src/views/panel/backend/message-handlers/handle-send-prompt.ts

@@ -91,26 +91,6 @@ export const handle_send_prompt = async (params: {
       preset_name: params.preset_name,
       group_name: params.group_name
     })
-
-    const name_to_save = params.preset_name || params.group_name
-    if (name_to_save) {
-      const mode = params.panel_provider.web_prompt_type
-      const recents_key = get_recently_used_presets_or_groups_key(mode)
-      const context = params.panel_provider.context
-
-      const recents =
-        context.workspaceState.get<string[]>(recents_key) ??
-        context.globalState.get<string[]>(recents_key) ??
-        []
-
-      const new_recents = [
-        name_to_save,
-        ...recents.filter((r) => r != name_to_save)
-      ].slice(0, 10)
-
-      context.workspaceState.update(recents_key, new_recents)
-      context.globalState.update(recents_key, new_recents)
-    }
   }
 
   await vscode.workspace.saveAll()
@@ -468,18 +448,6 @@ async function show_preset_quick_pick(params: {
             preset_name: selected.preset_name,
             group_name: group_name
           })
-          const name_to_save = selected.preset_name
-          const recents_key = get_recently_used_presets_or_groups_key(mode)
-          const recents =
-            context.workspaceState.get<string[]>(recents_key) ??
-            context.globalState.get<string[]>(recents_key) ??
-            []
-          const newRecents = [
-            name_to_save,
-            ...recents.filter((r) => r != name_to_save)
-          ].slice(0, 10)
-          context.workspaceState.update(recents_key, newRecents)
-          context.globalState.update(recents_key, newRecents)
           do_resolve({ preset_names: [selected.preset_name] })
         }
       } else if (selected.group_name) {
@@ -505,17 +473,6 @@ async function show_preset_quick_pick(params: {
 
         if (preset_names.length > 0) {
           update_last_used_preset_or_group({ panel_provider, group_name })
-          const recents_key = get_recently_used_presets_or_groups_key(mode)
-          const recents =
-            context.workspaceState.get<string[]>(recents_key) ??
-            context.globalState.get<string[]>(recents_key) ??
-            []
-          const newRecents = [
-            group_name,
-            ...recents.filter((r) => r !== group_name)
-          ].slice(0, 10)
-          context.workspaceState.update(recents_key, newRecents)
-          context.globalState.update(recents_key, newRecents)
           do_resolve({ preset_names })
         }
       } else {

packages/vscode/src/views/panel/backend/message-handlers/update-last-used-preset-or-group.ts

@@ -13,16 +13,18 @@ export const update_last_used_preset_or_group = (params: {
       params.panel_provider.web_prompt_type
     )
     const recents =
-      params.panel_provider.context.globalState.get<string[]>(
-        recents_key,
-        []
-      ) ?? []
+      params.panel_provider.context.workspaceState.get<string[]>(recents_key) ??
+      params.panel_provider.context.globalState.get<string[]>(recents_key, [])
 
     const new_recents = [
       name_to_save,
       ...recents.filter((r) => r != name_to_save)
     ].slice(0, 10)
 
+    params.panel_provider.context.workspaceState.update(
+      recents_key,
+      new_recents
+    )
     params.panel_provider.context.globalState.update(recents_key, new_recents)
 
     params.panel_provider.send_message({

packages/vscode/src/views/panel/backend/panel-provider.ts

@@ -789,7 +789,9 @@ export class PanelProvider implements vscode.WebviewViewProvider {
           const presets_for_mode = all_presets[prompt_type]
           let selected_name: string | undefined = undefined
           const key = get_recently_used_presets_or_groups_key(prompt_type)
-          const recents = this.context.globalState.get<string[]>(key, [])
+          const recents =
+            this.context.workspaceState.get<string[]>(key) ??
+            this.context.globalState.get<string[]>(key, [])
           const last_selected = recents[0]
           if (last_selected) {
             if (last_selected == 'Ungrouped') {