Skip to content

Commit 22b61ef

Browse files
committed
Separate pinned and unpinned configurations in quick pick to prevent duplicate entries
- searching shows duplicates
1 parent 7826106 commit 22b61ef

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎apps/editor/src/utils/show-configuration-quick-pick.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,17 @@ export const show_configuration_quick_pick = async <T>(
7272
mapped: map_item(c)
7373
}))
7474
const pinned = mapped_configs.filter((c) => c.mapped.is_pinned)
75+
const unpinned = mapped_configs.filter((c) => !c.mapped.is_pinned)
7576

7677
if (pinned.length > 0) {
7778
items.push({ label: 'pinned', kind: vscode.QuickPickItemKind.Separator })
7879
items.push(...pinned.map((c) => map_to_quick_pick_item(c.config)))
79-
items.push({ label: 'all', kind: vscode.QuickPickItemKind.Separator })
80+
if (unpinned.length > 0) {
81+
items.push({ label: 'all', kind: vscode.QuickPickItemKind.Separator })
82+
}
8083
}
8184

82-
items.push(...mapped_configs.map((c) => map_to_quick_pick_item(c.config)))
85+
items.push(...unpinned.map((c) => map_to_quick_pick_item(c.config)))
8386

8487
const quick_pick = vscode.window.createQuickPick<PickItem>()
8588
quick_pick.items = items

0 commit comments

Comments
 (0)