Skip to content

Commit 22bf56e

Browse files
committed
Rename all references of "FileInReview" to "FileInPreview" and update related UI components and backend logic to reflect the new terminology
1 parent 554b8aa commit 22bf56e

29 files changed

Lines changed: 106 additions & 98 deletions

packages/shared/src/types/file-in-review.ts renamed to packages/shared/src/types/file-in-preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export type FileInReview = {
1+
export type FileInPreview = {
22
file_path: string
33
is_checked: boolean
44
workspace_name?: string

packages/ui/src/components/editor/panel/ResponseReview/ResponseReview.module.scss renamed to packages/ui/src/components/editor/panel/ResponsePreview/ResponsePreview.module.scss

File renamed without changes.

packages/ui/src/components/editor/panel/ResponseReview/ResponseReview.stories.tsx renamed to packages/ui/src/components/editor/panel/ResponsePreview/ResponsePreview.stories.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { useState } from 'react'
2-
import { ResponseReview } from './ResponseReview'
2+
import { ResponsePreview } from './ResponsePreview'
33

44
export default {
5-
component: ResponseReview
5+
component: ResponsePreview
66
}
77

88
const base_files = [
@@ -58,7 +58,7 @@ const log_action =
5858
console.log(action, ...args)
5959
}
6060

61-
const InteractiveResponseReview = (props: any) => {
61+
const InteractiveResponsePreview = (props: any) => {
6262
const [files, set_files] = useState(
6363
props.files.map((f: any) => ({ ...f, is_checked: true }))
6464
)
@@ -83,7 +83,7 @@ const InteractiveResponseReview = (props: any) => {
8383
}
8484

8585
return (
86-
<ResponseReview
86+
<ResponsePreview
8787
{...props}
8888
files={files}
8989
on_toggle_file={handle_toggle_file}
@@ -96,20 +96,20 @@ const InteractiveResponseReview = (props: any) => {
9696
)
9797
}
9898

99-
export const Default = () => <InteractiveResponseReview files={base_files} />
99+
export const Default = () => <InteractiveResponsePreview files={base_files} />
100100

101101
export const WithSingleFile = () => (
102-
<InteractiveResponseReview files={[base_files[0]]} />
102+
<InteractiveResponsePreview files={[base_files[0]]} />
103103
)
104104

105105
export const WithFallbacks = () => (
106-
<InteractiveResponseReview
106+
<InteractiveResponsePreview
107107
files={[...base_files, ...files_using_fallbacks]}
108108
/>
109109
)
110110

111111
export const WithMultipleWorkspaces = () => (
112-
<InteractiveResponseReview
112+
<InteractiveResponsePreview
113113
files={[
114114
{
115115
...base_files[0],

packages/ui/src/components/editor/panel/ResponseReview/ResponseReview.tsx renamed to packages/ui/src/components/editor/panel/ResponsePreview/ResponsePreview.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import { FC, useState, useMemo } from 'react'
2-
import { FileInReview } from '@shared/types/file-in-review'
2+
import { FileInPreview } from '@shared/types/file-in-preview'
33
import cn from 'classnames'
4-
import styles from './ResponseReview.module.scss'
4+
import styles from './ResponsePreview.module.scss'
55
import { Button } from '../Button'
66
import { Checkbox } from '../../common/Checkbox'
77
import { IconButton } from '../IconButton/IconButton'
88

99
type Props = {
10-
files: FileInReview[]
10+
files: FileInPreview[]
1111
has_multiple_workspaces: boolean
1212
on_discard: () => void
13-
on_approve: (files: FileInReview[]) => void
13+
on_approve: (files: FileInPreview[]) => void
1414
on_focus_file: (file: { file_path: string; workspace_name?: string }) => void
1515
on_go_to_file: (file: { file_path: string; workspace_name?: string }) => void
1616
on_intelligent_update: (file: {
@@ -25,7 +25,7 @@ type Props = {
2525
raw_instructions?: string
2626
}
2727

28-
export const ResponseReview: FC<Props> = (props) => {
28+
export const ResponsePreview: FC<Props> = (props) => {
2929
const [last_clicked_file_index, set_last_clicked_file_index] = useState(0)
3030

3131
const handle_approve = () => {
@@ -36,7 +36,7 @@ export const ResponseReview: FC<Props> = (props) => {
3636
const fallback_count = props.files.filter((f) => f.is_fallback).length
3737

3838
const sorted_files = useMemo(() => {
39-
const get_sort_score = (file: FileInReview): number => {
39+
const get_sort_score = (file: FileInPreview): number => {
4040
if (file.diff_fallback_method == 'search_and_replace') {
4141
return 0
4242
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './ResponsePreview'

‎packages/ui/src/components/editor/panel/ResponseReview/index.ts‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎packages/vscode/src/commands/apply-chat-response-command/apply-chat-response-command.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@ import * as vscode from 'vscode'
22
import * as fs from 'fs'
33
import * as path from 'path'
44
import { create_checkpoint } from '../checkpoints-command/actions'
5-
import { FileInReview } from '@shared/types/file-in-review'
5+
import { FileInPreview } from '@shared/types/file-in-preview'
66
import { PanelProvider } from '@/views/panel/backend/panel-provider'
77
import { dictionary } from '@shared/constants/dictionary'
88
import { WorkspaceProvider } from '@/context/providers/workspace-provider'
9-
import { code_review_promise_resolve } from './utils/review/review'
10-
import { get_diff_stats } from './utils/review/diff-utils'
9+
import { code_review_promise_resolve } from './utils/preview/preview'
10+
import { get_diff_stats } from './utils/preview/diff-utils'
1111
import { create_safe_path } from '@/utils/path-sanitizer'
1212
import {
1313
handle_code_review_and_cleanup,
1414
ongoing_review_cleanup_promise
15-
} from './utils/review-handler'
15+
} from './utils/preview-handler'
1616
import { process_chat_response, CommandArgs } from './response-processor'
1717
import { undo_files } from './utils/file-operations'
1818

@@ -76,7 +76,7 @@ export const apply_chat_response_command = (
7676
if (!args?.files_with_content) {
7777
let total_lines_added = 0
7878
let total_lines_removed = 0
79-
const files_for_history: FileInReview[] = []
79+
const files_for_history: FileInPreview[] = []
8080

8181
const workspace_map = new Map<string, string>()
8282
vscode.workspace.workspaceFolders!.forEach((folder) => {

‎packages/vscode/src/commands/apply-chat-response-command/handlers/restore-review-handler.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ import { Logger } from '@shared/utils/logger'
55
import { dictionary } from '@shared/constants/dictionary'
66
import { create_safe_path } from '@/utils/path-sanitizer'
77
import { OriginalFileState } from '../types/original-file-state'
8-
import { FileInReview } from '@shared/types/file-in-review'
8+
import { FileInPreview } from '@shared/types/file-in-preview'
99
import { remove_directory_if_empty } from '../utils/file-operations'
1010

1111
export const handle_restore_review = async (
12-
files: FileInReview[]
12+
files: FileInPreview[]
1313
): Promise<{ success: boolean; original_states?: OriginalFileState[] }> => {
1414
Logger.info({
1515
function_name: 'handle_restore_review',

‎packages/vscode/src/commands/apply-chat-response-command/response-processor.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ import { handle_intelligent_update } from './handlers/intelligent-update-handler
1616
import { check_for_truncated_fragments } from '@/utils/check-for-truncated-fragments'
1717
import { handle_fast_replace } from './handlers/fast-replace-handler'
1818
import { PanelProvider } from '@/views/panel/backend/panel-provider'
19-
import { FileInReview } from '@shared/types/file-in-review'
19+
import { FileInPreview } from '@shared/types/file-in-preview'
2020
import { update_undo_button_state } from './utils/state-manager'
2121
import { check_if_all_files_new } from './utils/file-checks'
2222

23-
export type ReviewData = {
23+
export type PreviewData = {
2424
original_states: OriginalFileState[]
2525
chat_response: string
2626
}
@@ -34,15 +34,15 @@ export type CommandArgs = {
3434
file_path: string
3535
position: { line: number; character: number }
3636
}
37-
files_with_content?: FileInReview[]
37+
files_with_content?: FileInPreview[]
3838
}
3939

4040
export const process_chat_response = async (
4141
args: CommandArgs | undefined,
4242
chat_response: string,
4343
context: vscode.ExtensionContext,
4444
panel_provider: PanelProvider
45-
): Promise<ReviewData | null> => {
45+
): Promise<PreviewData | null> => {
4646
if (args?.files_with_content) {
4747
const result = await handle_restore_review(args.files_with_content)
4848
if (result.success && result.original_states) {

packages/vscode/src/commands/apply-chat-response-command/utils/review-handler.ts renamed to packages/vscode/src/commands/apply-chat-response-command/utils/preview-handler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as vscode from 'vscode'
22
import { Logger } from '@shared/utils/logger'
33
import { OriginalFileState } from '../types/original-file-state'
44
import { undo_files } from './file-operations'
5-
import { review } from './review/review'
5+
import { preview } from './preview'
66
import { PanelProvider } from '@/views/panel/backend/panel-provider'
77
import { update_undo_button_state } from './state-manager'
88

@@ -25,7 +25,7 @@ export const handle_code_review_and_cleanup = async (params: {
2525
})
2626

2727
try {
28-
const review_result = await review({
28+
const review_result = await preview({
2929
original_states: params.original_states,
3030
panel_provider: params.panel_provider,
3131
raw_instructions: params.raw_instructions

0 commit comments

Comments
 (0)