Remove customizable edit format instructions from settings and replace them with hardcoded constants

- remove the ability to edit 'edit formats'
- as we recently removed support for custom edit formats, finish the work [Changes]

├── apps
│   └── editor
│       ├── package.json
│       └── src
│           └── views
│               ├── prompt
│               │   └── backend
│               │       ├── message-handlers
│               │       │   ├── handle-autofill.ts
│               │       │   ├── handle-copy-prompt.ts
│               │       │   ├── handle-get-edit-format-instructions.ts
│               │       │   ├── handle-make-api-call.ts
│               │       │   └── handle-preview-web-configuration.ts
│               │       └── prompt-view-provider.ts
│               └── settings
│                   ├── backend
│                   │   ├── message-handlers
│                   │   │   ├── handle-get-synchronize-edit-format-between-modes.ts
│                   │   │   └── handle-update-synchronize-edit-format-between-modes.ts
│                   │   └── settings-view-provider.ts
│                   ├── frontend
│                   │   ├── Home
│                   │   │   ├── Home.tsx
│                   │   │   └── sections
│                   │   │       └── GeneralSection.tsx
│                   │   └── hooks
│                   │       └── use-settings.ts
│                   └── types
│                       └── messages.ts
└── docs
    └── chatbot-initialization.mdx

Author: robertpiosik

apps/editor/package.json

@@ -1017,22 +1017,6 @@
             "type": "string"
           }
         },
-        "codeWebChat.editFormatInstructionsWhole": {
-          "type": "string",
-          "scope": "resource"
-        },
-        "codeWebChat.editFormatInstructionsTruncated": {
-          "type": "string",
-          "scope": "resource"
-        },
-        "codeWebChat.editFormatInstructionsSearchReplace": {
-          "type": "string",
-          "scope": "resource"
-        },
-        "codeWebChat.editFormatInstructionsDiff": {
-          "type": "string",
-          "scope": "resource"
-        },
         "codeWebChat.findRelevantFilesInstructions": {
           "type": "string",
           "scope": "resource"

apps/editor/src/views/prompt/backend/message-handlers/handle-autofill.ts

@@ -166,21 +166,12 @@ export const handle_autofill = async (params: {
     let formatted_system_instructions = ''
     let user_instructions = processed_instructions
     if (params.prompt_view_provider.web_prompt_type == 'edit-files') {
-      const config = vscode.workspace.getConfiguration('codeWebChat')
-      const instructions_key = {
-        whole: 'editFormatInstructionsWhole',
-        truncated: 'editFormatInstructionsTruncated',
-        'search-replace': 'editFormatInstructionsSearchReplace',
-        diff: 'editFormatInstructionsDiff'
-      }[params.prompt_view_provider.edit_format]
-      const default_instructions = {
+      const edit_format_instructions = {
         whole: EDIT_FORMAT_INSTRUCTIONS_WHOLE,
         truncated: EDIT_FORMAT_INSTRUCTIONS_TRUNCATED,
         'search-replace': EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE,
         diff: EDIT_FORMAT_INSTRUCTIONS_DIFF
       }[params.prompt_view_provider.edit_format]
-      const edit_format_instructions =
-        config.get<string>(instructions_key) || default_instructions
       if (edit_format_instructions) {
         formatted_system_instructions = `# Output formatting\n\n${edit_format_instructions}`
       }

apps/editor/src/views/prompt/backend/message-handlers/handle-copy-prompt.ts

@@ -123,21 +123,12 @@ export const handle_copy_prompt = async (params: {
 
     if (params.prompt_view_provider.prompt_type == 'edit-files') {
       const edit_format = params.prompt_view_provider.edit_format
-      const config = vscode.workspace.getConfiguration('codeWebChat')
-      const instructions_key = {
-        whole: 'editFormatInstructionsWhole',
-        truncated: 'editFormatInstructionsTruncated',
-        'search-replace': 'editFormatInstructionsSearchReplace',
-        diff: 'editFormatInstructionsDiff'
-      }[edit_format]
-      const default_instructions = {
+      const edit_format_instructions = {
         whole: EDIT_FORMAT_INSTRUCTIONS_WHOLE,
         truncated: EDIT_FORMAT_INSTRUCTIONS_TRUNCATED,
         'search-replace': EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE,
         diff: EDIT_FORMAT_INSTRUCTIONS_DIFF
       }[edit_format]
-      const edit_format_instructions =
-        config.get<string>(instructions_key) || default_instructions
       if (edit_format_instructions) {
         formatted_system_instructions = `# Output formatting\n\n${edit_format_instructions}`
       }

apps/editor/src/views/prompt/backend/message-handlers/handle-get-edit-format-instructions.ts

@@ -1,5 +1,4 @@
 import { PromptViewProvider } from '@/views/prompt/backend/prompt-view-provider'
-import * as vscode from 'vscode'
 import { EditFormat } from '@shared/types/edit-format'
 import {
   EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE,
@@ -11,19 +10,11 @@ import {
 export const handle_get_edit_format_instructions = (
   prompt_view_provider: PromptViewProvider
 ) => {
-  const config = vscode.workspace.getConfiguration('codeWebChat')
   const instructions: Record<EditFormat, string> = {
-    whole:
-      config.get('editFormatInstructionsWhole') ||
-      EDIT_FORMAT_INSTRUCTIONS_WHOLE,
-    truncated:
-      config.get('editFormatInstructionsTruncated') ||
-      EDIT_FORMAT_INSTRUCTIONS_TRUNCATED,
-    'search-replace':
-      config.get('editFormatInstructionsSearchReplace') ||
-      EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE,
-    diff:
-      config.get('editFormatInstructionsDiff') || EDIT_FORMAT_INSTRUCTIONS_DIFF
+    whole: EDIT_FORMAT_INSTRUCTIONS_WHOLE,
+    truncated: EDIT_FORMAT_INSTRUCTIONS_TRUNCATED,
+    'search-replace': EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE,
+    diff: EDIT_FORMAT_INSTRUCTIONS_DIFF
   }
   prompt_view_provider.send_message({
     command: 'EDIT_FORMAT_INSTRUCTIONS',

apps/editor/src/views/prompt/backend/message-handlers/handle-make-api-call.ts

@@ -298,21 +298,12 @@ export const handle_make_api_call = async (
 
     if (prompt_type == 'edit-files') {
       edit_format = prompt_view_provider.edit_format
-      const config = vscode.workspace.getConfiguration('codeWebChat')
-      const instructions_key = {
-        whole: 'editFormatInstructionsWhole',
-        truncated: 'editFormatInstructionsTruncated',
-        diff: 'editFormatInstructionsDiff',
-        'search-replace': 'editFormatInstructionsSearchReplace'
-      }[edit_format]
-      const default_instructions = {
+      const edit_format_instructions = {
         whole: EDIT_FORMAT_INSTRUCTIONS_WHOLE,
         truncated: EDIT_FORMAT_INSTRUCTIONS_TRUNCATED,
         diff: EDIT_FORMAT_INSTRUCTIONS_DIFF,
         'search-replace': EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE
       }[edit_format]
-      const edit_format_instructions =
-        config.get<string>(instructions_key) || default_instructions
 
       let formatted_system_instructions = ''
       if (edit_format_instructions) {

apps/editor/src/views/prompt/backend/message-handlers/handle-preview-web-configuration.ts

@@ -114,21 +114,12 @@ export const handle_preview_web_configuration = async (
     let formatted_system_instructions = ''
     let user_instructions = processed_instructions
     if (prompt_view_provider.web_prompt_type == 'edit-files') {
-      const config = vscode.workspace.getConfiguration('codeWebChat')
-      const instructions_key = {
-        whole: 'editFormatInstructionsWhole',
-        truncated: 'editFormatInstructionsTruncated',
-        'search-replace': 'editFormatInstructionsSearchReplace',
-        diff: 'editFormatInstructionsDiff'
-      }[prompt_view_provider.edit_format]
-      const default_instructions = {
+      const edit_format_instructions = {
         whole: EDIT_FORMAT_INSTRUCTIONS_WHOLE,
         truncated: EDIT_FORMAT_INSTRUCTIONS_TRUNCATED,
         'search-replace': EDIT_FORMAT_INSTRUCTIONS_SEARCH_REPLACE,
         diff: EDIT_FORMAT_INSTRUCTIONS_DIFF
       }[prompt_view_provider.edit_format]
-      const edit_format_instructions =
-        config.get<string>(instructions_key) || default_instructions
       if (edit_format_instructions) {
         formatted_system_instructions = `# Output formatting\n\n${edit_format_instructions}`
       }

apps/editor/src/views/prompt/backend/prompt-view-provider.ts

@@ -457,18 +457,6 @@ export class PromptViewProvider implements vscode.WebviewViewProvider {
           this.send_web_configurations_to_webview(this.webview_view.webview)
         }
 
-        if (
-          event.affectsConfiguration(
-            'codeWebChat.editFormatInstructionsWhole'
-          ) ||
-          event.affectsConfiguration(
-            'codeWebChat.editFormatInstructionsTruncated'
-          ) ||
-          event.affectsConfiguration('codeWebChat.editFormatInstructionsDiff')
-        ) {
-          handle_get_edit_format_instructions(this)
-        }
-
         if (
           event.affectsConfiguration('codeWebChat.contextSizeWarningThreshold')
         ) {

apps/editor/src/views/settings/backend/message-handlers/handle-get-edit-format-instructions.ts

@@ -9,8 +9,6 @@ export * from './handle-set-default-api-configuration'
 export * from './handle-select-default-api-configuration'
 export * from './handle-get-edit-files-system-instructions'
 export * from './handle-update-edit-files-system-instructions'
-export * from './handle-get-edit-format-instructions'
-export * from './handle-update-edit-format-instructions'
 export * from './handle-get-commit-message-instructions'
 export * from './handle-update-commit-message-instructions'
 export * from './handle-get-attach-ascii-tree-of-context'