Skip to content

Commit 29be01b

Browse files
committed
Rename ToolConfig to ApiConfiguration and Provider to ModelProvider across the codebase to better reflect their purpose
1 parent 2687785 commit 29be01b

40 files changed

Lines changed: 1006 additions & 1008 deletions

File tree

‎apps/editor/src/commands/apply-chat-response-command/handlers/active-editor-intelligent-update-handler.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { sanitize_file_name, create_safe_path } from '@/utils/path-sanitizer'
99
import { Logger } from '@shared/utils/logger'
1010
import { OriginalFileState } from '@/commands/apply-chat-response-command/types/original-file-state'
1111
import {
12-
ToolConfig,
12+
ApiConfiguration,
1313
ModelProvidersManager
1414
} from '@/services/model-providers-manager'
1515
import { PanelProvider } from '@/views/panel/backend/panel-provider'
@@ -22,7 +22,7 @@ import {
2222
export const handle_active_editor_intelligent_update = async (params: {
2323
endpoint_url: string
2424
api_key: string
25-
config: ToolConfig
25+
api_configuration: ApiConfiguration
2626
chat_response: string
2727
context: vscode.ExtensionContext
2828
is_single_root_folder_workspace: boolean
@@ -122,14 +122,14 @@ export const handle_active_editor_intelligent_update = async (params: {
122122
const updated_content = await process_file({
123123
endpoint_url: params.endpoint_url,
124124
api_key: params.api_key,
125-
provider: {
126-
name: params.config.provider_name,
125+
model_provider: {
126+
name: params.api_configuration.model_provider_name,
127127
base_url: params.endpoint_url,
128128
api_key: params.api_key
129129
},
130-
model: params.config.model,
131-
temperature: params.config.temperature,
132-
reasoning_effort: params.config.reasoning_effort,
130+
model: params.api_configuration.model,
131+
temperature: params.api_configuration.temperature,
132+
reasoning_effort: params.api_configuration.reasoning_effort,
133133
file_path: target_file_path,
134134
file_content: original_content,
135135
instruction: file_item.content,
@@ -200,18 +200,18 @@ export const handle_active_editor_intelligent_update = async (params: {
200200
)
201201

202202
const api_providers_manager = new ModelProvidersManager(params.context)
203-
const config_result = await get_intelligent_update_config(
203+
const api_configuration_result = await get_intelligent_update_config(
204204
api_providers_manager,
205205
true,
206206
params.context
207207
)
208208

209-
if (config_result) {
209+
if (api_configuration_result) {
210210
return await handle_active_editor_intelligent_update({
211211
...params,
212-
endpoint_url: config_result.provider.base_url,
213-
api_key: config_result.provider.api_key,
214-
config: config_result.config
212+
endpoint_url: api_configuration_result.model_provider.base_url,
213+
api_key: api_configuration_result.model_provider.api_key,
214+
api_configuration: api_configuration_result.api_configuration
215215
})
216216
}
217217
}

‎apps/editor/src/commands/apply-chat-response-command/response-processor.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -525,24 +525,24 @@ export const process_chat_response = async (params: {
525525
const api_providers_manager = new ModelProvidersManager(
526526
params.context
527527
)
528-
const config_result = await get_intelligent_update_config(
528+
const api_configuration_result = await get_intelligent_update_config(
529529
api_providers_manager,
530530
false,
531531
params.context
532532
)
533533

534-
if (!config_result) {
534+
if (!api_configuration_result) {
535535
return null
536536
}
537537

538-
const { provider, config: intelligent_update_config } = config_result
539-
const endpoint_url = provider.base_url
538+
const { model_provider, api_configuration: intelligent_update_api_configuration } = api_configuration_result
539+
const endpoint_url = model_provider.base_url
540540

541541
const intelligent_update_states =
542542
await handle_active_editor_intelligent_update({
543543
endpoint_url,
544-
api_key: provider.api_key,
545-
config: intelligent_update_config,
544+
api_key: model_provider.api_key,
545+
api_configuration: intelligent_update_api_configuration,
546546
chat_response: fake_chat_response,
547547
context: params.context,
548548
is_single_root_folder_workspace,
Lines changed: 62 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -1,131 +1,131 @@
11
import * as vscode from 'vscode'
22
import {
33
ModelProvidersManager,
4-
get_tool_config_id,
5-
ToolConfig
4+
get_api_configuration_id,
5+
ApiConfiguration
66
} from '../../../services/model-providers-manager'
77
import { Logger } from '@shared/utils/logger'
88
import { RECENTLY_USED_CODE_AT_CURSOR_CONFIG_IDS_STATE_KEY } from '@/constants/state-keys'
99
import { PanelProvider } from '@/views/panel/backend/panel-provider'
1010
import { dictionary } from '@shared/constants/dictionary'
1111
import { t } from '@/i18n'
1212

13-
export const get_code_at_cursor_config = async (params: {
13+
export const get_code_at_cursor_api_configuration = async (params: {
1414
api_providers_manager: ModelProvidersManager
1515
show_quick_pick?: boolean
1616
context: vscode.ExtensionContext
17-
config_id?: string
17+
api_configuration_id?: string
1818
panel_provider?: PanelProvider
19-
}): Promise<{ provider: any; config: any } | undefined> => {
20-
const code_at_cursor_configs =
21-
await params.api_providers_manager.get_tool_configs()
19+
}): Promise<{ model_provider: any; api_configuration: any } | undefined> => {
20+
const code_at_cursor_api_configurations =
21+
await params.api_providers_manager.get_api_configurations()
2222

23-
if (code_at_cursor_configs.length == 0) {
23+
if (code_at_cursor_api_configurations.length == 0) {
2424
vscode.commands.executeCommand('codeWebChat.settings')
2525
vscode.window.showInformationMessage(
2626
dictionary.information_message.NO_CODE_AT_CURSOR_CONFIGURATIONS_FOUND
2727
)
2828
return
2929
}
3030

31-
let selected_config: ToolConfig | null = null
31+
let selected_api_configuration: ApiConfiguration | null = null
3232

33-
if (params.config_id !== undefined) {
34-
selected_config =
35-
code_at_cursor_configs.find(
36-
(c) => get_tool_config_id(c) === params.config_id
33+
if (params.api_configuration_id !== undefined) {
34+
selected_api_configuration =
35+
code_at_cursor_api_configurations.find(
36+
(c) => get_api_configuration_id(c) === params.api_configuration_id
3737
) || null
3838
} else if (!params.show_quick_pick) {
39-
const default_config =
40-
await params.api_providers_manager.get_default_code_completions_config()
41-
if (default_config) {
42-
selected_config = default_config
39+
const default_api_configuration =
40+
await params.api_providers_manager.get_default_code_completions_api_configuration()
41+
if (default_api_configuration) {
42+
selected_api_configuration = default_api_configuration
4343
} else {
4444
const recents = params.context.workspaceState.get<string[]>(
4545
RECENTLY_USED_CODE_AT_CURSOR_CONFIG_IDS_STATE_KEY
4646
)
4747
const last_selected_id = recents?.[0]
4848
if (last_selected_id) {
49-
selected_config =
50-
code_at_cursor_configs.find(
51-
(c) => get_tool_config_id(c) == last_selected_id
49+
selected_api_configuration =
50+
code_at_cursor_api_configurations.find(
51+
(c) => get_api_configuration_id(c) == last_selected_id
5252
) || null
5353
}
54-
if (!selected_config && code_at_cursor_configs.length > 0) {
55-
selected_config = code_at_cursor_configs[0]
54+
if (!selected_api_configuration && code_at_cursor_api_configurations.length > 0) {
55+
selected_api_configuration = code_at_cursor_api_configurations[0]
5656
}
5757
}
5858
}
5959

60-
if (!selected_config || params.show_quick_pick) {
60+
if (!selected_api_configuration || params.show_quick_pick) {
6161
const create_items = () => {
6262
const recent_ids =
6363
params.context.workspaceState.get<string[]>(
6464
RECENTLY_USED_CODE_AT_CURSOR_CONFIG_IDS_STATE_KEY
6565
) || []
6666

67-
const matched_recent_configs: ToolConfig[] = []
68-
const remaining_configs: ToolConfig[] = []
67+
const matched_recent_api_configurations: ApiConfiguration[] = []
68+
const remaining_api_configurations: ApiConfiguration[] = []
6969

70-
code_at_cursor_configs.forEach((config) => {
71-
const id = get_tool_config_id(config)
70+
code_at_cursor_api_configurations.forEach((api_configuration) => {
71+
const id = get_api_configuration_id(api_configuration)
7272
if (recent_ids.includes(id)) {
73-
matched_recent_configs.push(config)
73+
matched_recent_api_configurations.push(api_configuration)
7474
} else {
75-
remaining_configs.push(config)
75+
remaining_api_configurations.push(api_configuration)
7676
}
7777
})
7878

79-
matched_recent_configs.sort((a, b) => {
80-
const id_a = get_tool_config_id(a)
81-
const id_b = get_tool_config_id(b)
79+
matched_recent_api_configurations.sort((a, b) => {
80+
const id_a = get_api_configuration_id(a)
81+
const id_b = get_api_configuration_id(b)
8282
return recent_ids.indexOf(id_a) - recent_ids.indexOf(id_b)
8383
})
8484

85-
const recent_configs = matched_recent_configs
86-
const other_configs = remaining_configs
85+
const recent_api_configurations = matched_recent_api_configurations
86+
const other_api_configurations = remaining_api_configurations
8787

88-
const map_config_to_item = (config: ToolConfig) => {
89-
const description_parts = [config.provider_name]
90-
if (config.temperature != null) {
91-
description_parts.push(`${config.temperature}`)
88+
const map_api_configuration_to_item = (api_configuration: ApiConfiguration) => {
89+
const description_parts = [api_configuration.model_provider_name]
90+
if (api_configuration.temperature != null) {
91+
description_parts.push(`${api_configuration.temperature}`)
9292
}
93-
if (config.reasoning_effort) {
94-
description_parts.push(`${config.reasoning_effort}`)
93+
if (api_configuration.reasoning_effort) {
94+
description_parts.push(`${api_configuration.reasoning_effort}`)
9595
}
9696

9797
const buttons: vscode.QuickInputButton[] = []
9898

9999
return {
100-
label: config.model,
100+
label: api_configuration.model,
101101
description: description_parts.join(' · '),
102102
buttons,
103-
config,
104-
id: get_tool_config_id(config)
103+
api_configuration,
104+
id: get_api_configuration_id(api_configuration)
105105
}
106106
}
107107

108108
const items: (vscode.QuickPickItem & {
109-
config?: ToolConfig
109+
api_configuration?: ApiConfiguration
110110
id?: string
111111
})[] = []
112112

113-
if (recent_configs.length > 0) {
113+
if (recent_api_configurations.length > 0) {
114114
items.push({
115115
label: t('common.separator.recently-used'),
116116
kind: vscode.QuickPickItemKind.Separator
117117
})
118-
items.push(...recent_configs.map(map_config_to_item))
118+
items.push(...recent_api_configurations.map(map_api_configuration_to_item))
119119
}
120120

121-
if (other_configs.length > 0) {
122-
if (recent_configs.length > 0) {
121+
if (other_api_configurations.length > 0) {
122+
if (recent_api_configurations.length > 0) {
123123
items.push({
124124
label: t('common.config.other'),
125125
kind: vscode.QuickPickItemKind.Separator
126126
})
127127
}
128-
items.push(...other_configs.map(map_config_to_item))
128+
items.push(...other_api_configurations.map(map_api_configuration_to_item))
129129
}
130130

131131
return items
@@ -154,7 +154,7 @@ export const get_code_at_cursor_config = async (params: {
154154
}
155155
}
156156

157-
return new Promise<{ provider: any; config: any } | undefined>(
157+
return new Promise<{ model_provider: any; api_configuration: any } | undefined>(
158158
(resolve) => {
159159
quick_pick.onDidTriggerButton((button) => {
160160
if (button.tooltip == t('common.close')) {
@@ -167,7 +167,7 @@ export const get_code_at_cursor_config = async (params: {
167167
const selected = quick_pick.selectedItems[0] as any
168168
quick_pick.hide()
169169

170-
if (!selected || !selected.config) {
170+
if (!selected || !selected.api_configuration) {
171171
resolve(undefined)
172172
return
173173
}
@@ -190,10 +190,10 @@ export const get_code_at_cursor_config = async (params: {
190190
})
191191
}
192192

193-
const provider = await params.api_providers_manager.get_provider(
194-
selected.config.provider_name
193+
const model_provider = await params.api_providers_manager.get_model_provider(
194+
selected.api_configuration.model_provider_name
195195
)
196-
if (!provider) {
196+
if (!model_provider) {
197197
vscode.window.showErrorMessage(
198198
dictionary.error_message.API_PROVIDER_NOT_FOUND
199199
)
@@ -202,8 +202,8 @@ export const get_code_at_cursor_config = async (params: {
202202
}
203203

204204
resolve({
205-
provider,
206-
config: selected.config
205+
model_provider,
206+
api_configuration: selected.api_configuration
207207
})
208208
})
209209

@@ -217,23 +217,23 @@ export const get_code_at_cursor_config = async (params: {
217217
)
218218
}
219219

220-
const provider = await params.api_providers_manager.get_provider(
221-
selected_config.provider_name
220+
const model_provider = await params.api_providers_manager.get_model_provider(
221+
selected_api_configuration.model_provider_name
222222
)
223223

224-
if (!provider) {
224+
if (!model_provider) {
225225
vscode.window.showErrorMessage(
226226
dictionary.error_message.API_PROVIDER_NOT_FOUND
227227
)
228228
Logger.warn({
229-
function_name: 'get_code_at_cursor_config',
229+
function_name: 'get_code_at_cursor_api_configuration',
230230
message: 'API provider not found for Code Completions tool.'
231231
})
232232
return
233233
}
234234

235235
return {
236-
provider,
237-
config: selected_config
236+
model_provider,
237+
api_configuration: selected_api_configuration
238238
}
239239
}

0 commit comments

Comments
 (0)