Fix boolean comparison and conditional serialization for model provider extended cache

- should only set 'extendedCache' when true, otherwise omit from provider's object in settings json
- don't require 'extended cache' to be set on provider's object

Author: robertpiosik

apps/editor/src/services/model-providers-manager.ts

@@ -73,19 +73,24 @@ export class ModelProvidersManager {
 
   public async save_model_providers(model_providers: ModelProvider[]) {
     try {
-      // Save full provider info to secret storage
       await this._extension_context.secrets.store(
         SECRET_STORAGE_MODEL_PROVIDERS_KEY,
         JSON.stringify(model_providers)
       )
 
-      // Save provider config to settings
       const model_provider_configs = model_providers.map((p) => {
-        return {
+        const config: {
+          name: string
+          baseUrl: string
+          extendedCache?: boolean
+        } = {
           name: p.name,
-          baseUrl: p.base_url,
-          extendedCache: p.extended_cache
+          baseUrl: p.base_url
+        }
+        if (p.extended_cache) {
+          config.extendedCache = true
         }
+        return config
       })
       const config = vscode.workspace.getConfiguration('codeWebChat')
       await config.update(

apps/editor/src/views/settings/backend/message-handlers/handle-update-model-provider.ts

@@ -23,7 +23,7 @@ export const handle_update_model_provider = async (
       a.base_url !== b.base_url ||
       (b.api_key !== undefined && b.api_key !== '') ||
       b.is_api_key_cleared ||
-      a.extended_cache !== b.extended_cache ||
+      !!a.extended_cache !== !!b.extended_cache ||
       false
   } else if (message.is_new) {
     has_changes = true