Refactor settings management to handle editContextSystemInstructions, commitMessageInstructions, geminiUserId, and clearChecksInWorkspaceBehavior via dedicated backend message handlers

Author: robertpiosik

packages/ui/src/components/editor/settings/Section/Section.module.scss

@@ -22,6 +22,8 @@
     var(--padding-60px) + var(--padding-4px)
   ); // to align with the sidebar title
   padding-bottom: var(--padding-10px);
+  padding-left: var(--padding-12px);
+  padding-right: var(--padding-12px);
   background-color: var(--vscode-editor-background);
   transition: box-shadow var(--transition-duration-250)
     var(--transition-timing-function);

packages/vscode/package.json

@@ -570,6 +570,12 @@
             }
           }
         },
+        "codeWebChat.editContextSystemInstructions": {
+          "type": "string",
+          "scope": "resource",
+          "description": "System instructions for the Edit Context API tool.",
+          "default": "You're a helpful coding assistant."
+        },
         "codeWebChat.chatPresetsForAskAboutContext": {
           "type": "array",
           "default": [

packages/vscode/src/commands/apply-chat-response-command/utils/clipboard-parser/clipboard-parser.ts

@@ -67,7 +67,7 @@ export const extract_workspace_and_path = (params: {
 }
 
 export const has_real_code = (content: string): boolean => {
-  if (content.trim() === '') {
+  if (content.trim() == '') {
     return true
   }
   const lines = content.split('\n')
@@ -104,21 +104,19 @@ export const parse_response = (params: {
   const processed_response = params.response.replace(/``````/g, '```\n```')
 
   const hunk_header_regex = /^(@@\s+-\d+(?:,\d+)?\s+\+\d+(?:,\d+)?\s+@@)/m
+  const has_diff_lines_regex = /^[+-] /m
 
   if (
-    processed_response.includes('```diff') ||
-    processed_response.includes('```patch') ||
-    processed_response.startsWith('--- ') ||
-    processed_response.startsWith('diff --git') ||
-    hunk_header_regex.test(processed_response)
+    hunk_header_regex.test(processed_response) &&
+    has_diff_lines_regex.test(processed_response)
   ) {
     const patches_or_text = extract_diffs({
       clipboard_text: processed_response,
       is_single_root: is_single_root_folder_workspace
     })
     if (patches_or_text.length) {
       return patches_or_text.map((item) => {
-        if ('type' in item && item.type === 'text') {
+        if ('type' in item && item.type == 'text') {
           return item
         }
         return { type: 'diff', ...item }

packages/vscode/src/views/panel/backend/message-handlers/handle-edit-context.ts

@@ -356,10 +356,14 @@ const perform_context_editing = async (params: {
       content = `${loop_pre_context_instructions}\n${files}\n${loop_post_context_instructions}`
     }
 
+    const system_instructions = vscode.workspace
+      .getConfiguration('codeWebChat')
+      .get<string>('editContextSystemInstructions')
+
     const messages = [
       {
         role: 'system',
-        content: "You're a helpful coding assistant."
+        content: system_instructions
       },
       {
         role: 'user',

packages/vscode/src/views/settings/backend/message-handlers/handle-get-clear-checks-in-workspace-behavior.ts

@@ -0,0 +1,16 @@
+import * as vscode from 'vscode'
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+
+export const handle_get_clear_checks_in_workspace_behavior = async (
+  provider: SettingsProvider
+): Promise<void> => {
+  const config = vscode.workspace.getConfiguration('codeWebChat')
+  const value = config.get<'ignore-open-editors' | 'uncheck-all'>(
+    'clearChecksInWorkspaceBehavior',
+    'ignore-open-editors'
+  )
+  provider.postMessage({
+    command: 'CLEAR_CHECKS_IN_WORKSPACE_BEHAVIOR',
+    value
+  })
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-get-commit-message-instructions.ts

@@ -0,0 +1,13 @@
+import * as vscode from 'vscode'
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+
+export const handle_get_commit_message_instructions = async (
+  provider: SettingsProvider
+): Promise<void> => {
+  const config = vscode.workspace.getConfiguration('codeWebChat')
+  const instructions = config.get<string>('commitMessageInstructions') || ''
+  provider.postMessage({
+    command: 'COMMIT_MESSAGE_INSTRUCTIONS',
+    instructions
+  })
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-get-edit-context-system-instructions.ts

@@ -0,0 +1,13 @@
+import * as vscode from 'vscode'
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+
+export const handle_get_edit_context_system_instructions = async (
+  provider: SettingsProvider
+): Promise<void> => {
+  const config = vscode.workspace.getConfiguration('codeWebChat')
+  const instructions = config.get<string>('editContextSystemInstructions') || ''
+  provider.postMessage({
+    command: 'EDIT_CONTEXT_SYSTEM_INSTRUCTIONS',
+    instructions
+  })
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-get-gemini-user-id.ts

@@ -0,0 +1,13 @@
+import * as vscode from 'vscode'
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+
+export const handle_get_gemini_user_id = async (
+  provider: SettingsProvider
+): Promise<void> => {
+  const config = vscode.workspace.getConfiguration('codeWebChat')
+  const geminiUserId = config.get<number | null>('geminiUserId') ?? null
+  provider.postMessage({
+    command: 'GEMINI_USER_ID',
+    geminiUserId
+  })
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-update-clear-checks-in-workspace-behavior.ts

@@ -0,0 +1,16 @@
+import * as vscode from 'vscode'
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import { UpdateClearChecksInWorkspaceBehaviorMessage } from '@/views/settings/types/messages'
+
+export const handle_update_clear_checks_in_workspace_behavior = async (
+  provider: SettingsProvider,
+  message: UpdateClearChecksInWorkspaceBehaviorMessage
+): Promise<void> => {
+  await vscode.workspace
+    .getConfiguration('codeWebChat')
+    .update(
+      'clearChecksInWorkspaceBehavior',
+      message.value,
+      vscode.ConfigurationTarget.Global
+    )
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-update-commit-message-instructions.ts

@@ -0,0 +1,16 @@
+import * as vscode from 'vscode'
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import { UpdateCommitMessageInstructionsMessage } from '@/views/settings/types/messages'
+
+export const handle_update_commit_message_instructions = async (
+  provider: SettingsProvider,
+  message: UpdateCommitMessageInstructionsMessage
+): Promise<void> => {
+  await vscode.workspace
+    .getConfiguration('codeWebChat')
+    .update(
+      'commitMessageInstructions',
+      message.instructions,
+      vscode.ConfigurationTarget.Global
+    )
+}