Skip to content

Commit 340ea2b

Browse files
committed
Replace SetupProgress object with a boolean is_setup_complete flag
1 parent c1599bb commit 340ea2b

6 files changed

Lines changed: 19 additions & 29 deletions

File tree

‎apps/editor/src/views/panel/frontend/Home/Home.tsx‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@ import { Timeline } from '@ui/components/editor/panel/Timeline'
55
import { ModeButton } from '@ui/components/editor/panel/ModeButton'
66
import cn from 'classnames'
77
import { post_message } from '../utils/post_message'
8-
import {
9-
Checkpoint,
10-
FrontendMessage,
11-
SetupProgress
12-
} from '@/views/panel/types/messages'
8+
import { Checkpoint, FrontendMessage } from '@/views/panel/types/messages'
139
import { Responses as UiResponses } from '@ui/components/editor/panel/Responses'
1410
import { ResponseHistoryItem } from '@shared/types/response-history-item'
1511
import { Separator } from '@ui/components/editor/panel/Separator'
@@ -47,7 +43,7 @@ type Props = {
4743
on_tasks_change: (root: string, tasks: Task[]) => void
4844
on_task_delete: (root: string, timestamp: number) => void
4945
on_task_forward: (text: string) => void
50-
setup_progress?: SetupProgress
46+
is_setup_complete: boolean
5147
}
5248

5349
export const Home: React.FC<Props> = (props) => {
@@ -98,10 +94,6 @@ export const Home: React.FC<Props> = (props) => {
9894
} as FrontendMessage)
9995
}
10096

101-
const has_incomplete_setup = props.setup_progress
102-
? Object.values(props.setup_progress).some((v) => !v)
103-
: false
104-
10597
return (
10698
<>
10799
<div className={styles.header}>
@@ -114,7 +106,7 @@ export const Home: React.FC<Props> = (props) => {
114106
<SettingsButton
115107
on_click={handle_settings_click}
116108
label={t('panel.header.settings')}
117-
show_warning_icon={has_incomplete_setup}
109+
show_warning_icon={!props.is_setup_complete}
118110
/>
119111
</div>
120112

‎apps/editor/src/views/panel/frontend/Main/Main.tsx‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ import {
99
ApiToolConfigurationsMessage,
1010
PresetsMessage,
1111
FrontendMessage,
12-
SelectionState,
13-
SetupProgress
12+
SelectionState
1413
} from '@/views/panel/types/messages'
1514
import { ApiToolConfiguration } from '@/views/panel/types/messages'
1615
import { post_message } from '../utils/post_message'
@@ -73,7 +72,7 @@ type Props = {
7372
is_recording: boolean
7473
on_recording_started: () => void
7574
on_recording_finished: () => void
76-
setup_progress?: SetupProgress
75+
is_setup_complete: boolean
7776
}
7877

7978
export const Main: React.FC<Props> = (props) => {
@@ -857,7 +856,7 @@ export const Main: React.FC<Props> = (props) => {
857856
is_recording={props.is_recording}
858857
on_recording_started={props.on_recording_started}
859858
on_recording_finished={props.on_recording_finished}
860-
setup_progress={props.setup_progress}
859+
is_setup_complete={props.is_setup_complete}
861860
/>
862861
)
863862
}

‎apps/editor/src/views/panel/frontend/Main/MainView/MainView.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { use_last_choice_button_title } from './hooks/use-last-choice-button-tit
1616
import { ContextUtilisation as UiContextUtilisation } from '@ui/components/editor/panel/ContextUtilisation'
1717
import { Header } from './components/Header'
1818
import { use_invocation_counts } from './hooks/use-invocation-counts'
19-
import { SelectionState, SetupProgress } from '@/views/panel/types/messages'
19+
import { SelectionState } from '@/views/panel/types/messages'
2020

2121
type Props = {
2222
scroll_reset_key: number
@@ -113,7 +113,7 @@ type Props = {
113113
is_recording: boolean
114114
on_recording_started: () => void
115115
on_recording_finished: () => void
116-
setup_progress?: SetupProgress
116+
is_setup_complete: boolean
117117
}
118118

119119
export const MainView: React.FC<Props> = (props) => {
@@ -194,7 +194,7 @@ export const MainView: React.FC<Props> = (props) => {
194194
on_api_prompt_type_change={props.on_api_prompt_type_change}
195195
on_quick_action_click={props.on_quick_action_click}
196196
are_keyboard_shortcuts_disabled={props.are_keyboard_shortcuts_disabled}
197-
setup_progress={props.setup_progress}
197+
is_setup_complete={props.is_setup_complete}
198198
/>
199199
<Scrollable scroll_to_top_key={props.scroll_reset_key}>
200200
<UiSeparator height={4} />

‎apps/editor/src/views/panel/frontend/Main/MainView/components/Header/Header.tsx‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
import { SettingsButton as UiSettingsButton } from '@ui/components/editor/panel/SettingsButton'
1313
import { use_keyboard_shortcuts } from './hooks/use-keyboard-shortcuts'
1414
import { use_translation } from '@/views/i18n/use-translation'
15-
import { SetupProgress } from '@/views/panel/types/messages'
1615

1716
type Props = {
1817
mode: Mode
@@ -24,7 +23,7 @@ type Props = {
2423
on_api_prompt_type_change: (prompt_type: ApiPromptType) => void
2524
on_quick_action_click: (command: string) => void
2625
are_keyboard_shortcuts_disabled: boolean
27-
setup_progress?: SetupProgress
26+
is_setup_complete: boolean
2827
}
2928

3029
export const Header: React.FC<Props> = (props) => {
@@ -52,10 +51,6 @@ export const Header: React.FC<Props> = (props) => {
5251
is_disabled: props.are_keyboard_shortcuts_disabled
5352
})
5453

55-
const has_incomplete_setup = props.setup_progress
56-
? Object.values(props.setup_progress).some((v) => !v)
57-
: false
58-
5954
return (
6055
<div className={styles.header} ref={header_ref}>
6156
<div className={styles.header__left} ref={header_left_ref}>
@@ -127,7 +122,7 @@ export const Header: React.FC<Props> = (props) => {
127122
<UiSettingsButton
128123
on_click={() => props.on_quick_action_click('codeWebChat.settings')}
129124
title="Settings"
130-
show_warning_icon={has_incomplete_setup}
125+
show_warning_icon={!props.is_setup_complete}
131126
/>
132127
</div>
133128
</div>

‎apps/editor/src/views/panel/frontend/Panel.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export const Panel = () => {
108108
handle_paste_url,
109109
is_recording,
110110
handle_set_recording_state,
111-
setup_progress
111+
is_setup_complete
112112
} = use_panel(vscode)
113113

114114
const [checkpoint_to_edit, set_checkpoint_to_edit] = useState<
@@ -320,7 +320,7 @@ export const Panel = () => {
320320
is_recording={is_recording}
321321
on_recording_started={() => handle_set_recording_state(true)}
322322
on_recording_finished={() => handle_set_recording_state(false)}
323-
setup_progress={setup_progress}
323+
is_setup_complete={is_setup_complete}
324324
/>
325325
</div>
326326
<div
@@ -398,7 +398,7 @@ export const Panel = () => {
398398
on_tasks_change={handle_tasks_change}
399399
on_task_delete={handle_task_delete}
400400
on_task_forward={handle_task_forward}
401-
setup_progress={setup_progress}
401+
is_setup_complete={is_setup_complete}
402402
/>
403403
</div>
404404
</Layout>

‎apps/editor/src/views/panel/frontend/hooks/use-panel.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,10 @@ export const use_panel = (vscode: any) => {
553553
})
554554
}
555555

556+
const is_setup_complete = setup_progress
557+
? Object.values(setup_progress).every((v) => v)
558+
: true
559+
556560
return {
557561
active_view,
558562
set_active_view,
@@ -635,6 +639,6 @@ export const use_panel = (vscode: any) => {
635639
handle_paste_url,
636640
is_recording,
637641
handle_set_recording_state,
638-
setup_progress
642+
is_setup_complete
639643
}
640644
}

0 commit comments

Comments
 (0)