Refactor API configuration management by separating creation and update flows and reorganizing interaction modules

- omit these when false [Pasted text] 

Author: robertpiosik

apps/editor/src/services/model-providers-manager.ts

@@ -16,7 +16,9 @@ export type ApiConfiguration = {
   is_pinned?: boolean
 }
 
-export const get_api_configuration_id = (api_configuration: ApiConfiguration): string => {
+export const get_api_configuration_id = (
+  api_configuration: ApiConfiguration
+): string => {
   return [
     api_configuration.model_provider_name,
     api_configuration.model,
@@ -100,17 +102,23 @@ export class ModelProvidersManager {
     return this._model_providers
   }
 
-  public async get_model_provider(name: string): Promise<ModelProvider | undefined> {
+  public async get_model_provider(
+    name: string
+  ): Promise<ModelProvider | undefined> {
     await this._load_promise
-    return this._model_providers.find((model_provider) => model_provider.name == name)
+    return this._model_providers.find(
+      (model_provider) => model_provider.name == name
+    )
   }
 
   private _validate_api_configuration(
     api_configuration: ApiConfiguration | undefined
   ): ApiConfiguration | undefined {
     if (!api_configuration) return undefined
 
-    const model_provider = this._model_providers.find((p) => p.name == api_configuration.model_provider_name)
+    const model_provider = this._model_providers.find(
+      (p) => p.name == api_configuration.model_provider_name
+    )
 
     if (!model_provider) {
       return undefined
@@ -124,16 +132,18 @@ export class ModelProvidersManager {
     const config = vscode.workspace.getConfiguration('codeWebChat')
     const settings_configs = config.get<any[]>('configurations', [])
 
-    const api_configurations: ApiConfiguration[] = settings_configs.map((sc) => {
-      return {
-        model_provider_name: sc.providerName,
-        model: sc.model,
-        temperature: sc.temperature,
-        reasoning_effort: sc.reasoningEffort,
-        system_instructions_override: sc.systemInstructionsOverride,
-        is_pinned: sc.isPinned
+    const api_configurations: ApiConfiguration[] = settings_configs.map(
+      (sc) => {
+        return {
+          model_provider_name: sc.providerName,
+          model: sc.model,
+          temperature: sc.temperature,
+          reasoning_effort: sc.reasoningEffort,
+          system_instructions_override: sc.systemInstructionsOverride,
+          is_pinned: sc.isPinned
+        }
       }
-    })
+    )
 
     return api_configurations.filter(
       (c) => this._validate_api_configuration(c) !== undefined
@@ -151,16 +161,19 @@ export class ModelProvidersManager {
       const new_config: any = {
         providerName: c.model_provider_name,
         model: c.model,
-        temperature: c.temperature,
-        isDefaultForCodeAtCursor: old_config?.isDefaultForCodeAtCursor || false,
-        isDefaultForFindRelevantFiles:
-          old_config?.isDefaultForFindRelevantFiles || false,
-        isDefaultForIntelligentUpdate:
-          old_config?.isDefaultForIntelligentUpdate || false,
-        isDefaultForCommitMessages:
-          old_config?.isDefaultForCommitMessages || false,
-        isDefaultForVoiceInput: old_config?.isDefaultForVoiceInput || false
+        temperature: c.temperature
       }
+
+      if (old_config?.isDefaultForCodeAtCursor)
+        new_config.isDefaultForCodeAtCursor = true
+      if (old_config?.isDefaultForFindRelevantFiles)
+        new_config.isDefaultForFindRelevantFiles = true
+      if (old_config?.isDefaultForIntelligentUpdate)
+        new_config.isDefaultForIntelligentUpdate = true
+      if (old_config?.isDefaultForCommitMessages)
+        new_config.isDefaultForCommitMessages = true
+      if (old_config?.isDefaultForVoiceInput)
+        new_config.isDefaultForVoiceInput = true
       if (c.reasoning_effort !== undefined)
         new_config.reasoningEffort = c.reasoning_effort
       if (c.system_instructions_override !== undefined)
@@ -210,7 +223,8 @@ export class ModelProvidersManager {
           default_config_from_settings.systemInstructionsOverride,
         is_pinned: default_config_from_settings.isPinned
       }
-      const validated_config = this._validate_api_configuration(api_configuration)
+      const validated_config =
+        this._validate_api_configuration(api_configuration)
       if (validated_config) return validated_config
     }
     return undefined
@@ -227,7 +241,14 @@ export class ModelProvidersManager {
       const is_default =
         config_to_set !== null &&
         this._are_api_configurations_effectively_equal(c, config_to_set)
-      return { ...c, [default_key]: is_default }
+
+      const new_c = { ...c }
+      if (is_default) {
+        new_c[default_key] = true
+      } else {
+        delete new_c[default_key]
+      }
+      return new_c
     })
 
     await config.update(
@@ -246,7 +267,9 @@ export class ModelProvidersManager {
     )
   }
 
-  public async set_default_code_completions_api_configuration(api_configuration: ApiConfiguration | null) {
+  public async set_default_code_completions_api_configuration(
+    api_configuration: ApiConfiguration | null
+  ) {
     await this._set_default_api_configuration_in_settings(
       'isDefaultForCodeAtCursor',
       api_configuration
@@ -262,7 +285,9 @@ export class ModelProvidersManager {
     )
   }
 
-  public async set_default_commit_messages_api_configuration(api_configuration: ApiConfiguration | null) {
+  public async set_default_commit_messages_api_configuration(
+    api_configuration: ApiConfiguration | null
+  ) {
     await this._set_default_api_configuration_in_settings(
       'isDefaultForCommitMessages',
       api_configuration
@@ -309,10 +334,14 @@ export class ModelProvidersManager {
     ApiConfiguration | undefined
   > {
     await this._load_promise
-    return this._get_default_api_configuration_from_settings('isDefaultForVoiceInput')
+    return this._get_default_api_configuration_from_settings(
+      'isDefaultForVoiceInput'
+    )
   }
 
-  public async set_default_voice_input_api_configuration(api_configuration: ApiConfiguration | null) {
+  public async set_default_voice_input_api_configuration(
+    api_configuration: ApiConfiguration | null
+  ) {
     await this._set_default_api_configuration_in_settings(
       'isDefaultForVoiceInput',
       api_configuration

…onfiguration/upsert-api-configuration.ts …onfiguration/create-api-configuration.tsapps/editor/src/views/actions/upsert-api-configuration/upsert-api-configuration.ts renamed to apps/editor/src/views/actions/create-api-configuration/create-api-configuration.ts apps/editor/src/views/actions/upsert-api-configuration/upsert-api-configuration.ts renamed to apps/editor/src/views/actions/create-api-configuration/create-api-configuration.ts

@@ -13,7 +13,7 @@ import {
 } from './interactions'
 import { ToolType } from '@/views/settings/types/tools'
 
-export const upsert_api_configuration = async (params: {
+export const create_api_configuration = async (params: {
   context: vscode.ExtensionContext
   tool_type: ToolType
   create_on_top?: boolean

…-api-configuration/interactions/index.ts …-api-configuration/interactions/index.tsapps/editor/src/views/actions/upsert-api-configuration/interactions/index.ts renamed to apps/editor/src/views/actions/create-api-configuration/interactions/index.ts apps/editor/src/views/actions/upsert-api-configuration/interactions/index.ts renamed to apps/editor/src/views/actions/create-api-configuration/interactions/index.ts

@@ -1,6 +1,3 @@
-export * from './edit-model-for-api-config'
-export * from './edit-provider-for-api-config'
-export * from './edit-reasoning-effort-for-api-config'
 export * from './initial-select-model'
 export * from './initial-select-provider'
 export * from './verify-model'

…ion/interactions/initial-select-model.ts …ion/interactions/initial-select-model.tsapps/editor/src/views/actions/upsert-api-configuration/interactions/initial-select-model.ts renamed to apps/editor/src/views/actions/create-api-configuration/interactions/initial-select-model.ts apps/editor/src/views/actions/upsert-api-configuration/interactions/initial-select-model.ts renamed to apps/editor/src/views/actions/create-api-configuration/interactions/initial-select-model.ts

@@ -20,7 +20,9 @@ export const initial_select_model = async (
     base_url = model_provider.base_url
 
     if (!base_url)
-      throw new Error(`Base URL not found for model provider ${model_provider.name}`)
+      throw new Error(
+        `Base URL not found for model provider ${model_provider.name}`
+      )
 
     const models = await model_fetcher.get_models({
       base_url,
@@ -105,7 +107,9 @@ export const initial_select_model = async (
       error.message == MODELS_ROUTE_NOT_FOUND_ERROR
     ) {
       vscode.window.showInformationMessage(
-        dictionary.information_message.MODELS_ROUTE_NOT_FOUND(model_provider.name),
+        dictionary.information_message.MODELS_ROUTE_NOT_FOUND(
+          model_provider.name
+        ),
         { modal: true }
       )
     } else {

…/interactions/initial-select-provider.ts …/interactions/initial-select-provider.tsapps/editor/src/views/actions/upsert-api-configuration/interactions/initial-select-provider.ts renamed to apps/editor/src/views/actions/create-api-configuration/interactions/initial-select-provider.ts apps/editor/src/views/actions/upsert-api-configuration/interactions/initial-select-provider.ts renamed to apps/editor/src/views/actions/create-api-configuration/interactions/initial-select-provider.ts

@@ -10,20 +10,23 @@ import {
 import { Logger } from '@shared/utils/logger'
 import { dictionary } from '@shared/constants/dictionary'
 import { ToolType } from '../../../settings/types/tools'
-import { verify_model } from './verify-model'
+import { verify_model } from '../../create-api-configuration/interactions/verify-model'
 
 export const edit_model_for_api_configuration = async (params: {
   api_configuration: ApiConfiguration
   providers_manager: ModelProvidersManager
   model_fetcher: ModelFetcher
   tool_type?: ToolType
 }) => {
-  const model_provider_from_manager = await params.providers_manager.get_model_provider(
-    params.api_configuration.model_provider_name
-  )
+  const model_provider_from_manager =
+    await params.providers_manager.get_model_provider(
+      params.api_configuration.model_provider_name
+    )
   if (!model_provider_from_manager) {
     vscode.window.showErrorMessage(
-      dictionary.error_message.MODEL_PROVIDER_NOT_FOUND_BY_NAME(params.api_configuration.model_provider_name)
+      dictionary.error_message.MODEL_PROVIDER_NOT_FOUND_BY_NAME(
+        params.api_configuration.model_provider_name
+      )
     )
     return undefined
   }