Skip to content

Commit 3d6db1c

Browse files
committed
Add empty context validation and standard notification for prompt handlers
- place dot after each [Fragment] - instead of [Fragment] use information message - in 'edit' prompt type, prevent autofill when context is empty
1 parent b0970a1 commit 3d6db1c

4 files changed

Lines changed: 48 additions & 23 deletions

File tree

‎apps/editor/src/i18n/translations/views/prompt/handlers/handle-autofill.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,23 @@ export const translations = {
1616
cs: 'Prohlížeč není připojen.',
1717
hu: 'A böngésző nincs csatlakoztatva.',
1818
bg: 'Браузърът не е свързан.'
19+
},
20+
'views.prompt.handlers.handle-autofill.context-cannot-be-empty': {
21+
en: 'Context cannot be empty.',
22+
pl: 'Kontekst nie może być pusty.',
23+
'zh-cn': '上下文不能为空。',
24+
ja: 'コンテキストを空にすることはできません。',
25+
'zh-tw': '上下文不能為空。',
26+
de: 'Kontext darf nicht leer sein.',
27+
es: 'El contexto no puede estar vacío.',
28+
fr: 'Le contexte ne peut pas être vide.',
29+
'pt-br': 'O contexto não pode estar vazio.',
30+
ru: 'Контекст не может быть пустым.',
31+
ko: '컨텍스트는 비워 둘 수 없습니다.',
32+
it: 'Il contesto non può essere vuoto.',
33+
tr: 'Bağlam boş olamaz.',
34+
cs: 'Kontext nemůže být prázdný.',
35+
hu: 'A kontextus nem lehet üres.',
36+
bg: 'Контекстът не може да бъде празен.'
1937
}
2038
} as const

‎apps/editor/src/i18n/translations/views/prompt/handlers/handle-make-api-call.ts‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,22 @@ export const translations = {
1818
bg: 'Инструкциите не могат да бъдат празни'
1919
},
2020
'views.prompt.handlers.handle-make-api-call.context-cannot-be-empty': {
21-
en: 'Context cannot be empty',
22-
pl: 'Kontekst nie może być pusty',
23-
'zh-cn': '上下文不能为空',
24-
ja: 'コンテキストを空にすることはできません',
25-
'zh-tw': '上下文不能為空',
26-
de: 'Kontext darf nicht leer sein',
27-
es: 'El contexto no puede estar vacío',
28-
fr: 'Le contexte ne peut pas être vide',
29-
'pt-br': 'O contexto não pode estar vazio',
30-
ru: 'Контекст не может быть пустым',
31-
ko: '컨텍스트는 비워 둘 수 없습니다',
32-
it: 'Il contesto non può essere vuoto',
33-
tr: 'Bağlam boş olamaz',
34-
cs: 'Kontext nemůže být prázdný',
35-
hu: 'A kontextus nem lehet üres',
36-
bg: 'Контекстът не може да бъде празен'
21+
en: 'Context cannot be empty.',
22+
pl: 'Kontekst nie może być pusty.',
23+
'zh-cn': '上下文不能为空。',
24+
ja: 'コンテキストを空にすることはできません。',
25+
'zh-tw': '上下文不能為空。',
26+
de: 'Kontext darf nicht leer sein.',
27+
es: 'El contexto no puede estar vacío.',
28+
fr: 'Le contexte ne peut pas être vide.',
29+
'pt-br': 'O contexto não pode estar vazio.',
30+
ru: 'Контекст не может быть пустым.',
31+
ko: '컨텍스트는 비워 둘 수 없습니다.',
32+
it: 'Il contesto non può essere vuoto.',
33+
tr: 'Bağlam boş olamaz.',
34+
cs: 'Kontext nemůže být prázdný.',
35+
hu: 'A kontextus nem lehet üres.',
36+
bg: 'Контекстът не може да бъде празен.'
3737
},
3838
'views.prompt.handlers.handle-make-api-call.select-code-at-cursor-api-configuration':
3939
{

‎apps/editor/src/views/prompt/backend/message-handlers/handle-autofill.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,24 @@ export const handle_autofill = async (params: {
5959
const {
6060
other_files,
6161
recent_files,
62+
collected_files,
6263
processed_instructions,
6364
skill_definitions
6465
} = await build_prompt_payload({
6566
prompt_view_provider: params.prompt_view_provider,
6667
remove_images: true
6768
})
6869

70+
if (
71+
params.prompt_view_provider.web_prompt_type == 'edit-files' &&
72+
!collected_files
73+
) {
74+
vscode.window.showInformationMessage(
75+
t('views.prompt.handlers.handle-autofill.context-cannot-be-empty')
76+
)
77+
return
78+
}
79+
6980
let formatted_system_instructions = ''
7081
const user_instructions = processed_instructions
7182
if (params.prompt_view_provider.web_prompt_type == 'edit-files') {

‎apps/editor/src/views/prompt/backend/message-handlers/handle-make-api-call.ts‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -178,13 +178,9 @@ export const handle_make_api_call = async (
178178
})
179179

180180
if (!collected_files) {
181-
prompt_view_provider.send_message({
182-
command: 'SHOW_AUTO_CLOSING_MODAL',
183-
title: t(
184-
'views.prompt.handlers.handle-make-api-call.context-cannot-be-empty'
185-
),
186-
type: 'warning'
187-
})
181+
vscode.window.showInformationMessage(
182+
t('views.prompt.handlers.handle-make-api-call.context-cannot-be-empty')
183+
)
188184
return
189185
}
190186

0 commit comments

Comments
 (0)