Skip to content

Commit 3f42670

Browse files
committed
Remove system instructions override from API configurations
- remove feature: 'system instructions override'
1 parent 1008df4 commit 3f42670

7 files changed

Lines changed: 3 additions & 45 deletions

File tree

‎apps/editor/package.json‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,9 +1059,6 @@
10591059
"reasoningEffort": {
10601060
"type": "string"
10611061
},
1062-
"systemInstructionsOverride": {
1063-
"type": "string"
1064-
},
10651062
"isPinned": {
10661063
"type": "boolean"
10671064
},

‎apps/editor/src/services/model-providers-manager.ts‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export type ApiConfiguration = {
1212
model: string
1313
temperature?: number
1414
reasoning_effort?: string
15-
system_instructions_override?: string
1615
is_pinned?: boolean
1716
}
1817

@@ -139,7 +138,6 @@ export class ModelProvidersManager {
139138
model: sc.model,
140139
temperature: sc.temperature,
141140
reasoning_effort: sc.reasoningEffort,
142-
system_instructions_override: sc.systemInstructionsOverride,
143141
is_pinned: sc.isPinned
144142
}
145143
}
@@ -176,8 +174,6 @@ export class ModelProvidersManager {
176174
new_config.isDefaultForVoiceInput = true
177175
if (c.reasoning_effort !== undefined)
178176
new_config.reasoningEffort = c.reasoning_effort
179-
if (c.system_instructions_override !== undefined)
180-
new_config.systemInstructionsOverride = c.system_instructions_override
181177
if (c.is_pinned !== undefined) new_config.isPinned = c.is_pinned
182178
return new_config
183179
})
@@ -198,9 +194,7 @@ export class ModelProvidersManager {
198194
settings_config.model === api_configuration.model &&
199195
settings_config.temperature === api_configuration.temperature &&
200196
(settings_config.reasoningEffort ?? undefined) ===
201-
(api_configuration.reasoning_effort ?? undefined) &&
202-
(settings_config.systemInstructionsOverride ?? undefined) ===
203-
(api_configuration.system_instructions_override ?? undefined)
197+
(api_configuration.reasoning_effort ?? undefined)
204198
)
205199
}
206200

@@ -219,8 +213,6 @@ export class ModelProvidersManager {
219213
model: default_config_from_settings.model,
220214
temperature: default_config_from_settings.temperature,
221215
reasoning_effort: default_config_from_settings.reasoningEffort,
222-
system_instructions_override:
223-
default_config_from_settings.systemInstructionsOverride,
224216
is_pinned: default_config_from_settings.isPinned
225217
}
226218
const validated_config =

‎apps/editor/src/views/actions/update-api-configuration/update-api-configuration.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ export const update_api_configuration = async (params: {
4444
const has_changes =
4545
params.updating_api_configuration.id !==
4646
get_api_configuration_id(params.updated_api_configuration) ||
47-
params.updating_api_configuration.system_instructions_override !==
48-
params.updated_api_configuration.system_instructions_override ||
4947
params.updating_api_configuration.is_pinned !==
5048
params.updated_api_configuration.is_pinned
5149

@@ -84,8 +82,6 @@ export const update_api_configuration = async (params: {
8482
model: params.updated_api_configuration.model,
8583
temperature: params.updated_api_configuration.temperature,
8684
reasoning_effort: params.updated_api_configuration.reasoning_effort,
87-
system_instructions_override:
88-
params.updated_api_configuration.system_instructions_override,
8985
is_pinned: params.updated_api_configuration.is_pinned
9086
}
9187

‎apps/editor/src/views/components/EditApiConfigurationForm/EditApiConfigurationForm.tsx‎

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import styles from './EditApiConfigurationForm.module.scss'
33
import { ApiConfiguration } from '@/views/panel/types/messages'
44
import { Field as UiField } from '@ui/components/editor/common/Field'
55
import { Slider as UiSlider } from '@ui/components/editor/panel/Slider'
6-
import { Textarea as UiTextarea } from '@ui/components/editor/common/Textarea'
76
import { BackendMessage } from '@/views/panel/types/messages'
87
import { Scrollable as UiScrollable } from '@ui/components/editor/panel/Scrollable'
98
import { Fieldset as UiFieldset } from '@ui/components/editor/panel/Fieldset'
@@ -33,8 +32,6 @@ export const EditApiConfigurationForm: React.FC<Props> = (props) => {
3332
const [reasoning_effort, set_reasoning_effort] = useState(
3433
props.api_configuration.reasoning_effort
3534
)
36-
const [system_instructions_override, set_system_instructions_override] =
37-
useState(props.api_configuration.system_instructions_override)
3835

3936
const [is_sampling_collapsed, set_is_sampling_collapsed] = useState(
4037
props.api_configuration.temperature === undefined
@@ -46,16 +43,9 @@ export const EditApiConfigurationForm: React.FC<Props> = (props) => {
4643
model_provider_name,
4744
model,
4845
temperature,
49-
reasoning_effort,
50-
system_instructions_override
46+
reasoning_effort
5147
})
52-
}, [
53-
model_provider_name,
54-
model,
55-
temperature,
56-
reasoning_effort,
57-
system_instructions_override
58-
])
48+
}, [model_provider_name, model, temperature, reasoning_effort])
5949

6050
useEffect(() => {
6151
const handle_message = (event: MessageEvent) => {
@@ -129,20 +119,6 @@ export const EditApiConfigurationForm: React.FC<Props> = (props) => {
129119
}}
130120
/>
131121
</UiField>
132-
133-
<UiField
134-
label="System Instructions Override"
135-
html_for="instructions"
136-
info="Optional tone and style instructions for the model."
137-
>
138-
<UiTextarea
139-
id="instructions"
140-
value={system_instructions_override || ''}
141-
on_change={set_system_instructions_override}
142-
min_rows={2}
143-
placeholder="Overrides global system instructions"
144-
/>
145-
</UiField>
146122
</UiFieldset>
147123

148124
<UiFieldset

‎apps/editor/src/views/panel/backend/message-handlers/handle-edit-context.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,6 @@ export const handle_edit_context = async (
384384
}
385385

386386
const system_instructions =
387-
edit_context_api_configuration.system_instructions_override ||
388387
vscode.workspace
389388
.getConfiguration('codeWebChat')
390389
.get<string>('editContextSystemInstructions') ||

‎apps/editor/src/views/panel/types/messages.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ export type ApiConfiguration = {
6363
temperature?: number
6464
reasoning_effort?: string
6565
is_pinned?: boolean
66-
system_instructions_override?: string
6766
}
6867

6968
export type CheckpointTrigger =

‎apps/editor/src/views/settings/types/messages.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export type ApiConfiguration = {
1414
temperature?: number
1515
reasoning_effort?: string
1616
is_pinned?: boolean
17-
system_instructions_override?: string
1817
}
1918

2019
export type EditFormatInstructions = {

0 commit comments

Comments
 (0)