Skip to content

Commit 452c49e

Browse files
committed
Replace row click with explicit edit button for configuration editing
1 parent ef3693d commit 452c49e

2 files changed

Lines changed: 14 additions & 20 deletions

File tree

‎packages/ui/src/components/editor/settings/ConfigurationsList/ConfigurationsList.module.scss‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@
4343
margin-right: 0.5em;
4444
}
4545

46-
> span:first-child:hover {
47-
text-decoration: underline;
48-
cursor: pointer;
49-
}
50-
5146
> span:last-child {
5247
margin-left: 0.5em;
5348
opacity: 0.7;

‎packages/ui/src/components/editor/settings/ConfigurationsList/ConfigurationsList.tsx‎

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@ export const ConfigurationsList: React.FC<ConfigurationsList.Props> = (
3333
const has_default = props.configurations.some((c) => c.is_default)
3434

3535
const render_item = (config: ConfigurationsList.Configuration) => (
36-
<div
37-
key={config.id}
38-
className={styles.row}
39-
onClick={() => props.on_edit(config.id)}
40-
>
36+
<div key={config.id} className={styles.row}>
4137
{sortable && (
4238
<div className={cn(styles['drag-handle'], styles['col-drag'])}>
4339
<span className="codicon codicon-gripper" />
@@ -58,16 +54,19 @@ export const ConfigurationsList: React.FC<ConfigurationsList.Props> = (
5854
<span>{config.description}</span>
5955
</div>
6056
<div className={styles['col-actions']}>
61-
{props.on_delete && (
62-
<IconButton
63-
codicon_icon="trash"
64-
title="Delete configuration"
65-
on_click={(e) => {
66-
e.stopPropagation()
67-
props.on_delete(config.id)
68-
}}
69-
/>
70-
)}
57+
<IconButton
58+
codicon_icon="edit"
59+
title="Edit configuration"
60+
on_click={() => props.on_edit(config.id)}
61+
/>
62+
<IconButton
63+
codicon_icon="trash"
64+
title="Delete configuration"
65+
on_click={(e) => {
66+
e.stopPropagation()
67+
props.on_delete(config.id)
68+
}}
69+
/>
7170
</div>
7271
</div>
7372
)

0 commit comments

Comments
 (0)