Refactor file preview logic to explicitly check for type: 'file' instead of relying on the presence of file_path

Author: robertpiosik

packages/shared/src/types/file-in-preview.ts

@@ -1,4 +1,5 @@
 export type FileInPreview = {
+  type: 'file'
   file_path: string
   is_checked: boolean
   workspace_name?: string

packages/ui/src/components/editor/panel/ResponsePreview/ResponsePreview.stories.tsx

@@ -8,16 +8,19 @@ export default {
 
 const base_files = [
   {
+    type: 'file',
     file_path: 'src/components/Button/Button.tsx',
     lines_added: 10,
     lines_removed: 2
   },
   {
+    type: 'file',
     file_path: 'src/components/Input/Input.module.scss',
     lines_added: 5,
     lines_removed: 5
   },
   {
+    type: 'file',
     file_path: 'src/utils/helpers.ts',
     lines_added: 20,
     lines_removed: 0
@@ -26,25 +29,29 @@ const base_files = [
 
 const files_using_fallbacks = [
   {
+    type: 'file',
     file_path: 'src/new-feature.ts',
     is_new: true,
     lines_added: 50,
     lines_removed: 0
   },
   {
+    type: 'file',
     file_path: 'src/old-component.tsx',
     is_deleted: true,
     lines_added: 0,
     lines_removed: 100
   },
   {
+    type: 'file',
     file_path: 'src/complex-logic.js',
     is_fallback: true,
     diff_fallback_method: 'recount',
     lines_added: 15,
     lines_removed: 12
   },
   {
+    type: 'file',
     file_path: 'src/aggressive-fallback.css',
     is_fallback: true,
     diff_fallback_method: 'search_and_replace',
@@ -62,7 +69,7 @@ const log_action =
 const InteractiveResponsePreview = (props: any) => {
   const [items, set_items] = useState(
     props.items.map((f: any) =>
-      'file_path' in f ? { ...f, is_checked: true } : f
+      f.type == 'file' ? { ...f, is_checked: true } : f
     )
   )
 
@@ -77,9 +84,9 @@ const InteractiveResponsePreview = (props: any) => {
   }) => {
     set_items(
       items.map((f: any) =>
-        'file_path' in f &&
-        f.file_path === file_path &&
-        f.workspace_name === workspace_name
+        f.type == 'file' &&
+        f.file_path == file_path &&
+        f.workspace_name == workspace_name
           ? { ...f, is_checked }
           : f
       )

packages/ui/src/components/editor/panel/ResponsePreview/ResponsePreview.tsx

@@ -68,7 +68,7 @@ export const ResponsePreview: FC<Props> = (props) => {
   }
 
   const files_in_preview = props.items.filter(
-    (i) => 'file_path' in i
+    (i) => i.type == 'file'
   ) as FileInPreview[]
   const fallback_count = files_in_preview.filter((f) => f.is_fallback).length
 
@@ -118,7 +118,7 @@ export const ResponsePreview: FC<Props> = (props) => {
         )}
         <div className={styles.list}>
           {props.items.map((item, index) => {
-            if ('file_path' in item) {
+            if (item.type === 'file') {
               const file = item
               const last_slash_index = file.file_path.lastIndexOf('/')
               const file_name = file.file_path.substring(last_slash_index + 1)

packages/vscode/src/commands/apply-chat-response-command/apply-chat-response-command.ts

@@ -154,6 +154,7 @@ export const apply_chat_response_command = (
                 !state.is_new && current_content === '' && state.content !== ''
 
               files_for_history.push({
+                type: 'file',
                 file_path: state.file_path,
                 workspace_name: state.workspace_name,
                 is_new: state.is_new,

packages/vscode/src/commands/apply-chat-response-command/utils/preview/file-preparer.ts

@@ -62,6 +62,7 @@ export const prepare_files_from_original_states = async (params: {
       (!state.is_new && current_content == '' && state.content != '')
 
     const reviewable_file: ReviewableFile = {
+      type: 'file',
       file_path: state.file_path,
       content: current_content,
       workspace_name: state.workspace_name,
@@ -110,6 +111,7 @@ export const prepare_files_from_original_states = async (params: {
       })
 
       const restored_reviewable_file: ReviewableFile = {
+        type: 'file',
         file_path: state.file_path_to_restore,
         content: restored_current_content,
         workspace_name: state.workspace_name,

packages/vscode/src/views/panel/frontend/Panel.tsx

@@ -332,7 +332,7 @@ export const Panel = () => {
                   }}
                   on_accept={() => {
                     const accepted_files = items_to_review.filter(
-                      (f) => 'file_path' in f && f.is_checked
+                      (f) => f.type === 'file' && f.is_checked
                     ) as FileInPreview[]
                     set_response_history([])
                     set_selected_history_item_created_at(undefined)
@@ -343,7 +343,7 @@ export const Panel = () => {
                   }}
                   is_accept_disabled={
                     items_to_review.filter(
-                      (f) => 'file_path' in f && f.is_checked
+                      (f) => f.type === 'file' && f.is_checked
                     ).length == 0
                   }
                 />
@@ -370,7 +370,7 @@ export const Panel = () => {
                 on_toggle_file={(file) => {
                   set_items_to_review((current_items) =>
                     current_items?.map((f) =>
-                      'file_path' in f &&
+                      f.type === 'file' &&
                       f.file_path == file.file_path &&
                       f.workspace_name == file.workspace_name
                         ? { ...f, is_checked: file.is_checked }

packages/vscode/src/views/panel/frontend/hooks/use-panel.ts

@@ -148,15 +148,15 @@ export const use_panel = (vscode: any) => {
           const items = current_items ?? []
           const existing_file_index = items.findIndex(
             (f) =>
-              'file_path' in f &&
+              f.type === 'file' &&
               f.file_path == message.file.file_path &&
               f.workspace_name == message.file.workspace_name
           )
 
           if (existing_file_index != -1) {
             const new_items = [...items]
             const existing_item = items[existing_file_index]
-            if ('file_path' in existing_item) {
+            if (existing_item.type === 'file') {
               new_items[existing_file_index] = {
                 ...message.file,
                 is_checked: existing_item.is_checked