Remove configurable findRelevantFilesInstructions setting in favor of a constant

Author: robertpiosik

apps/editor/package.json

@@ -870,10 +870,6 @@
           "type": "string",
           "scope": "resource"
         },
-        "codeWebChat.findRelevantFilesInstructions": {
-          "type": "string",
-          "scope": "resource"
-        },
         "codeWebChat.fixAllAutomatically": {
           "type": "boolean",
           "scope": "resource",

apps/editor/src/commands/find-relevant-files-command.ts

@@ -431,16 +431,8 @@ export const find_relevant_files_command = (
             }
             xml_files += `</files>`
 
-            const config_settings =
-              vscode.workspace.getConfiguration('codeWebChat')
-            const config_find_relevant_files_instructions =
-              config_settings.get<string>('findRelevantFilesInstructions')
-            const instructions_to_use =
-              config_find_relevant_files_instructions ||
-              find_relevant_files_instructions
-
-            const system_instructions_xml = `${find_relevant_files_format}\n${instructions_to_use}`
-            const part2 = `${system_instructions_xml}\nTask:\n${instructions}`
+            const system_instructions_xml = `${find_relevant_files_format}\n${find_relevant_files_instructions}`
+            const part2 = `${system_instructions_xml}\n${instructions}`
 
             const user_content = build_user_content({
               provider_name: provider.name,

apps/editor/src/constants/instructions.ts

@@ -29,7 +29,7 @@ export const commit_message_instructions =
   "Write a brief and precise summary for the changes, limited to a single sentence. Because the summary will be used for a commit message, don't use any markdown formatting and don't include a trailing dot. Use an imperative tone to ensure clarity and focus on the primary change or purpose."
 
 export const find_relevant_files_instructions =
-  "Find all files building modules of the task's scope."
+  "Find all files building modules of the following task's scope:"
 
 export const find_relevant_files_format = `<system>
 Your response must contain paths of relevant files enclosed in "relevant-files" and "file-path" XML tags. Don't send anything else. Example:

apps/editor/src/views/panel/backend/message-handlers/handle-copy-prompt.ts

@@ -151,14 +151,7 @@ export const handle_copy_prompt = async (params: {
         system_instructions_xml = `<system>\n${edit_format_instructions}\n</system>`
       }
     } else if (is_in_find_relevant_files_prompt_type) {
-      const config = vscode.workspace.getConfiguration('codeWebChat')
-      const config_find_relevant_files_instructions = config.get<string>(
-        'findRelevantFilesInstructions'
-      )
-      const instructions_to_use =
-        config_find_relevant_files_instructions ||
-        find_relevant_files_instructions
-      system_instructions_xml = `${find_relevant_files_format_for_panel}\n${instructions_to_use}\nTask:`
+      system_instructions_xml = `${find_relevant_files_format_for_panel}\n${find_relevant_files_instructions}`
     }
 
     const text = context_text

apps/editor/src/views/panel/backend/message-handlers/handle-find-relevant-files.ts

@@ -355,17 +355,10 @@ export const handle_find_relevant_files = async (
 
     const endpoint_url = provider.base_url
 
-    const config = vscode.workspace.getConfiguration('codeWebChat')
-    const config_find_relevant_files_instructions = config.get<string>(
-      'findRelevantFilesInstructions'
-    )
-    const instructions_to_use =
-      config_find_relevant_files_instructions ||
-      find_relevant_files_instructions
-    const system_instructions_xml = `${find_relevant_files_format_for_panel}\n${instructions_to_use}`
+    const system_instructions_xml = `${find_relevant_files_format_for_panel}\n${find_relevant_files_instructions}`
 
     const part1 = `<files>\n${collected.other_files}`
-    const part2 = `${collected.recent_files}</files>\n${skill_definitions}${system_instructions_xml}\nTask:\n${processed_instructions}`
+    const part2 = `${collected.recent_files}</files>\n${skill_definitions}${system_instructions_xml}\n${processed_instructions}`
 
     const user_content = build_user_content({
       provider_name: provider.name,

apps/editor/src/views/panel/backend/message-handlers/handle-send-to-browser.ts

@@ -196,14 +196,7 @@ export const handle_send_to_browser = async (params: {
         } else if (
           params.panel_provider.web_prompt_type == 'find-relevant-files'
         ) {
-          const config = vscode.workspace.getConfiguration('codeWebChat')
-          const config_find_relevant_files_instructions = config.get<string>(
-            'findRelevantFilesInstructions'
-          )
-          const instructions_to_use =
-            config_find_relevant_files_instructions ||
-            find_relevant_files_instructions
-          system_instructions_xml = `${find_relevant_files_format_for_panel}\n${instructions_to_use}\nTask:`
+          system_instructions_xml = `${find_relevant_files_format_for_panel}\n${find_relevant_files_instructions}`
         }
 
         return {

apps/editor/src/views/settings/backend/message-handlers/handle-get-find-relevant-files-instructions.ts

@@ -41,5 +41,3 @@ export * from './handle-get-extended-cache-duration-for-anthropic'
 export * from './handle-update-extended-cache-duration-for-anthropic'
 export * from './handle-open-keybindings'
 export * from './handle-open-external-url'
-export * from './handle-get-find-relevant-files-instructions'
-export * from './handle-update-find-relevant-files-instructions'

apps/editor/src/views/settings/backend/message-handlers/handle-update-find-relevant-files-instructions.ts

@@ -46,9 +46,7 @@ import {
   handle_get_extended_cache_duration_for_anthropic,
   handle_update_extended_cache_duration_for_anthropic,
   handle_open_keybindings,
-  handle_open_external_url,
-  handle_get_find_relevant_files_instructions,
-  handle_update_find_relevant_files_instructions
+  handle_open_external_url
 } from './message-handlers'
 
 export class SettingsProvider {
@@ -370,12 +368,6 @@ export class SettingsProvider {
           await handle_open_keybindings(message)
         } else if (message.command == 'OPEN_EXTERNAL_URL') {
           await handle_open_external_url(message)
-        } else if (message.command == 'GET_FIND_RELEVANT_FILES_INSTRUCTIONS') {
-          await handle_get_find_relevant_files_instructions(this)
-        } else if (
-          message.command == 'UPDATE_FIND_RELEVANT_FILES_INSTRUCTIONS'
-        ) {
-          await handle_update_find_relevant_files_instructions(message)
         }
       },
       null,
@@ -420,7 +412,6 @@ export class SettingsProvider {
           void handle_get_are_automatic_checkpoints_disabled(this)
           void handle_get_checkpoint_lifespan(this)
           void handle_get_gemini_user_id(this)
-          void handle_get_find_relevant_files_instructions(this)
           void handle_get_ai_studio_user_id(this)
           void handle_get_send_with_shift_enter(this)
           void handle_get_check_new_files(this)