Skip to content

Commit 6b57f69

Browse files
committed
Rename the settings data hook and file from to for clarity
1 parent faf2ce2 commit 6b57f69

2 files changed

Lines changed: 34 additions & 42 deletions

File tree

‎packages/vscode/src/views/settings/frontend/Settings.tsx‎

Lines changed: 33 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useState, useEffect, useMemo } from 'react'
2-
import { use_settings_data } from './hooks/use-settings-data'
2+
import { use_settings } from './hooks/use-settings'
33
import { post_message } from './utils/post_message'
44
import { BackendMessage } from '../types/messages'
55
import { Home } from './Home/Home'
@@ -15,20 +15,20 @@ type NavItem =
1515
const vscode = acquireVsCodeApi()
1616

1717
export const Settings = () => {
18-
const settings_data_hook = use_settings_data(vscode)
18+
const settings_hook = use_settings(vscode)
1919
const [scroll_to_section_on_load, set_scroll_to_section_on_load] =
2020
useState<NavItem>()
2121

2222
const all_data_loaded = useMemo(() => {
2323
return (
24-
settings_data_hook.providers !== undefined &&
25-
settings_data_hook.code_completions_configs !== undefined &&
26-
settings_data_hook.commit_messages_configs !== undefined &&
27-
settings_data_hook.edit_context_configs !== undefined &&
28-
settings_data_hook.intelligent_update_configs !== undefined &&
29-
settings_data_hook.commit_message_instructions !== undefined
24+
settings_hook.providers !== undefined &&
25+
settings_hook.code_completions_configs !== undefined &&
26+
settings_hook.commit_messages_configs !== undefined &&
27+
settings_hook.edit_context_configs !== undefined &&
28+
settings_hook.intelligent_update_configs !== undefined &&
29+
settings_hook.commit_message_instructions !== undefined
3030
)
31-
}, [settings_data_hook])
31+
}, [settings_hook])
3232

3333
useEffect(() => {
3434
if (!all_data_loaded) return
@@ -46,42 +46,34 @@ export const Settings = () => {
4646

4747
return (
4848
<Home
49-
providers={settings_data_hook.providers!}
50-
code_completions_configs={settings_data_hook.code_completions_configs!}
51-
commit_messages_configs={settings_data_hook.commit_messages_configs!}
52-
edit_context_configs={settings_data_hook.edit_context_configs!}
53-
intelligent_update_configs={
54-
settings_data_hook.intelligent_update_configs!
55-
}
56-
commit_message_instructions={
57-
settings_data_hook.commit_message_instructions!
58-
}
59-
set_providers={settings_data_hook.set_providers}
60-
set_code_completions_configs={
61-
settings_data_hook.set_code_completions_configs
62-
}
63-
set_commit_messages_configs={
64-
settings_data_hook.set_commit_messages_configs
65-
}
66-
set_edit_context_configs={settings_data_hook.set_edit_context_configs}
49+
providers={settings_hook.providers!}
50+
code_completions_configs={settings_hook.code_completions_configs!}
51+
commit_messages_configs={settings_hook.commit_messages_configs!}
52+
edit_context_configs={settings_hook.edit_context_configs!}
53+
intelligent_update_configs={settings_hook.intelligent_update_configs!}
54+
commit_message_instructions={settings_hook.commit_message_instructions!}
55+
set_providers={settings_hook.set_providers}
56+
set_code_completions_configs={settings_hook.set_code_completions_configs}
57+
set_commit_messages_configs={settings_hook.set_commit_messages_configs}
58+
set_edit_context_configs={settings_hook.set_edit_context_configs}
6759
set_intelligent_update_configs={
68-
settings_data_hook.set_intelligent_update_configs
60+
settings_hook.set_intelligent_update_configs
6961
}
7062
on_commit_instructions_change={
71-
settings_data_hook.handle_commit_instructions_change
63+
settings_hook.handle_commit_instructions_change
7264
}
73-
on_open_editor_settings={settings_data_hook.handle_open_editor_settings}
74-
on_reorder_providers={settings_data_hook.handle_reorder_providers}
75-
on_add_provider={settings_data_hook.handle_add_provider}
76-
on_delete_provider={settings_data_hook.handle_delete_provider}
77-
on_rename_provider={settings_data_hook.handle_rename_provider}
78-
on_change_api_key={settings_data_hook.handle_change_api_key}
79-
on_add_config={settings_data_hook.handle_add_config}
80-
on_reorder_configs={settings_data_hook.handle_reorder_configs}
81-
on_edit_config={settings_data_hook.handle_edit_config}
82-
on_delete_config={settings_data_hook.handle_delete_config}
83-
on_set_default_config={settings_data_hook.handle_set_default_config}
84-
on_unset_default_config={settings_data_hook.handle_unset_default_config}
65+
on_open_editor_settings={settings_hook.handle_open_editor_settings}
66+
on_reorder_providers={settings_hook.handle_reorder_providers}
67+
on_add_provider={settings_hook.handle_add_provider}
68+
on_delete_provider={settings_hook.handle_delete_provider}
69+
on_rename_provider={settings_hook.handle_rename_provider}
70+
on_change_api_key={settings_hook.handle_change_api_key}
71+
on_add_config={settings_hook.handle_add_config}
72+
on_reorder_configs={settings_hook.handle_reorder_configs}
73+
on_edit_config={settings_hook.handle_edit_config}
74+
on_delete_config={settings_hook.handle_delete_config}
75+
on_set_default_config={settings_hook.handle_set_default_config}
76+
on_unset_default_config={settings_hook.handle_unset_default_config}
8577
scroll_to_section_on_load={scroll_to_section_on_load}
8678
/>
8779
)

packages/vscode/src/views/settings/frontend/hooks/use-settings-data.ts renamed to packages/vscode/src/views/settings/frontend/hooks/use-settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
} from '@/views/settings/types/messages'
88
import { post_message } from '../utils/post_message'
99

10-
export const use_settings_data = (vscode: any) => {
10+
export const use_settings = (vscode: any) => {
1111
const [providers, set_providers] = useState<ProviderForClient[] | undefined>(
1212
undefined
1313
)

0 commit comments

Comments
 (0)