Repository navigation
Commit 7278b91
committed
Refactor settings UI to implement grouped navigation and add placeholder to search mode prompt
- 'seach mode' quick pick should have appropriate placeholder
- instead of 'search for files...' in descriptions, use 'select files...'
- add missing translations to `apps/editor/src/i18n/translations/commands/search-files.ts`
- move 'commit message instructions' to 'commit messages' subsection (in preferences)
- 'commit message instructions' should be collapsible
- categorize expand/collapse translations in 'common'
- assess if translations are correctly categorized
- move 'edit files system instructions' to 'miscellaneous'
- when scrolled to sub-section, the parent menu item should keep being highlighted
- navigation item should accept prop 'has active child' that is used when a child is active
- 'edit files system instructions' should appear below 'auto run intelligent update'
- 'edit files system instructions' -> quote 'edit files' in both title and desc
- place 'open editor settings' 'ignore patterns' 'allow patterns' 'code at cursor shortcuts' in Preferences> 'Open...' submenu
- rename 'Preferences' to 'General' (with translations)
- move 'auto run intelligent update' and 'edit files system instructions' in API Calls > Miscellaneous
- group should accept prop 'is last' if is last, it should set padding bottom to formula: 100vh minus its height
- use SECTION_HEADER_HEIGHT
- use GROUP_TITLE_HEIGHT
- scrolling to anchors which is invalid, stops about 10 pixels too early
- detach navigation item component into two: 'navigation item section' and 'navigation item group'.
- the `packages/ui/src/components/editor/settings/NavigationItemSection/NavigationItemSection.tsx` should not be clickable, as we only want users to navigate directly to groups. We like how section gets highlighted as soon it's visible though.
- in `packages/ui/src/components/editor/settings/NavigationItemSection/NavigationItemSection.tsx` merge is_active and has_active_child under a single is_active
- when parent is active of `packages/ui/src/components/editor/settings/NavigationItemGroup/NavigationItemGroup.tsx`, labels should not be dimmed
- section's title should use this color: var(--vscode-textLink-foreground);
- `packages/ui/src/components/editor/settings/NavigationItemSection/NavigationItemSection.tsx` should use this color: var(--vscode-textLink-foreground);
- move 'reuse last tab' to chatbots>Miscellanous
- in chatbots, place Miscellanous below configurations
- change nav items opacity with transition-duration-250
- rename Miscellaneous to Misc
- rename 'misc' to 'other'
- don't use 'is nested' instead use group/section prefixes
- move the 'credentials are stored securely...' above the group, right below the section
- group should not accept notices
- rename chatbots > 'Other' to 'Behavior'
- some translations are in wrong files, e.g. 'behavior'
- rename api calls > other to behavior
- place 'edit files system instructions' in a separate group 'system instructions'
- rename 'edit files system instructions' to 'edit files'
- rename General>'other' to 'behavior'
- move General>'behavior' to be below 'Open...'
- rename 'general'>behavior to 'context'
- make sure nav item identifiers follow clear structure where section is clearly stated1 parent 414b842 commit 7278b91
27 files changed
Lines changed: 990 additions & 715 deletions
File tree
- apps/editor/src
- commands/search-files-command/utils
- constants
- i18n/translations/commands
- views/settings/frontend
- Home
- sections
- i18n/translations
- packages/ui/src
- components/editor/settings
- Group
- Layout
- Section
- constants
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
254 | 272 | | |
255 | 273 | | |
256 | 274 | | |
| |||
270 | 288 | | |
271 | 289 | | |
272 | 290 | | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
289 | 307 | | |
290 | 308 | | |
291 | 309 | | |
| |||
306 | 324 | | |
307 | 325 | | |
308 | 326 | | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
317 | 335 | | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
326 | 344 | | |
327 | 345 | | |
328 | 346 | | |
| |||
361 | 379 | | |
362 | 380 | | |
363 | 381 | | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | | - | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
380 | 398 | | |
381 | 399 | | |
382 | 400 | | |
| |||
0 commit comments