Skip to content

Commit 7bae0a8

Browse files
committed
Control BrowserConnectionStatus visibility via is_visible prop to preserve component state across target switches
- 'connected' reappears when changing target back to web └── apps └── editor └── src └── views └── prompt └── frontend ├── Main │ ├── Main.tsx │ └── MainView │ ├── MainView.tsx │ └── components │ └── BrowserConnectionStatus │ └── BrowserConnectionStatus.tsx ├── Prompt.tsx └── hooks └── use-prompt └── use-prompt.ts
1 parent e1f7cd6 commit 7bae0a8

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

‎apps/editor/src/views/prompt/frontend/Main/MainView/MainView.tsx‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -247,18 +247,17 @@ export const MainView: React.FC<Props> = (props) => {
247247
/>
248248
<UiScrollable scroll_to_top_key={props.scroll_reset_key} top_shadow>
249249
<div className={styles.container}>
250-
{props.target == TARGET.WEB && (
251-
<BrowserConnectionStatus
252-
is_connected={props.is_connected}
253-
on_install={props.on_install_browser_extension}
254-
translations={{
255-
connected: t('main.browser-connection.connected'),
256-
not_connected: t('main.browser-connection.not-connected'),
257-
install: t('main.browser-connection.install'),
258-
hide: t('main.browser-connection.hide')
259-
}}
260-
/>
261-
)}
250+
<BrowserConnectionStatus
251+
is_visible={props.target == TARGET.WEB}
252+
is_connected={props.is_connected}
253+
on_install={props.on_install_browser_extension}
254+
translations={{
255+
connected: t('main.browser-connection.connected'),
256+
not_connected: t('main.browser-connection.not-connected'),
257+
install: t('main.browser-connection.install'),
258+
hide: t('main.browser-connection.hide')
259+
}}
260+
/>
262261

263262
{props.response_history.length > 0 && (
264263
<UiResponses

‎apps/editor/src/views/prompt/frontend/Main/MainView/components/BrowserConnectionStatus/BrowserConnectionStatus.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { Separator } from '@ui/components/editor/prompt/Separator'
44

55
type Props = {
66
is_connected: boolean
7+
is_visible: boolean
78
translations: {
89
connected: string
910
not_connected: string
@@ -32,7 +33,7 @@ export const BrowserConnectionStatus: React.FC<Props> = (props) => {
3233
}
3334
}, [props.is_connected, is_closed, has_been_closed])
3435

35-
if (is_closed) {
36+
if (is_closed || !props.is_visible) {
3637
return null
3738
}
3839

0 commit comments

Comments
 (0)