Refactor model provider upsert logic into a reusable utility, add support for reasoning effort configuration, and allow constant conditions in loops via ESLint

Author: robertpiosik

apps/editor/.eslintrc.json

@@ -31,7 +31,8 @@
     "no-empty": "off",
     "react/react-in-jsx-scope": "off",
     "@typescript-eslint/no-namespace": "off",
-    "no-undef": "off"
+    "no-undef": "off",
+    "no-constant-condition": ["error", { "checkLoops": false }]
   },
   "overrides": [
     {

apps/editor/src/commands/apply-context-command/sources/check-all-with-keywords-source.ts

@@ -11,7 +11,6 @@ export const handle_check_all_with_keywords_source = async (
   extension_context: vscode.ExtensionContext
 ): Promise<'back' | void> => {
   try {
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       const input_box = vscode.window.createInputBox()
       input_box.title = 'Keyword Search'
@@ -103,7 +102,6 @@ export const handle_check_all_with_keywords_source = async (
       }
 
       // Inner loop for file selection
-      // eslint-disable-next-line no-constant-condition
       while (true) {
         const quick_pick_items = matched_files.map((file_path) => {
           const workspace_root =

apps/editor/src/commands/apply-context-command/sources/commit-files-source.ts

@@ -18,7 +18,6 @@ export const handle_commit_files_source = async (
       return
     }
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       const log_output = execSync('git log -n 20 --pretty=format:"%H|%s|%ar"', {
         cwd: repository.rootUri.fsPath,
@@ -131,7 +130,6 @@ export const handle_commit_files_source = async (
       }
 
       // Inner loop for file selection
-      // eslint-disable-next-line no-constant-condition
       while (true) {
         const file_items = valid_files.map((f) => ({
           label: path.basename(f.relative_path),

apps/editor/src/commands/apply-context-command/sources/json-file-source.ts

@@ -94,7 +94,6 @@ export const handle_json_file_source = async (
 
     let active_dialog_count = 0
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       const create_items = () => {
         const items: (vscode.QuickPickItem & {

apps/editor/src/commands/apply-context-command/sources/unstaged-files-source.ts

@@ -65,7 +65,6 @@ export const handle_unstaged_files_source = async (
 
     const workspace_roots = workspace_provider.get_workspace_roots()
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       const quick_pick_items = await Promise.all(
         existing_unstaged_files.map(async (file_path) => {

apps/editor/src/commands/apply-context-command/sources/workspace-state-source.ts

@@ -45,7 +45,6 @@ export const handle_workspace_state_source = async (
       tooltip: 'Delete'
     }
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       const create_quick_pick_items = (contexts: SavedContext[]) => {
         const items: (vscode.QuickPickItem & {

apps/editor/src/views/panel/backend/message-handlers/handle-at-sign-quick-pick/handle-at-sign-quick-pick.ts

@@ -134,7 +134,6 @@ const at_sign_quick_pick = async (params: {
 
   let selected_path_item: QuickPickItem | undefined
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     const all_quick_pick_items: QuickPickItem[] = checked_paths
       .filter((p) => {

apps/editor/src/views/panel/backend/message-handlers/handle-edit-context.ts

@@ -401,7 +401,6 @@ export const handle_edit_context = async (
   let current_config_id = message.config_id
   let should_show_quick_pick = message.use_quick_pick
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     const config_result = await get_edit_context_config({
       api_providers_manager,

apps/editor/src/views/panel/backend/message-handlers/handle-hash-sign-quick-pick/handle-hash-sign-quick-pick.ts

@@ -70,7 +70,6 @@ const hash_sign_quick_pick = async (params: {
     (item) => item.label == last_selected_symbol
   )
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     const quick_pick = vscode.window.createQuickPick()
     quick_pick.items = items

apps/editor/src/views/panel/backend/message-handlers/handle-hash-sign-quick-pick/symbols/commit-symbol.ts

@@ -36,7 +36,6 @@ export const handle_commit_item = async (
       return undefined
     }
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       let selected_folder: vscode.WorkspaceFolder | undefined