Skip to content

Commit 9b7cc21

Browse files
committed
Update ResponsePreviewFooter to conditionally display icons based on the compact step
- should not show icon unless compacted └── packages └── ui └── src └── components └── editor ├── common │ └── Button │ ├── Button.module.scss │ ├── Button.stories.tsx │ └── Button.tsx └── prompt └── ResponsePreviewFooter ├── ResponsePreviewFooter.module.scss └── ResponsePreviewFooter.tsx
1 parent 04e308e commit 9b7cc21

2 files changed

Lines changed: 15 additions & 28 deletions

File tree

‎packages/ui/src/components/editor/prompt/ResponsePreviewFooter/ResponsePreviewFooter.module.scss‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,3 @@
66
flex: 1;
77
}
88
}
9-
10-
.text {
11-
&--hidden {
12-
display: none;
13-
}
14-
}
15-
16-
.icon {
17-
display: none;
18-
&--visible {
19-
display: inline-block;
20-
}
21-
}

‎packages/ui/src/components/editor/prompt/ResponsePreviewFooter/ResponsePreviewFooter.tsx‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,34 +9,34 @@ type Props = {
99
is_accept_disabled: boolean
1010
}
1111

12-
export const ResponsePreviewFooter: React.FC<Props> = ({
13-
on_back,
14-
on_reject,
15-
on_accept,
16-
is_accept_disabled
17-
}) => {
12+
export const ResponsePreviewFooter: React.FC<Props> = (props) => {
1813
const { container_ref, compact_step } = use_compacting()
1914

2015
return (
2116
<div className={styles.container} ref={container_ref}>
2217
<Button
23-
on_click={on_back}
18+
on_click={props.on_back}
2419
is_secondary
2520
title="Back"
26-
codicon="chevron-left"
21+
codicon={compact_step >= 1 ? 'chevron-left' : undefined}
2722
>
28-
{compact_step < 1 && <span className={styles.text}>Back</span>}
23+
{compact_step < 1 && <span>Back</span>}
2924
</Button>
30-
<Button on_click={on_reject} is_danger title="Reject" codicon="close">
31-
{compact_step < 2 && <span className={styles.text}>Reject</span>}
25+
<Button
26+
on_click={props.on_reject}
27+
is_danger
28+
title="Reject"
29+
codicon={compact_step >= 2 ? 'close-small' : undefined}
30+
>
31+
{compact_step < 2 && <span>Reject</span>}
3232
</Button>
3333
<Button
34-
on_click={on_accept}
35-
disabled={is_accept_disabled}
34+
on_click={props.on_accept}
35+
disabled={props.is_accept_disabled}
3636
title="Accept"
37-
codicon="check"
37+
codicon={compact_step >= 3 ? 'check' : undefined}
3838
>
39-
{compact_step < 3 && <span className={styles.text}>Accept</span>}
39+
{compact_step < 3 && <span>Accept</span>}
4040
</Button>
4141
</div>
4242
)

0 commit comments

Comments
 (0)