Update UI messages and debounce change events in workspace and open editors providers

Author: robertpiosik

packages/shared/src/constants/dictionary.ts

@@ -145,7 +145,8 @@ export const dictionary = {
     TYPE_SOMETHING_TO_USE_GROUP: 'Type something to use this group.',
     GROUP_HAS_NO_SELECTED_PRESETS:
       'The chosen group has no selected presets to run.',
-    NO_RECENTLY_USED_PRESETS_OR_GROUPS: 'No recently used presets or groups.',
+    NO_RECENTLY_USED_PRESETS_OR_GROUPS:
+      'No recently used presets or groups. Select from list below.',
     CHECKPOINT_OPERATION_IN_PROGRESS:
       'Another checkpoint operation is currently in progress. Please wait for it to complete.',
     URL_OVERRIDE_DIFFERENT_DOMAIN: (preset_name: string) =>

packages/vscode/src/context/providers/open-editors/open-editors-provider.ts

@@ -30,6 +30,7 @@ export class OpenEditorsProvider
   private _config_change_handler: vscode.Disposable
   private _workspace_provider: WorkspaceProvider
   private _use_compact_token_count: boolean = false
+  private _change_event_dispatch_timeout: NodeJS.Timeout | null = null
 
   public set_use_compact_token_count(use_compact: boolean): void {
     if (this._use_compact_token_count != use_compact) {
@@ -83,6 +84,18 @@ export class OpenEditorsProvider
     this.refresh()
   }
 
+  private _dispatch_change_events(): void {
+    if (this._change_event_dispatch_timeout) {
+      clearTimeout(this._change_event_dispatch_timeout)
+    }
+
+    this._change_event_dispatch_timeout = setTimeout(() => {
+      this._on_did_change_checked_files.fire()
+      this.refresh()
+      this._change_event_dispatch_timeout = null
+    }, 500)
+  }
+
   private _is_file_in_any_workspace(file_path: string): boolean {
     return this._workspace_roots.some((root) => file_path.startsWith(root))
   }
@@ -105,7 +118,7 @@ export class OpenEditorsProvider
     }
 
     if (files_to_uncheck.length > 0) {
-      this._on_did_change_checked_files.fire()
+      this._dispatch_change_events()
     }
   }
 
@@ -154,6 +167,9 @@ export class OpenEditorsProvider
     this._tab_change_handler.dispose()
     this._config_change_handler.dispose()
     this._on_did_change_checked_files.dispose()
+    if (this._change_event_dispatch_timeout) {
+      clearTimeout(this._change_event_dispatch_timeout)
+    }
   }
 
   refresh(): void {
@@ -357,8 +373,7 @@ export class OpenEditorsProvider
       await this._open_file_in_non_preview_mode(item.resourceUri)
     }
 
-    this._on_did_change_checked_files.fire()
-    this.refresh()
+    this._dispatch_change_events()
   }
 
   clear_checks(): void {
@@ -373,11 +388,7 @@ export class OpenEditorsProvider
       this._checked_items.set(file_path, vscode.TreeItemCheckboxState.Unchecked)
     }
 
-    // Fire the event with undefined to force full tree refresh
-    this._on_did_change_tree_data.fire(undefined)
-
-    // Fire the checked files change event to trigger synchronization with workspace view
-    this._on_did_change_checked_files.fire()
+    this._dispatch_change_events()
   }
 
   async check_all(): Promise<void> {
@@ -397,11 +408,7 @@ export class OpenEditorsProvider
       }
     }
 
-    // Fire the event with undefined to force full tree refresh
-    this._on_did_change_tree_data.fire(undefined)
-
-    // Fire the checked files change event to trigger synchronization with workspace view
-    this._on_did_change_checked_files.fire()
+    this._dispatch_change_events()
   }
 
   get_checked_files(): string[] {
@@ -431,10 +438,7 @@ export class OpenEditorsProvider
       }
     }
 
-    this.refresh()
-
-    // Fire the checked files change event to trigger synchronization
-    this._on_did_change_checked_files.fire()
+    this._dispatch_change_events()
   }
 
   is_initialized(): boolean {

packages/vscode/src/context/providers/workspace/workspace-provider.ts

@@ -65,6 +65,7 @@ export class WorkspaceProvider
   private _file_workspace_map: Map<string, string> = new Map()
   public gitignore_initialization: Promise<void>
   public ranges_initialization: Promise<void>
+  private _change_event_dispatch_timeout: NodeJS.Timeout | null = null
 
   private _use_compact_token_count: boolean = false
 
@@ -184,6 +185,18 @@ export class WorkspaceProvider
     return matching_root
   }
 
+  private _dispatch_change_events(): void {
+    if (this._change_event_dispatch_timeout) {
+      clearTimeout(this._change_event_dispatch_timeout)
+    }
+
+    this._change_event_dispatch_timeout = setTimeout(() => {
+      this._on_did_change_checked_files.fire()
+      this.refresh()
+      this._change_event_dispatch_timeout = null
+    }, 500)
+  }
+
   private _uncheck_ignored_files(): void {
     const checked_files = this.get_all_checked_paths()
 
@@ -204,7 +217,7 @@ export class WorkspaceProvider
     }
 
     if (files_to_uncheck.length > 0) {
-      this._on_did_change_checked_files.fire()
+      this._dispatch_change_events()
     }
   }
 
@@ -220,6 +233,9 @@ export class WorkspaceProvider
     if (this._refresh_timeout) {
       clearTimeout(this._refresh_timeout)
     }
+    if (this._change_event_dispatch_timeout) {
+      clearTimeout(this._change_event_dispatch_timeout)
+    }
 
     this._token_calculator.dispose()
   }
@@ -410,7 +426,7 @@ export class WorkspaceProvider
         dir_path = path.dirname(dir_path)
       }
 
-      this._on_did_change_checked_files.fire()
+      this._dispatch_change_events()
     }
 
     let dir_path = parent_dir
@@ -521,8 +537,7 @@ export class WorkspaceProvider
           })
       }
     }
-    this.refresh()
-    this._on_did_change_checked_files.fire()
+    this._dispatch_change_events()
   }
 
   async getTreeItem(element: FileItem): Promise<vscode.TreeItem> {
@@ -1031,8 +1046,7 @@ export class WorkspaceProvider
       dir_path = path.dirname(dir_path)
     }
 
-    this._on_did_change_checked_files.fire()
-    this.refresh()
+    this._dispatch_change_events()
   }
 
   private async _update_parent_state(dir_path: string): Promise<void> {
@@ -1315,8 +1329,7 @@ export class WorkspaceProvider
       }
     }
 
-    this.refresh()
-    this._on_did_change_checked_files.fire()
+    this._dispatch_change_events()
   }
 
   // Load .gitignore from all levels of the workspace
@@ -1458,8 +1471,7 @@ export class WorkspaceProvider
       }
     }
 
-    this.refresh()
-    this._on_did_change_checked_files.fire()
+    this._dispatch_change_events()
   }
 
   public async get_checked_files_token_count(options?: {