Remove the max concurrency setting from tool configurations and simplify the configuration editing user interface

Author: robertpiosik

apps/editor/package.json

@@ -1819,9 +1819,6 @@
               "isDefault": {
                 "type": "boolean"
               },
-              "maxConcurrency": {
-                "type": "number"
-              },
               "isPinned": {
                 "type": "boolean"
               }

apps/editor/src/services/model-providers-manager.ts

@@ -25,7 +25,6 @@ export type ToolConfig = {
   model: string
   temperature?: number
   reasoning_effort?: ReasoningEffort
-  max_concurrency?: number
   is_pinned?: boolean
 }
 
@@ -34,8 +33,7 @@ export const get_tool_config_id = (config: ToolConfig): string => {
     config.provider_name,
     config.model,
     config.temperature,
-    config.reasoning_effort ?? '',
-    config.max_concurrency ?? ''
+    config.reasoning_effort ?? ''
   ]
     .filter((v) => v !== null && v !== undefined)
     .join(':')
@@ -163,7 +161,6 @@ export class ModelProvidersManager {
         model: string
         temperature?: number
         reasoningEffort?: ReasoningEffort
-        maxConcurrency?: number
         isPinned?: boolean
       }[]
     >(settings_key, [])
@@ -177,7 +174,6 @@ export class ModelProvidersManager {
           model: sc.model,
           temperature: sc.temperature,
           reasoning_effort: sc.reasoningEffort,
-          max_concurrency: sc.maxConcurrency,
           is_pinned: sc.isPinned
         }
       })
@@ -207,8 +203,6 @@ export class ModelProvidersManager {
       }
       if (c.reasoning_effort !== undefined)
         new_config.reasoningEffort = c.reasoning_effort
-      if (c.max_concurrency !== undefined)
-        new_config.maxConcurrency = c.max_concurrency
       if (c.is_pinned) new_config.isPinned = c.is_pinned
       return new_config
     })
@@ -229,9 +223,7 @@ export class ModelProvidersManager {
       settings_config.model === tool_config.model &&
       settings_config.temperature === tool_config.temperature &&
       (settings_config.reasoningEffort ?? undefined) ===
-        (tool_config.reasoning_effort ?? undefined) &&
-      (settings_config.maxConcurrency ?? undefined) ===
-        (tool_config.max_concurrency ?? undefined)
+        (tool_config.reasoning_effort ?? undefined)
     )
   }
 
@@ -246,7 +238,6 @@ export class ModelProvidersManager {
         temperature?: number
         reasoningEffort?: ReasoningEffort
         isDefault?: boolean
-        maxConcurrency?: number
         isPinned?: boolean
       }[]
     >(settings_key, [])
@@ -264,7 +255,6 @@ export class ModelProvidersManager {
         model: default_config_from_settings.model,
         temperature: default_config_from_settings.temperature,
         reasoning_effort: default_config_from_settings.reasoningEffort,
-        max_concurrency: default_config_from_settings.maxConcurrency,
         is_pinned: default_config_from_settings.isPinned
       }
       const validated_config = this._validate_tool_config(tool_config)

apps/editor/src/views/panel/backend/message-handlers/handle-fix-all-failed-files.ts

@@ -124,8 +124,7 @@ export const handle_fix_all_failed_files = async (
     .filter((item) => item.instructions && item.safe_path)
 
   const max_concurrency =
-    intelligent_update_config.max_concurrency ??
-    (files_to_process.length > 0 ? files_to_process.length : 1)
+    files_to_process.length > 0 ? files_to_process.length : 1
 
   // Process in batches
   for (let i = 0; i < files_to_process.length; i += max_concurrency) {

apps/editor/src/views/panel/backend/message-handlers/handle-get-api-tool-configurations.ts

@@ -34,8 +34,7 @@ export const handle_get_api_tool_configurations = async (
       default_config.provider_name == config.provider_name &&
       default_config.model == config.model &&
       default_config.temperature == config.temperature &&
-      default_config.reasoning_effort == config.reasoning_effort &&
-      default_config.max_concurrency == config.max_concurrency
+      default_config.reasoning_effort == config.reasoning_effort
     )
   }
 

apps/editor/src/views/panel/types/messages.ts

@@ -32,7 +32,6 @@ export type ApiToolConfiguration = {
   model: string
   temperature?: number
   reasoning_effort?: string
-  max_concurrency?: number
   is_default?: boolean
   is_pinned?: boolean
 }

apps/editor/src/views/utils/config-editing.ts

@@ -33,7 +33,7 @@ export const initial_select_provider = async (
       const quick_pick =
         vscode.window.createQuickPick<(typeof provider_items)[0]>()
       quick_pick.items = provider_items
-      quick_pick.title = 'Model Providers'
+      quick_pick.title = 'Create New Configuration'
       quick_pick.placeholder = 'Select a model provider'
       const close_button: vscode.QuickInputButton = {
         iconPath: new vscode.ThemeIcon('close'),
@@ -99,7 +99,7 @@ export const initial_select_model = async (
       return await new Promise<string | undefined>((resolve) => {
         const quick_pick = vscode.window.createQuickPick()
         quick_pick.items = model_items
-        quick_pick.title = 'Models'
+        quick_pick.title = 'Create New Configuration'
         quick_pick.placeholder = 'Choose an AI model'
         quick_pick.buttons = [vscode.QuickInputButtons.Back]
         if (provider.name) {
@@ -157,7 +157,7 @@ export const initial_select_model = async (
   }
 
   return await vscode.window.showInputBox({
-    title: 'Enter Model Name',
+    title: 'Create New Configuration',
     prompt: 'Could not fetch models. Please enter a model name (ID).'
   })
 }
@@ -177,7 +177,7 @@ export const edit_provider_for_config = async (
     const quick_pick =
       vscode.window.createQuickPick<(typeof provider_items)[0]>()
     quick_pick.items = provider_items
-    quick_pick.title = 'Model Providers'
+    quick_pick.title = 'Edit Configuration'
     quick_pick.placeholder = 'Select a model provider'
     quick_pick.buttons = [vscode.QuickInputButtons.Back]
     if (current_provider_name) {
@@ -265,7 +265,7 @@ export const edit_model_for_config = async (
         const quick_pick =
           vscode.window.createQuickPick<(typeof model_items)[0]>()
         quick_pick.items = model_items
-        quick_pick.title = 'Models'
+        quick_pick.title = 'Edit Configuration'
         quick_pick.placeholder = 'Choose a model'
         quick_pick.buttons = [vscode.QuickInputButtons.Back]
         if (config.model) {
@@ -335,7 +335,7 @@ export const edit_model_for_config = async (
   }
 
   const new_model_input = await vscode.window.showInputBox({
-    title: 'Enter Model Name',
+    title: 'Edit Configuration',
     value: config.model,
     prompt: `Enter a model name (ID)`
   })
@@ -350,7 +350,7 @@ export const edit_temperature_for_config = async (
 ): Promise<number | null | undefined> => {
   return await new Promise<number | null | undefined>((resolve) => {
     const input = vscode.window.createInputBox()
-    input.title = 'Edit Temperature'
+    input.title = 'Edit Configuration'
     input.value = config.temperature?.toString() ?? ''
     input.prompt = 'Enter a value between 0 and 2. Leave empty to unset.'
     input.buttons = [vscode.QuickInputButtons.Back]
@@ -421,7 +421,7 @@ export const edit_reasoning_effort_for_config = async (
   return await new Promise<string | null | undefined>((resolve) => {
     const quick_pick = vscode.window.createQuickPick()
     quick_pick.items = effort_options
-    quick_pick.title = 'Reasoning Efforts'
+    quick_pick.title = 'Edit Configuration'
     quick_pick.placeholder = 'Select reasoning effort'
     quick_pick.buttons = [vscode.QuickInputButtons.Back]
     if (current_effort) {
@@ -461,25 +461,3 @@ export const edit_reasoning_effort_for_config = async (
     quick_pick.show()
   })
 }
-
-export const edit_max_concurrency_for_config = async (config: ToolConfig) => {
-  const new_concurrency_str = await vscode.window.showInputBox({
-    title: 'Edit Max Concurrency',
-    value: config.max_concurrency?.toString() ?? '',
-    prompt:
-      'Enter a number for max concurrency. Leave empty or enter 0 to unset.',
-    validateInput: (value) => {
-      if (value === '') return null
-      const num = parseInt(value, 10)
-      if (isNaN(num) || !Number.isInteger(num) || num < 0) {
-        return 'Please enter a whole number greater than or equal to 0.'
-      }
-      return null
-    }
-  })
-  if (new_concurrency_str === undefined) return undefined
-  if (new_concurrency_str === '') return null
-  const val = parseInt(new_concurrency_str, 10)
-  if (val === 0) return null
-  return val
-}

apps/editor/src/views/utils/upsert-configuration.ts

@@ -8,7 +8,6 @@ import {
 import { dictionary } from '@shared/constants/dictionary'
 import { ModelFetcher } from '@/services/model-fetcher'
 import {
-  edit_max_concurrency_for_config,
   edit_model_for_config,
   edit_provider_for_config,
   edit_reasoning_effort_for_config,
@@ -58,7 +57,7 @@ export const upsert_configuration = async (params: {
         providers_manager.get_intelligent_update_tool_configs()
       save_configs = (configs) =>
         providers_manager.save_intelligent_update_tool_configs(configs)
-      advanced_options = ['Temperature', 'Reasoning Effort', 'Max Concurrency']
+      advanced_options = ['Temperature', 'Reasoning Effort']
       break
     case 'prune-context':
       get_configs = () => providers_manager.get_prune_context_tool_configs()
@@ -177,9 +176,12 @@ export const upsert_configuration = async (params: {
       JSON.stringify(updated_config) !== JSON.stringify(starting_config)
 
     const items: vscode.QuickPickItem[] = [
-      { label: 'Model Provider', detail: updated_config.provider_name },
-      { label: 'Model', detail: updated_config.model },
-      { label: 'Advanced' }
+      {
+        label: 'Model',
+        description: updated_config.provider_name,
+        detail: updated_config.model
+      },
+      { label: 'More...' }
     ]
 
     const selected_item = await new Promise<vscode.QuickPickItem | undefined>(
@@ -224,11 +226,11 @@ export const upsert_configuration = async (params: {
               Object.assign(updated_config, starting_config)
               quick_pick.items = [
                 {
-                  label: 'Model Provider',
-                  detail: updated_config.provider_name
+                  label: 'Model',
+                  description: updated_config.provider_name,
+                  detail: updated_config.model
                 },
-                { label: 'Model', detail: updated_config.model },
-                { label: 'Advanced' }
+                { label: 'More...' }
               ]
               quick_pick.buttons = [close_button]
             }
@@ -250,27 +252,46 @@ export const upsert_configuration = async (params: {
     last_selected_label = selected_item.label
     const selected_option = selected_item.label
 
-    if (selected_option == 'Model Provider') {
-      const new_provider = await edit_provider_for_config(
-        providers_manager,
-        updated_config.provider_name
-      )
-      if (new_provider) {
-        updated_config.provider_name = new_provider.provider_name
-        updated_config.provider_type = new_provider.provider_type
-      }
-    } else if (selected_option == 'Model') {
-      const new_model = await edit_model_for_config(
-        updated_config,
-        providers_manager,
-        model_fetcher
-      )
-      if (new_model !== undefined) {
-        updated_config.model = new_model
-      }
-    } else if (selected_option == 'Advanced') {
+    if (selected_option == 'Model') {
+      let current_provider_name = updated_config.provider_name
+
       // eslint-disable-next-line no-constant-condition
+      while (true) {
+        const new_provider = await edit_provider_for_config(
+          providers_manager,
+          current_provider_name
+        )
+
+        if (!new_provider) {
+          break
+        }
+
+        current_provider_name = new_provider.provider_name
+
+        const temp_config = {
+          ...updated_config,
+          provider_name: new_provider.provider_name,
+          provider_type: new_provider.provider_type,
+          model:
+            new_provider.provider_name === updated_config.provider_name
+              ? updated_config.model
+              : ''
+        }
+        const new_model = await edit_model_for_config(
+          temp_config,
+          providers_manager,
+          model_fetcher
+        )
+        if (new_model !== undefined) {
+          updated_config.provider_name = new_provider.provider_name
+          updated_config.provider_type = new_provider.provider_type
+          updated_config.model = new_model
+          break
+        }
+      }
+    } else if (selected_option == 'More...') {
       let last_advanced_label: string | undefined
+      // eslint-disable-next-line no-constant-condition
       while (true) {
         const advanced_items: vscode.QuickPickItem[] = []
         if (advanced_options.includes('Temperature')) {
@@ -287,22 +308,13 @@ export const upsert_configuration = async (params: {
             detail: updated_config.reasoning_effort
           })
         }
-        if (advanced_options.includes('Max Concurrency')) {
-          advanced_items.push({
-            label: 'Max Concurrency',
-            description: !updated_config.max_concurrency ? 'Unset' : undefined,
-            detail: updated_config.max_concurrency?.toString() || undefined
-          })
-        }
 
         const selected_advanced = await new Promise<
           vscode.QuickPickItem | undefined
         >((resolve) => {
           const quick_pick = vscode.window.createQuickPick()
           quick_pick.items = advanced_items
-          quick_pick.title = original_id
-            ? 'Edit Configuration - Advanced'
-            : 'Create New Configuration - Advanced'
+          quick_pick.title = 'Edit Configuration'
           quick_pick.placeholder = 'Select a property to edit'
           quick_pick.buttons = [vscode.QuickInputButtons.Back]
           if (last_advanced_label) {
@@ -401,13 +413,6 @@ export const upsert_configuration = async (params: {
               break
             }
           }
-        } else if (selected_advanced.label == 'Max Concurrency') {
-          const new_concurrency =
-            await edit_max_concurrency_for_config(updated_config)
-          if (new_concurrency !== undefined) {
-            updated_config.max_concurrency =
-              new_concurrency === null ? undefined : new_concurrency
-          }
         }
       }
     }