Replace task copy functionality with task forwarding to instructions input

Author: robertpiosik

packages/ui/src/components/editor/panel/Tasks/Tasks.tsx

@@ -19,7 +19,7 @@ type Props = {
   on_change: (task: Task) => void
   on_add: () => void
   on_add_subtask?: (parent_task: Task) => void
-  on_copy: (text: string) => void
+  on_forward: (text: string) => void
   on_delete: (created_at: number) => void
 }
 
@@ -55,9 +55,6 @@ export const Tasks: React.FC<Props> = (props) => {
   const [editing_timestamp, set_editing_timestamp] = useState<number | null>(
     null
   )
-  const [last_copied_timestamp, set_last_copied_timestamp] = useState<
-    number | null
-  >(null)
   const prevent_edit_ref = useRef(false)
 
   use_auto_focus_new_task(props.tasks, set_editing_timestamp)
@@ -67,12 +64,6 @@ export const Tasks: React.FC<Props> = (props) => {
     [props.tasks]
   )
 
-  // Reset copied highlight only on structural changes to tasks
-  // so it stays highlighted when set as done by response preview.
-  useEffect(() => {
-    set_last_copied_timestamp(null)
-  }, [structure_signature])
-
   const tree = useMemo(() => add_ids(props.tasks), [props.tasks])
 
   const handle_tree_reorder = (new_tree: SortableTask[]) => {
@@ -90,7 +81,6 @@ export const Tasks: React.FC<Props> = (props) => {
     depth: number
   }) => {
     const is_editing = editing_timestamp == params.task.created_at
-    const is_copied = last_copied_timestamp == params.task.created_at
     const has_children = params.task.children && params.task.children.length > 0
 
     const checked_children_count = has_children
@@ -99,9 +89,7 @@ export const Tasks: React.FC<Props> = (props) => {
 
     return (
       <div
-        className={cn(styles.item, {
-          [styles['item--copied']]: is_copied
-        })}
+        className={styles.item}
         style={{ paddingLeft: `${10 + params.depth * 20}px` }}
       >
         {[...Array(params.depth)].map((_, i) => (
@@ -168,13 +156,12 @@ export const Tasks: React.FC<Props> = (props) => {
             >
               {params.task.text && (
                 <IconButton
-                  codicon_icon="copy"
+                  codicon_icon="forward"
                   on_click={(e) => {
                     e.stopPropagation()
-                    props.on_copy(params.task.text)
-                    set_last_copied_timestamp(params.task.created_at)
+                    props.on_forward(params.task.text)
                   }}
-                  title="Copy Task"
+                  title="Use"
                 />
               )}
               <IconButton
@@ -187,15 +174,15 @@ export const Tasks: React.FC<Props> = (props) => {
                     is_editing ? null : params.task.created_at
                   )
                 }
-                title={is_editing ? 'Save task' : 'Edit task'}
+                title={is_editing ? 'Done' : 'Edit'}
               />
               <IconButton
                 codicon_icon="trash"
                 on_click={(e) => {
                   e.stopPropagation()
                   props.on_delete(params.task.created_at)
                 }}
-                title="Delete task"
+                title="Delete"
               />
             </div>
           </div>

packages/vscode/src/views/panel/backend/message-handlers/handle-copy-task.ts

@@ -57,6 +57,5 @@ export * from './handle-request-can-undo'
 export * from './handle-get-tasks'
 export * from './handle-save-tasks'
 export * from './handle-delete-task'
-export * from './handle-copy-task'
 export * from './handle-preview-generated-code'
 export * from './handle-fix-all-failed-files'

packages/vscode/src/views/panel/backend/message-handlers/index.ts

@@ -73,7 +73,6 @@ import {
   handle_undo,
   handle_delete_checkpoint,
   handle_request_can_undo,
-  handle_copy_task,
   handle_preview_generated_code,
   handle_get_tasks,
   handle_save_tasks,
@@ -648,8 +647,6 @@ export class PanelProvider implements vscode.WebviewViewProvider {
             await handle_save_tasks(this, message)
           } else if (message.command == 'DELETE_TASK') {
             await handle_delete_task(this, message)
-          } else if (message.command == 'COPY_TASK') {
-            await handle_copy_task(message)
           } else if (message.command == 'PREVIEW_GENERATED_CODE') {
             await handle_preview_generated_code(message)
           } else if (message.command == 'REQUEST_CAN_UNDO') {

packages/vscode/src/views/panel/backend/panel-provider.ts

@@ -40,7 +40,7 @@ type Props = {
   tasks: Record<string, Task[]>
   on_tasks_change: (root: string, tasks: Task[]) => void
   on_task_delete: (root: string, timestamp: number) => void
-  on_task_copy: (text: string) => void
+  on_task_forward: (text: string) => void
 }
 
 export const Home: React.FC<Props> = (props) => {
@@ -56,8 +56,12 @@ export const Home: React.FC<Props> = (props) => {
     handle_add,
     handle_add_subtask,
     handle_delete,
-    handle_copy
-  } = use_tasks(props.on_tasks_change, props.on_task_delete, props.on_task_copy)
+    handle_forward
+  } = use_tasks(
+    props.on_tasks_change,
+    props.on_task_delete,
+    props.on_task_forward
+  )
 
   const { is_timeline_reached, timeline_ref, handle_scroll_to_timeline } =
     use_timeline_scroll()
@@ -242,8 +246,8 @@ export const Home: React.FC<Props> = (props) => {
                         on_delete={(timestamp) => {
                           handle_delete(workspace_root_folder, timestamp)
                         }}
-                        on_copy={(text) => {
-                          handle_copy(text)
+                        on_forward={(text) => {
+                          handle_forward(text)
                         }}
                       />
                     )}

packages/vscode/src/views/panel/frontend/Home/Home.tsx

@@ -38,7 +38,7 @@ const add_subtask_to_tree = (
 export const use_tasks = (
   on_tasks_change: (root: string, tasks: Task[]) => void,
   on_task_delete: (root: string, timestamp: number) => void,
-  on_task_copy: (text: string) => void
+  on_task_forward: (text: string) => void
 ) => {
   const handle_reorder = (root: string, new_tasks: Task[]) => {
     on_tasks_change(root, new_tasks)
@@ -82,8 +82,8 @@ export const use_tasks = (
     on_task_delete(root, timestamp)
   }
 
-  const handle_copy = (text: string) => {
-    on_task_copy(text)
+  const handle_forward = (text: string) => {
+    on_task_forward(text)
   }
 
   return {
@@ -92,6 +92,6 @@ export const use_tasks = (
     handle_add,
     handle_add_subtask,
     handle_delete,
-    handle_copy
+    handle_forward
   }
 }

packages/vscode/src/views/panel/frontend/Home/hooks/use-tasks.ts

@@ -105,7 +105,7 @@ export const Panel = () => {
     handle_tasks_change,
     handle_task_delete,
     handle_discard_user_changes_in_preview,
-    handle_task_copy
+    handle_task_forward
   } = use_panel(vscode)
 
   const [checkpoint_to_edit, set_checkpoint_to_edit] = useState<
@@ -363,7 +363,7 @@ export const Panel = () => {
                 tasks={tasks}
                 on_tasks_change={handle_tasks_change}
                 on_task_delete={handle_task_delete}
-                on_task_copy={handle_task_copy}
+                on_task_forward={handle_task_forward}
               />
             </div>
           </Layout>

packages/vscode/src/views/panel/frontend/Panel.tsx

@@ -172,11 +172,18 @@ export const use_panel = (vscode: any) => {
     })
   }
 
-  const handle_task_copy = (text: string) => {
-    post_message(vscode, {
-      command: 'COPY_TASK',
-      text
-    })
+  const handle_task_forward = (text: string) => {
+    handle_instructions_change(text, 'edit-context')
+
+    if (mode == MODE.WEB) {
+      handle_web_prompt_type_change('edit-context')
+    } else {
+      handle_api_prompt_type_change('edit-context')
+    }
+
+    set_active_view('main')
+    set_main_view_scroll_reset_key((k) => k + 1)
+    set_chat_input_focus_and_select_key((k) => k + 1)
   }
 
   useEffect(() => {
@@ -571,7 +578,7 @@ export const use_panel = (vscode: any) => {
     tasks,
     handle_tasks_change,
     handle_task_delete,
-    handle_task_copy,
+    handle_task_forward,
     handle_instructions_change,
     edit_preset_back_click_handler,
     edit_preset_save_handler,

packages/vscode/src/views/panel/frontend/hooks/use-panel.ts

@@ -434,11 +434,6 @@ export interface DeleteTaskMessage extends BaseMessage {
   timestamp: number
 }
 
-export interface CopyTaskMessage extends BaseMessage {
-  command: 'COPY_TASK'
-  text: string
-}
-
 export interface UpdateFileProgressMessage extends BaseMessage {
   command: 'UPDATE_FILE_PROGRESS'
   file_path: string
@@ -528,7 +523,6 @@ export type FrontendMessage =
   | GetTasksMessage
   | SaveTasksMessage
   | DeleteTaskMessage
-  | CopyTaskMessage
   | PreviewGeneratedCodeMessage
   | UpdateFileProgressMessage