Harden temporary file generation, hashing, and input validation across modules

- [Pasted text]
- image hash should have 16 characters
- revert this change [Pasted text] changes: [Changes]
- the temporary directory for 'ask' cli invocation should be located in the extension's dedicated dir, not os's temp dir

├── apps
│   └── editor
│       └── src
│           ├── features
│           │   └── context-restoration
│           │       └── utils
│           │           └── global-storage-utils.ts
│           ├── utils
│           │   └── agentic-cli-invocation
│           │       ├── index.ts
│           │       └── invoke-agentic-cli.ts
│           └── views
│               └── prompt
│                   ├── backend
│                   │   ├── message-handlers
│                   │   │   ├── handle-invoke-agentic-cli.ts
│                   │   │   ├── handle-open-prompt-image.ts
│                   │   │   ├── handle-open-prompt-pasted-text.ts
│                   │   │   ├── handle-open-website.ts
│                   │   │   ├── handle-paste-url.ts
│                   │   │   ├── handle-preview-changes-symbol.ts
│                   │   │   ├── handle-preview-commit-symbol.ts
│                   │   │   ├── handle-preview-prompt.ts
│                   │   │   ├── handle-preview-saved-context-symbol.ts
│                   │   │   ├── handle-preview-skill-symbol.ts
│                   │   │   ├── handle-save-prompt-image.ts
│                   │   │   ├── handle-save-prompt-pasted-text.ts
│                   │   │   └── utils
│                   │   │       └── build-cli-prompt.ts
│                   │   ├── prompt-view-provider.ts
│                   │   └── utils
│                   │       ├── persistent-text-storage.ts
│                   │       ├── preview-text-in-temp-file.ts
│                   │       └── symbols
│                   │           ├── image
│                   │           │   └── replace-image-symbol.ts
│                   │           ├── pasted-text
│                   │           │   └── replace-pasted-text-symbol.ts
│                   │           └── website
│                   │               └── replace-website-symbol.ts
│                   ├── frontend
│                   │   └── hooks
│                   │       └── use-prompt
│                   │           └── use-prompt.ts
│                   └── types
│                       └── messages.ts
└── packages
    ├── shared
    │   └── src
    │       ├── types
    │       │   └── prompt-types.ts
    │       └── utils
    │           └── simplify-prompt-symbols
    │               ├── simplify-prompt-symbols.spec.ts
    │               └── simplify-prompt-symbols.ts
    └── ui
        └── src
            └── components
                └── editor
                    └── common
                        └── prompts
                            ├── PromptField
                            │   └── hooks
                            │       └── use-handlers
                            │           └── handle-input-click.ts
                            └── shared
                                └── symbols
                                    ├── get-highlighted-text.tsx
                                    ├── position-mapping.ts
                                    ├── reconstruct-raw-value.ts
                                    └── use-symbol-deletion.ts

Author: robertpiosik

apps/editor/src/utils/agentic-cli-invocation/invoke-agentic-cli.ts

@@ -368,10 +368,16 @@ export const invoke_agentic_cli = async (params: {
       if (params.isolate_in_temp_dir) {
         if (params.copy_selected_files) {
           temp_dir_path = await fs.promises.mkdtemp(
-            path.join(os.tmpdir(), 'cwc-cli-')
+            path.join(os.tmpdir(), 'cwc-cli-edit-')
           )
         } else {
-          temp_dir_path = path.join(os.tmpdir(), 'cwc-cli')
+          // Reuse directory to avoid repeated permission asks
+          const global_storage_path =
+            params.extension_context.globalStorageUri.fsPath
+          if (!fs.existsSync(global_storage_path)) {
+            await fs.promises.mkdir(global_storage_path, { recursive: true })
+          }
+          temp_dir_path = path.join(global_storage_path, 'cwc-cli-ask')
           await fs.promises.rm(temp_dir_path, { recursive: true, force: true })
           await fs.promises.mkdir(temp_dir_path, { recursive: true })
         }
@@ -547,11 +553,14 @@ export const invoke_agentic_cli = async (params: {
         return undefined
       }
 
-      const temp_prompt_path = path.join(
-        os.tmpdir(),
-        `cwc-prompt-${Date.now()}-${Math.floor(Math.random() * 1000)}.md`
+      const temp_prompt_dir = await fs.promises.mkdtemp(
+        path.join(os.tmpdir(), 'cwc-prompt-')
       )
-      await fs.promises.writeFile(temp_prompt_path, final_prompt, 'utf-8')
+      const temp_prompt_path = path.join(temp_prompt_dir, 'prompt.md')
+      await fs.promises.writeFile(temp_prompt_path, final_prompt, {
+        encoding: 'utf-8',
+        mode: 0o600
+      })
 
       if (execution_mode === 'interactive-terminal') {
         const base_args = agent_info.get_integrated_terminal_args
@@ -598,6 +607,12 @@ export const invoke_agentic_cli = async (params: {
           terminal.sendText(post_command_args)
         }
 
+        setTimeout(() => {
+          fs.promises
+            .rm(temp_prompt_dir, { recursive: true, force: true })
+            .catch(() => {})
+        }, 10000)
+
         return { agent_output: '', selected_root: selected_root! }
       }
 
@@ -785,6 +800,10 @@ export const invoke_agentic_cli = async (params: {
         )
         go_back_to_caller = true
         break
+      } finally {
+        await fs.promises
+          .rm(temp_prompt_dir, { recursive: true, force: true })
+          .catch(() => {})
       }
 
       if (cancelled_count === invocation_count) {

apps/editor/src/views/prompt/backend/message-handlers/handle-open-prompt-image.ts

@@ -9,6 +9,9 @@ export const handle_open_prompt_image = async (
 ) => {
   try {
     const hash = message.hash
+    if (!/^[a-fA-F0-9]{16,64}$/.test(hash)) {
+      throw new Error('Invalid image hash')
+    }
     const txt_filename = `cwc-image-${hash}.txt`
     const txt_path = path.join(os.tmpdir(), txt_filename)
 
@@ -29,10 +32,13 @@ export const handle_open_prompt_image = async (
     const buffer = Buffer.from(content_base64, 'base64')
 
     // Create a png file for viewing
+    const png_dir = await fs.promises.mkdtemp(
+      path.join(os.tmpdir(), 'cwc-image-')
+    )
     const png_filename = `cwc-image-${hash}.png`
-    const png_path = path.join(os.tmpdir(), png_filename)
+    const png_path = path.join(png_dir, png_filename)
 
-    await fs.promises.writeFile(png_path, buffer)
+    await fs.promises.writeFile(png_path, buffer, { mode: 0o600 })
 
     // Open the image
     const uri = vscode.Uri.file(png_path)

apps/editor/src/views/prompt/backend/message-handlers/handle-save-prompt-image.ts

@@ -12,7 +12,11 @@ export const handle_save_prompt_image = async (
 ) => {
   try {
     const buffer = Buffer.from(message.content_base64, 'base64')
-    const hash = crypto.createHash('md5').update(buffer).digest('hex')
+    const hash = crypto
+      .createHash('sha256')
+      .update(buffer)
+      .digest('hex')
+      .substring(0, 16)
     const filename = `cwc-image-${hash}.txt`
     const file_path = path.join(os.tmpdir(), filename)
     await fs.promises.writeFile(file_path, message.content_base64, 'utf-8')

apps/editor/src/views/prompt/backend/utils/persistent-text-storage.ts

@@ -40,12 +40,18 @@ export class PersistentTextStorage {
   }
 
   async load(id: string): Promise<string> {
+    if (!/^[a-fA-F0-9]{16,64}$/.test(id)) {
+      throw new Error('Invalid storage ID')
+    }
     const filename = `${id}.txt`
     const file_path = path.join(this.dir_path, filename)
     return await fs.promises.readFile(file_path, 'utf-8')
   }
 
   get_file_path(id: string): string {
+    if (!/^[a-fA-F0-9]{16,64}$/.test(id)) {
+      throw new Error('Invalid storage ID')
+    }
     const filename = `${id}.txt`
     return path.join(this.dir_path, filename)
   }

apps/editor/src/views/prompt/backend/utils/preview-text-in-temp-file.ts

@@ -1,4 +1,3 @@
-import * as crypto from 'crypto'
 import * as fs from 'fs'
 import * as os from 'os'
 import * as path from 'path'
@@ -10,18 +9,27 @@ export const preview_text_in_temp_file = async (params: {
   content: string
   extension?: string
 }): Promise<void> => {
-  const hash = crypto
-    .createHash('md5')
-    .update(`${Date.now()}-${Math.random()}`)
-    .digest('hex')
   const ext = params.extension || '.txt'
-  const temp_file_path = path.join(
-    os.tmpdir(),
-    `${params.prefix}-${hash}${ext}`
-  )
+  let temp_dir_path: string
 
   try {
-    await fs.promises.writeFile(temp_file_path, params.content, 'utf8')
+    temp_dir_path = await fs.promises.mkdtemp(
+      path.join(os.tmpdir(), 'cwc-preview-')
+    )
+  } catch (error) {
+    vscode.window.showErrorMessage(
+      'Failed to create temporary directory for preview.'
+    )
+    return
+  }
+
+  const temp_file_path = path.join(temp_dir_path, `${params.prefix}${ext}`)
+
+  try {
+    await fs.promises.writeFile(temp_file_path, params.content, {
+      encoding: 'utf8',
+      mode: 0o600
+    })
   } catch (error) {
     vscode.window.showErrorMessage(
       'Failed to create temporary file for preview.'