Refactor preset options handling by consolidating URL override option disabling logic directly into EditPresetForm.tsx and removing specialized chatbot option components and hooks

Author: robertpiosik

packages/shared/src/constants/chatbots.ts

@@ -8,6 +8,7 @@ type Chatbot = {
   supports_thinking_budget?: boolean
   supports_url_override?: boolean
   url_override_label?: string
+  url_override_disabled_options?: string[]
   default_system_instructions?: string
   default_top_p?: number
   supported_options?: {
@@ -65,6 +66,7 @@ export const CHATBOTS = {
     url: 'https://chatgpt.com/',
     supports_url_override: true,
     url_override_label: 'Project URL',
+    url_override_disabled_options: ['temporary'],
     supported_options: {
       temporary: 'Temporary',
       thinking: 'Thinking (free plans)'
@@ -151,6 +153,7 @@ export const CHATBOTS = {
     url: 'https://chat.mistral.ai/chat',
     supports_url_override: true,
     url_override_label: 'Project URL',
+    url_override_disabled_options: ['incognito'],
     supported_options: {
       incognito: 'Incognito mode',
       think: 'Think'

packages/vscode/src/views/panel/frontend/components/edit-preset-form/EditPresetForm/EditPresetForm.module.scss

@@ -11,3 +11,4 @@
   align-items: flex-start;
   gap: 4px;
 }
+

packages/vscode/src/views/panel/frontend/components/edit-preset-form/EditPresetForm/EditPresetForm.tsx

@@ -1,6 +1,5 @@
 import { useState, useEffect, useRef, useMemo } from 'react'
 import cn from 'classnames'
-import { useChatgpt } from '../chatbot-hooks'
 import styles from './EditPresetForm.module.scss'
 import dropdown_styles from '@ui/components/editor/common/Dropdown/Dropdown.module.scss'
 import { Preset } from '@shared/types/preset'
@@ -11,8 +10,8 @@ import { Input } from '@ui/components/editor/common/Input'
 import { Textarea } from '@ui/components/editor/common/Textarea'
 import { Dropdown } from '@ui/components/editor/common/Dropdown'
 import { BackendMessage } from '@/views/panel/types/messages'
+import { PresetOption } from '@ui/components/editor/panel/PresetOption'
 import { Scrollable } from '@ui/components/editor/panel/Scrollable'
-import { Options } from '../chatbot-overrides/options'
 
 type Props = {
   preset: Preset
@@ -81,7 +80,18 @@ export const EditPresetForm: React.FC<Props> = (props) => {
     }
   }, [model_info])
 
-  useChatgpt({ chatbot, new_url, set_options })
+  useEffect(() => {
+    if (!chatbot) return
+    const chatbot_config = CHATBOTS[chatbot]
+
+    if (new_url && chatbot_config.url_override_disabled_options) {
+      set_options((prev) =>
+        prev.filter(
+          (o) => !chatbot_config.url_override_disabled_options!.includes(o)
+        )
+      )
+    }
+  }, [chatbot, new_url])
 
   const supports_temperature = chatbot_config?.supports_custom_temperature
   const supports_top_p = chatbot_config?.default_top_p !== undefined
@@ -353,13 +363,43 @@ export const EditPresetForm: React.FC<Props> = (props) => {
           </Field>
         )}
 
-        <Options
-          chatbot={chatbot}
-          model={model}
-          options={options}
-          new_url={new_url}
-          on_option_toggle={handle_option_toggle}
-        />
+        {chatbot &&
+          Object.keys(chatbot_config?.supported_options || {}).length > 0 && (
+            <Field label="Options">
+              <div className={styles.options}>
+                {Object.entries(chatbot_config!.supported_options!).map(
+                  ([key, label]) => {
+                    const is_disabled_by_url_override =
+                      !!new_url &&
+                      chatbot_config!.url_override_disabled_options?.includes(
+                        key
+                      )
+
+                    if (model_info?.disabled_options?.includes(key)) {
+                      return null
+                    }
+                    return (
+                      <PresetOption
+                        key={key}
+                        label={label as string}
+                        checked={options.includes(key)}
+                        on_change={() => handle_option_toggle(key)}
+                        disabled={is_disabled_by_url_override}
+                        disabled_reason={
+                          is_disabled_by_url_override
+                            ? `Not supported with ${
+                                chatbot_config!.url_override_label ||
+                                'Custom URL'
+                              }`
+                            : undefined
+                        }
+                      />
+                    )
+                  }
+                )}
+              </div>
+            </Field>
+          )}
 
         {supports_temperature && (
           <Field