Skip to content

Commit beac5fe

Browse files
robertpiosikrobertpiosik
committed
Integrate find relevant files functionality into the search files for context command and remove the dedicated command
- current behavior: user can search for phrase only. Expected behavior: user can search for comma separated keywords as well. In order to implement this, show a quick pick 'Search Modes' and ask whether use 'Phrase', or 'Keywords'. The keyword search works like phrase search but narrows down results so that a file contains all listed keywords. - the 'search mode' quick pick should not be persistent (outside click should close it), should also have close button in top right corner - don't allow outside-click closing when showing the input field while allowing this behavior on the very first mode-selection quick pick - simplify 'enter comma-separated keywords to search for in files' to 'enter comma-separated keywords' - 'phase' description is too short compared to the other one - while leaving 'find relevant files' command untouched, copy its behavior to 'search files for context' as "Intelligent" (description: "Search for files using natural language") - 'search files for context' command should not import anything from 'find relevant files' command. This task should create code duplication. - remove 'find relevant files' command and its translations
1 parent bf56f81 commit beac5fe

37 files changed

Lines changed: 724 additions & 668 deletions

‎apps/editor/package.json‎

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -323,11 +323,6 @@
323323
"title": "%codeWebChat.searchFilesForContext.title%",
324324
"category": "Code Web Chat"
325325
},
326-
{
327-
"command": "codeWebChat.findRelevantFiles",
328-
"title": "%codeWebChat.findRelevantFiles.title%",
329-
"category": "Code Web Chat"
330-
},
331326
{
332327
"command": "codeWebChat.selectReferencingFiles",
333328
"title": "%codeWebChat.selectReferencingFiles.title%",
@@ -518,10 +513,6 @@
518513
"command": "codeWebChat.searchFilesForContextFromDirectory",
519514
"when": "false"
520515
},
521-
{
522-
"command": "codeWebChat.findRelevantFiles",
523-
"when": "false"
524-
},
525516
{
526517
"command": "codeWebChat.searchFilesForContextFromFile",
527518
"when": "false"
@@ -767,15 +758,10 @@
767758
"when": "(view == codeWebChatViewWorkspace || view == codeWebChatViewContext) && (viewItem == directory || viewItem == workspaceRoot || viewItem == contextDirectory || viewItem == contextWorkspaceRoot)",
768759
"group": "1_modification@6"
769760
},
770-
{
771-
"command": "codeWebChat.findRelevantFiles",
772-
"when": "(view == codeWebChatViewWorkspace || view == codeWebChatViewContext) && (viewItem == directory || viewItem == workspaceRoot || viewItem == contextDirectory || viewItem == contextWorkspaceRoot)",
773-
"group": "1_modification@7"
774-
},
775761
{
776762
"command": "codeWebChat.setRanges",
777763
"when": "(view == codeWebChatViewWorkspace || view == codeWebChatViewContext) && viewItem == file",
778-
"group": "1_modification@8"
764+
"group": "1_modification@7"
779765
},
780766
{
781767
"command": "codeWebChat.findInFolder",

‎apps/editor/package.nls.bg.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Задай диапазони...",
4343
"codeWebChat.searchFilesForContext.title": "Търси файлове за контекста...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Търси файлове за контекста...",
45-
"codeWebChat.findRelevantFiles.title": "Намери подходящи файлове...",
4645
"codeWebChat.selectReferencingFiles.title": "Избери рефериращите файлове...",
4746
"codeWebChat.selectDefinitionFile.title": "Изберете файл с дефиниция",
4847
"codeWebChat.openInIntegratedTerminal.title": "Отвори във вградения терминал",

‎apps/editor/package.nls.cs.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Nastavit rozsahy...",
4343
"codeWebChat.searchFilesForContext.title": "Hledat soubory pro kontext...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Hledat soubory pro kontext...",
45-
"codeWebChat.findRelevantFiles.title": "Najít relevantní soubory...",
4645
"codeWebChat.selectReferencingFiles.title": "Vybrat odkazující soubory...",
4746
"codeWebChat.selectDefinitionFile.title": "Vybrat soubor definice",
4847
"codeWebChat.openInIntegratedTerminal.title": "Otevřít v integrovaném terminálu",

‎apps/editor/package.nls.de.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Bereiche festlegen...",
4343
"codeWebChat.searchFilesForContext.title": "Dateien für Kontext suchen...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Dateien für Kontext suchen...",
45-
"codeWebChat.findRelevantFiles.title": "Relevante Dateien finden...",
4645
"codeWebChat.selectReferencingFiles.title": "Referenzierende Dateien auswählen...",
4746
"codeWebChat.selectDefinitionFile.title": "Definitionsdatei auswählen",
4847
"codeWebChat.openInIntegratedTerminal.title": "In integriertem Terminal öffnen",

‎apps/editor/package.nls.es.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Establecer rangos...",
4343
"codeWebChat.searchFilesForContext.title": "Buscar archivos para el contexto...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Buscar archivos para el contexto...",
45-
"codeWebChat.findRelevantFiles.title": "Encontrar archivos relevantes...",
4645
"codeWebChat.selectReferencingFiles.title": "Seleccionar archivos que referencian...",
4746
"codeWebChat.selectDefinitionFile.title": "Seleccionar archivo de definición",
4847
"codeWebChat.openInIntegratedTerminal.title": "Abrir en terminal integrado",

‎apps/editor/package.nls.fr.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Définir les plages...",
4343
"codeWebChat.searchFilesForContext.title": "Rechercher des fichiers pour le contexte...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Rechercher des fichiers pour le contexte...",
45-
"codeWebChat.findRelevantFiles.title": "Trouver des fichiers pertinents...",
4645
"codeWebChat.selectReferencingFiles.title": "Sélectionner les fichiers de référence...",
4746
"codeWebChat.selectDefinitionFile.title": "Sélectionner le fichier de définition",
4847
"codeWebChat.openInIntegratedTerminal.title": "Ouvrir dans le terminal intégré",

‎apps/editor/package.nls.hu.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Tartományok beállítása...",
4343
"codeWebChat.searchFilesForContext.title": "Fájlok keresése a kontextushoz...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Fájlok keresése a kontextushoz...",
45-
"codeWebChat.findRelevantFiles.title": "Releváns fájlok keresése...",
4645
"codeWebChat.selectReferencingFiles.title": "Hivatkozó fájlok kiválasztása...",
4746
"codeWebChat.selectDefinitionFile.title": "Definíciós fájl kiválasztása",
4847
"codeWebChat.openInIntegratedTerminal.title": "Megnyitás az integrált terminálban",

‎apps/editor/package.nls.it.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Imposta intervalli...",
4343
"codeWebChat.searchFilesForContext.title": "Cerca file per il contesto...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Cerca file per il contesto...",
45-
"codeWebChat.findRelevantFiles.title": "Trova file rilevanti...",
4645
"codeWebChat.selectReferencingFiles.title": "Seleziona i file di riferimento...",
4746
"codeWebChat.selectDefinitionFile.title": "Seleziona file di definizione",
4847
"codeWebChat.openInIntegratedTerminal.title": "Apri nel terminale integrato",

‎apps/editor/package.nls.ja.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "範囲を設定...",
4343
"codeWebChat.searchFilesForContext.title": "コンテキストのファイルを検索...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "コンテキストのファイルを検索...",
45-
"codeWebChat.findRelevantFiles.title": "関連するファイルを検索...",
4645
"codeWebChat.selectReferencingFiles.title": "参照しているファイルを選択...",
4746
"codeWebChat.selectDefinitionFile.title": "定義ファイルを選択",
4847
"codeWebChat.openInIntegratedTerminal.title": "統合ターミナルで開く",

‎apps/editor/package.nls.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"codeWebChat.setRanges.title": "Set Ranges...",
4343
"codeWebChat.searchFilesForContext.title": "Search Files for Context...",
4444
"codeWebChat.searchFilesForContextFromDirectory.title": "Search Files for Context...",
45-
"codeWebChat.findRelevantFiles.title": "Find Relevant Files...",
4645
"codeWebChat.selectReferencingFiles.title": "Select Referencing Files...",
4746
"codeWebChat.selectDefinitionFile.title": "Select Definition File",
4847
"codeWebChat.openInIntegratedTerminal.title": "Open in Integrated Terminal",

0 commit comments

Comments
 (0)