Skip to content

Commit c06b813

Browse files
committed
Update quick picks and input boxes to trigger back navigation when dismissed
- 'esc' key should work as 'back' ├── apps │ └── editor │ └── src │ ├── commands │ │ ├── apply-response-command │ │ │ └── utils │ │ │ └── preview │ │ │ ├── index.ts │ │ │ └── vscode-ui.ts │ │ └── generate-commit-message-commands │ │ ├── actions │ │ │ ├── get-prompt-data.ts │ │ │ └── run-generate-action.ts │ │ ├── generate-commit-message-commands.ts │ │ ├── index.ts │ │ └── utils │ │ ├── build-commit-message-prompt.ts │ │ ├── generate-commit-message-with-api.ts │ │ ├── get-commit-message-config.ts │ │ └── strip-wrapping-quotes.ts │ ├── constants │ │ ├── instructions.ts │ │ ├── state-keys.ts │ │ └── values.ts │ ├── context │ │ └── providers │ │ └── workspace │ │ └── workspace-provider.ts │ ├── features │ │ └── checkpoints │ │ └── actions │ │ ├── create-checkpoint.ts │ │ └── index.ts │ ├── i18n │ │ └── index.ts │ ├── services │ │ ├── providers-manager.ts │ │ └── websocket-manager.ts │ ├── utils │ │ ├── apply-reasoning-effort.ts │ │ ├── ascii-tree │ │ │ ├── ascii-tree.ts │ │ │ └── index.ts │ │ ├── commit-message-details.ts │ │ ├── files-collector.ts │ │ ├── git-repository-utils.ts │ │ ├── normalize-path.ts │ │ ├── prompt-builder.ts │ │ ├── send-llm-message.ts │ │ ├── show-configurations-quick-pick.ts │ │ ├── show-no-configurations-warning.ts │ │ └── web-configuration-format-converters.ts │ └── views │ └── prompt │ └── backend │ └── prompt-view-provider.ts └── packages └── shared └── src ├── constants │ └── dictionary.ts └── utils ├── display-token-count.ts └── logger.ts
1 parent 2ee3b4c commit c06b813

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

‎apps/editor/src/commands/generate-commit-message-commands/actions/run-generate-action.ts‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ export const run_generate_action = async (params: {
198198

199199
quick_pick.onDidHide(() => {
200200
if (!is_resolved) {
201-
resolve(undefined)
201+
resolve(show_back_button ? 'back' : undefined)
202202
}
203203
quick_pick.dispose()
204204
})
@@ -329,7 +329,7 @@ export const run_generate_action = async (params: {
329329

330330
quick_pick.onDidHide(() => {
331331
if (!is_resolved) {
332-
resolve(undefined)
332+
resolve('back')
333333
}
334334
quick_pick.dispose()
335335
})
@@ -655,7 +655,7 @@ export const run_generate_action = async (params: {
655655

656656
quick_pick.onDidHide(() => {
657657
if (!is_resolved) {
658-
resolve(undefined)
658+
resolve(show_back_button ? 'back' : undefined)
659659
}
660660
quick_pick.dispose()
661661
})
@@ -757,7 +757,7 @@ export const run_generate_action = async (params: {
757757

758758
input_box.onDidHide(() => {
759759
if (!is_resolved) {
760-
resolve(undefined)
760+
resolve(params.provided_text !== undefined ? undefined : 'back')
761761
}
762762
input_box.dispose()
763763
})
@@ -828,7 +828,11 @@ export const run_generate_action = async (params: {
828828

829829
quick_pick.onDidHide(() => {
830830
if (!is_resolved) {
831-
resolve(undefined)
831+
resolve(
832+
params.provided_text !== undefined && !params.should_commit
833+
? undefined
834+
: 'back'
835+
)
832836
}
833837
quick_pick.dispose()
834838
})

‎apps/editor/src/utils/show-configurations-quick-pick.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ export const show_configurations_quick_pick = async <T>(
209209
quick_pick.onDidHide(() => {
210210
quick_pick.dispose()
211211
if (!resolved) {
212-
resolve(undefined)
212+
resolve(show_back_button ? 'back' : undefined)
213213
}
214214
})
215215

0 commit comments

Comments
 (0)