Refactor default configuration handlers into a unified implementation with type-based routing

Author: robertpiosik

packages/vscode/src/views/settings/backend/message-handlers/handle-set-default-code-completions-configuration.ts

@@ -0,0 +1,59 @@
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import {
+  ModelProvidersManager,
+  get_tool_config_id,
+  ToolConfig
+} from '@/services/model-providers-manager'
+
+export const handle_set_default_configuration = async (
+  provider: SettingsProvider,
+  configuration_id: string | null,
+  type:
+    | 'code-completions'
+    | 'intelligent-update'
+    | 'commit-messages'
+    | 'prune-context'
+): Promise<void> => {
+  const providers_manager = new ModelProvidersManager(provider.context)
+
+  let get_configs: () => Promise<ToolConfig[]>
+  let set_default_config: (config: ToolConfig | null) => Promise<void>
+
+  switch (type) {
+    case 'code-completions':
+      get_configs = () => providers_manager.get_code_completions_tool_configs()
+      set_default_config = (c) =>
+        providers_manager.set_default_code_completions_config(c)
+      break
+    case 'intelligent-update':
+      get_configs = () =>
+        providers_manager.get_intelligent_update_tool_configs()
+      set_default_config = (c) =>
+        providers_manager.set_default_intelligent_update_config(c)
+      break
+    case 'commit-messages':
+      get_configs = () => providers_manager.get_commit_messages_tool_configs()
+      set_default_config = (c) =>
+        providers_manager.set_default_commit_messages_config(c)
+      break
+    case 'prune-context':
+      get_configs = () => providers_manager.get_prune_context_tool_configs()
+      set_default_config = (c) =>
+        providers_manager.set_default_prune_context_config(c)
+      break
+  }
+
+  if (configuration_id === null) {
+    await set_default_config(null)
+    return
+  }
+
+  const configs = await get_configs()
+  const config_to_set_as_default = configs.find(
+    (c) => get_tool_config_id(c) === configuration_id
+  )
+
+  if (config_to_set_as_default) {
+    await set_default_config(config_to_set_as_default)
+  }
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-set-default-commit-messages-configuration.ts

@@ -5,13 +5,11 @@ export * from './handle-delete-model-provider'
 export * from './handle-edit-custom-model-provider'
 export * from './handle-edit-model-provider-key'
 export * from './handle-reorder-configuration'
-export * from './handle-set-default-code-completions-configuration'
-export * from './handle-set-default-commit-messages-configuration'
+export * from './handle-set-default-configuration'
 export * from './handle-get-edit-context-system-instructions'
 export * from './handle-update-edit-context-system-instructions'
 export * from './handle-get-edit-format-instructions'
 export * from './handle-update-edit-format-instructions'
-export * from './handle-set-default-intelligent-update-configuration'
 export * from './handle-get-commit-message-instructions'
 export * from './handle-update-commit-message-instructions'
 export * from './handle-get-commit-message-auto-accept-after'

packages/vscode/src/views/settings/backend/message-handlers/handle-set-default-configuration.ts

@@ -25,9 +25,7 @@ import {
   handle_get_checkpoint_lifespan,
   handle_reorder_configuration,
   handle_reorder_model_providers,
-  handle_set_default_code_completions_configuration,
-  handle_set_default_commit_messages_configuration,
-  handle_set_default_intelligent_update_configuration,
+  handle_set_default_configuration,
   handle_update_check_new_files,
   handle_update_clear_checks_in_workspace_behavior,
   handle_update_are_automatic_checkpoints_disabled,
@@ -133,7 +131,11 @@ export class SettingsProvider {
         } else if (
           message.command == 'SET_DEFAULT_CODE_COMPLETIONS_CONFIGURATION'
         ) {
-          await handle_set_default_code_completions_configuration(this, message)
+          await handle_set_default_configuration(
+            this,
+            message.configuration_id,
+            'code-completions'
+          )
         } else if (message.command == 'GET_EDIT_CONTEXT_CONFIGURATIONS') {
           await handle_get_configurations(this, 'edit-context')
         } else if (message.command == 'REORDER_EDIT_CONTEXT_CONFIGURATIONS') {
@@ -179,9 +181,10 @@ export class SettingsProvider {
         } else if (
           message.command == 'SET_DEFAULT_INTELLIGENT_UPDATE_CONFIGURATION'
         ) {
-          await handle_set_default_intelligent_update_configuration(
+          await handle_set_default_configuration(
             this,
-            message
+            message.configuration_id,
+            'intelligent-update'
           )
         } else if (message.command == 'GET_PRUNE_CONTEXT_CONFIGURATIONS') {
           await handle_get_configurations(this, 'prune-context')
@@ -216,7 +219,11 @@ export class SettingsProvider {
         } else if (
           message.command == 'SET_DEFAULT_COMMIT_MESSAGES_CONFIGURATION'
         ) {
-          await handle_set_default_commit_messages_configuration(this, message)
+          await handle_set_default_configuration(
+            this,
+            message.configuration_id,
+            'commit-messages'
+          )
         } else if (message.command == 'GET_COMMIT_MESSAGE_INSTRUCTIONS') {
           await handle_get_commit_message_instructions(this)
         } else if (message.command == 'UPDATE_COMMIT_MESSAGE_INSTRUCTIONS') {