Normalize comparison operators across the repository and refine ghost text behavior in the prompt field

Author: robertpiosik

packages/browser/src/background/message-handler.ts

@@ -156,7 +156,7 @@ const handle_get_tab_data = async (
     let html = ''
 
     // (Firefox uses browserAction, Chrome uses action)
-    const is_firefox = typeof browser.browserAction !== 'undefined'
+    const is_firefox = typeof browser.browserAction != 'undefined'
 
     if (is_firefox && tab.id) {
       // Firefox: Use the older tabs.executeScript API (MV2 style)

packages/browser/src/utils/is-message.ts

@@ -1,5 +1,5 @@
 import { Message } from '@/types/messages'
 
 export function is_message(obj: any): obj is Message {
-  return obj && typeof obj.action === 'string'
+  return obj && typeof obj.action == 'string'
 }

packages/ui/src/components/editor/panel/PromptField/PromptField.tsx

@@ -344,7 +344,23 @@ export const PromptField: React.FC<PromptFieldProps> = (props) => {
             handle_input_change(e)
           }}
           onKeyDown={(e) => {
-            set_should_show_ghost_text(true)
+            if (e.key == 'ArrowRight') {
+              set_should_show_ghost_text(false)
+              const ghost_text_node = input_ref.current?.querySelector(
+                'span[data-type="ghost-text"]'
+              )
+              if (ghost_text_node && !e.ctrlKey && !e.altKey && !e.metaKey) {
+                ghost_text_node.remove()
+                e.preventDefault()
+                const selection = window.getSelection()
+                if (selection) {
+                  const type = e.shiftKey ? 'extend' : 'move'
+                  selection.modify(type, 'forward', 'character')
+                }
+              }
+            } else {
+              set_should_show_ghost_text(true)
+            }
             handle_key_down(e)
           }}
           onCopy={handle_copy}
@@ -432,10 +448,10 @@ export const PromptField: React.FC<PromptFieldProps> = (props) => {
                 {(['whole', 'truncated', 'before-after', 'diff'] as const).map(
                   (format, index) => {
                     const is_compact =
-                      (format === 'before-after' && compact_step >= 1) ||
-                      (format === 'truncated' && compact_step >= 2) ||
-                      (format === 'whole' && compact_step >= 3) ||
-                      (format === 'diff' && compact_step >= 4)
+                      (format == 'before-after' && compact_step >= 1) ||
+                      (format == 'truncated' && compact_step >= 2) ||
+                      (format == 'whole' && compact_step >= 3) ||
+                      (format == 'diff' && compact_step >= 4)
 
                     const button_text = is_compact
                       ? format == 'before-after'
@@ -449,10 +465,10 @@ export const PromptField: React.FC<PromptFieldProps> = (props) => {
                     const should_underline = is_alt_pressed && !is_selected
 
                     let ref = null
-                    if (format === 'whole') ref = format_whole_ref
-                    if (format === 'truncated') ref = format_truncated_ref
-                    if (format === 'before-after') ref = format_before_after_ref
-                    if (format === 'diff') ref = format_diff_ref
+                    if (format == 'whole') ref = format_whole_ref
+                    if (format == 'truncated') ref = format_truncated_ref
+                    if (format == 'before-after') ref = format_before_after_ref
+                    if (format == 'diff') ref = format_diff_ref
 
                     return (
                       <button

packages/ui/src/components/editor/panel/PromptField/hooks/use-ghost-text.ts

@@ -69,7 +69,7 @@ export const use_ghost_text = ({
           post_caret_range.setStart(range.endContainer, range.endOffset)
           const text_after_cursor = post_caret_range.toString()
 
-          if (text_after_cursor === '' || /^\s/.test(text_after_cursor)) {
+          if (text_after_cursor == '' || /^\s/.test(text_after_cursor)) {
             const pre_caret_range = range.cloneRange()
             pre_caret_range.selectNodeContents(input_ref.current)
             pre_caret_range.setEnd(range.startContainer, range.startOffset)
@@ -164,15 +164,41 @@ export const use_ghost_text = ({
     )
     if (ghost_node) {
       const text_node = document.createTextNode(ghost_node.textContent || '')
-      ghost_node.parentNode?.replaceChild(text_node, ghost_node)
+      const parent_node = ghost_node.parentNode
+
+      if (parent_node) {
+        parent_node.replaceChild(text_node, ghost_node)
+
+        let next_sibling = text_node.nextSibling
+        let space_added = false
+
+        if (
+          !next_sibling ||
+          next_sibling.nodeType !== Node.TEXT_NODE ||
+          !next_sibling.textContent?.startsWith(' ')
+        ) {
+          const space_node = document.createTextNode(' ')
+          if (next_sibling) {
+            parent_node.insertBefore(space_node, next_sibling)
+          } else {
+            parent_node.appendChild(space_node)
+          }
+          next_sibling = space_node
+          space_added = true
+        }
 
-      const selection = window.getSelection()
-      if (selection) {
-        const range = document.createRange()
-        range.setStartAfter(text_node)
-        range.collapse(true)
-        selection.removeAllRanges()
-        selection.addRange(range)
+        const selection = window.getSelection()
+        if (selection) {
+          const range = document.createRange()
+          if (space_added) {
+            range.setStartAfter(next_sibling!)
+          } else {
+            range.setStart(next_sibling!, 1)
+          }
+          range.collapse(true)
+          selection.removeAllRanges()
+          selection.addRange(range)
+        }
       }
 
       input_ref.current.dispatchEvent(

packages/ui/src/components/editor/panel/PromptField/hooks/use-handlers.ts

@@ -222,13 +222,13 @@ export const use_handlers = (
 
     const new_value = leading_part + trailing_part
     const new_raw_cursor_pos = leading_part.length
-    has_modified_current_entry_ref.current = new_value !== ''
+    has_modified_current_entry_ref.current = new_value != ''
     update_value(new_value, new_raw_cursor_pos)
   }
 
   const handle_keyword_deletion_by_click = (keyword_element: HTMLElement) => {
     const keyword_type = keyword_element.dataset.type
-    if (keyword_type === 'file-keyword') {
+    if (keyword_type == 'file-keyword') {
       const file_path = keyword_element.dataset.path
       if (!file_path || !props.context_file_paths?.includes(file_path)) return
 
@@ -238,7 +238,7 @@ export const use_handlers = (
       if (start_index !== -1) {
         apply_keyword_deletion(start_index, start_index + search_pattern.length)
       }
-    } else if (keyword_type === 'changes-keyword') {
+    } else if (keyword_type == 'changes-keyword') {
       const branch_name = keyword_element.dataset.branchName
       if (!branch_name) return
 
@@ -248,7 +248,7 @@ export const use_handlers = (
       if (start_index !== -1) {
         apply_keyword_deletion(start_index, start_index + search_pattern.length)
       }
-    } else if (keyword_type === 'saved-context-keyword') {
+    } else if (keyword_type == 'saved-context-keyword') {
       const context_type = keyword_element.dataset.contextType
       const context_name = keyword_element.dataset.contextName
       if (!context_type || !context_name) return
@@ -259,14 +259,14 @@ export const use_handlers = (
       if (start_index !== -1) {
         apply_keyword_deletion(start_index, start_index + search_pattern.length)
       }
-    } else if (keyword_type === 'selection-keyword') {
+    } else if (keyword_type == 'selection-keyword') {
       const search_pattern = '#Selection'
       const start_index = props.value.indexOf(search_pattern)
 
       if (start_index !== -1) {
         apply_keyword_deletion(start_index, start_index + search_pattern.length)
       }
-    } else if (keyword_type === 'commit-keyword') {
+    } else if (keyword_type == 'commit-keyword') {
       const repo_name = keyword_element.dataset.repoName
       const commit_hash = keyword_element.dataset.commitHash
       const commit_message = keyword_element.dataset.commitMessage
@@ -278,7 +278,7 @@ export const use_handlers = (
       if (start_index !== -1) {
         apply_keyword_deletion(start_index, start_index + search_pattern.length)
       }
-    } else if (keyword_type === 'contextatcommit-keyword') {
+    } else if (keyword_type == 'contextatcommit-keyword') {
       const repo_name = keyword_element.dataset.repoName
       const commit_hash = keyword_element.dataset.commitHash
       const commit_message = keyword_element.dataset.commitMessage
@@ -378,7 +378,7 @@ export const use_handlers = (
     const caret_position = get_caret_position_from_div(currentTarget)
     const char_before_caret = new_display_value.charAt(caret_position - 1)
 
-    has_modified_current_entry_ref.current = new_raw_value !== ''
+    has_modified_current_entry_ref.current = new_raw_value != ''
     update_value(new_raw_value)
 
     if (char_before_caret == '@') {
@@ -430,7 +430,7 @@ export const use_handlers = (
     let start_of_path = -1
     const end_of_path = raw_pos - 1
 
-    if (end_of_path >= 0 && props.value[end_of_path] === '`') {
+    if (end_of_path >= 0 && props.value[end_of_path] == '`') {
       const text_before = props.value.substring(0, end_of_path)
       start_of_path = text_before.lastIndexOf('`')
     }
@@ -657,13 +657,13 @@ export const use_handlers = (
       update_value(value, value.length)
     }
 
-    if (e.key === 'ArrowUp') {
+    if (e.key == 'ArrowUp') {
       if (history_index < active_history.length - 1) {
         const new_index = history_index + 1
         set_history_index(new_index)
         update_and_set_caret(active_history[new_index])
       }
-    } else if (e.key === 'ArrowDown') {
+    } else if (e.key == 'ArrowDown') {
       if (history_index > 0) {
         const new_index = history_index - 1
         set_history_index(new_index)
@@ -869,7 +869,7 @@ export const use_handlers = (
         const new_start_pos = i + 1
         const new_value =
           value.substring(0, new_start_pos) + value.substring(raw_pos)
-        has_modified_current_entry_ref.current = new_value !== ''
+        has_modified_current_entry_ref.current = new_value != ''
         update_value(new_value, new_start_pos)
         return
       }

packages/ui/src/components/editor/panel/ResponsePreview/components/FileItem/FileItem.tsx

@@ -96,9 +96,9 @@ export const FileItem: FC<Props> = ({
           [styles['file--warning']]:
             file.diff_application_method == 'search_and_replace' &&
             !file.fixed_with_intelligent_update,
-          [styles['file--deleted']]: file.file_state === 'deleted'
+          [styles['file--deleted']]: file.file_state == 'deleted'
         })}
-        onClick={file.file_state === 'deleted' ? undefined : on_click}
+        onClick={file.file_state == 'deleted' ? undefined : on_click}
         role="button"
         title={file.file_path}
       >

packages/ui/src/components/editor/panel/Tasks/hooks/use-auto-focus-new-task.ts

@@ -33,7 +33,7 @@ export const use_auto_focus_new_task = (
 
     if (added_ids.length == 1) {
       const new_task = id_to_task.get(added_ids[0])
-      if (new_task && new_task.text === '') {
+      if (new_task && new_task.text == '') {
         set_editing_timestamp(added_ids[0])
       }
     }

packages/ui/src/components/editor/settings/ModelProviders/ModelProviders.tsx

@@ -42,7 +42,7 @@ export const ModelProviders: React.FC<ModelProviders.Props> = (props) => {
         <div className={styles['col-base-url']}>{provider.baseUrl}</div>
       </div>
       <div className={styles['col-actions']}>
-        {provider.type === 'custom' && (
+        {provider.type == 'custom' && (
           <IconButton
             codicon_icon="edit"
             on_click={() => props.on_edit_provider(provider.name)}

packages/vscode/src/commands/apply-chat-response-command/handlers/intelligent-update-handler.ts

@@ -435,7 +435,7 @@ export const handle_intelligent_update = async (params: {
       data: error
     })
 
-    if (error.message !== 'Operation cancelled' && !axios.isCancel(error)) {
+    if (error.message != 'Operation cancelled' && !axios.isCancel(error)) {
       vscode.window.showErrorMessage(
         dictionary.error_message.ERROR_DURING_PROCESSING(error.message)
       )

packages/vscode/src/commands/apply-chat-response-command/handlers/truncated-handler.ts

@@ -156,7 +156,7 @@ function process_truncated_content(
   for (let i = 0; i < blocks.length; i++) {
     const block = blocks[i]
 
-    if (block.type === 'code') {
+    if (block.type == 'code') {
       output_lines.push(...block.lines)
 
       // Try to sync with original to handle replacements (context consumption)
@@ -198,7 +198,7 @@ function process_truncated_content(
 
       if (i + 1 < blocks.length) {
         const next_block = blocks[i + 1]
-        if (next_block.type === 'code') {
+        if (next_block.type == 'code') {
           // Find where the next block starts in original
           const prefix_lines = next_block.lines.slice(0, 10)
           let found_next = false