Remove all logic and UI components related to checking the clipboard content for applicability to simplify the "APPLY" button functionality

Author: robertpiosik

packages/vscode/src/views/panel/backend/panel-provider.ts

@@ -2,7 +2,6 @@ import * as vscode from 'vscode'
 import * as path from 'path'
 import { WebSocketManager } from '@/services/websocket-manager'
 import { FrontendMessage, BackendMessage } from '../types/messages'
-import { parse_response } from '@/commands/apply-chat-response-command/utils/clipboard-parser/clipboard-parser'
 import { WebsitesProvider } from '@/context/providers/websites-provider'
 import { OpenEditorsProvider } from '@/context/providers/open-editors-provider'
 import { WorkspaceProvider } from '@/context/providers/workspace-provider'
@@ -65,7 +64,6 @@ import {
   get_last_group_or_preset_choice_state_key,
   get_last_selected_group_state_key,
   get_last_selected_preset_key,
-  LAST_APPLIED_CLIPBOARD_CONTENT_STATE_KEY,
   LAST_SELECTED_CODE_COMPLETION_CONFIG_ID_STATE_KEY,
   LAST_SELECTED_EDIT_CONTEXT_CONFIG_ID_STATE_KEY,
   RECENT_DONATIONS_VISIBLE_STATE_KEY,
@@ -158,7 +156,6 @@ export class ViewProvider implements vscode.WebviewViewProvider {
 
     vscode.window.onDidChangeWindowState(async (e) => {
       if (e.focused) {
-        await this._check_clipboard_for_apply()
         const are_donations_visible = this.context.globalState.get<boolean>(
           RECENT_DONATIONS_VISIBLE_STATE_KEY,
           false
@@ -299,50 +296,6 @@ export class ViewProvider implements vscode.WebviewViewProvider {
     this.intelligent_update_cancel_token_sources = []
   }
 
-  private async _check_clipboard_for_apply() {
-    if (!this._webview_view) return
-
-    const clipboard_text = await vscode.env.clipboard.readText()
-
-    const last_applied_content = this.context.workspaceState.get<string>(
-      LAST_APPLIED_CLIPBOARD_CONTENT_STATE_KEY
-    )
-
-    if (
-      clipboard_text.trim() &&
-      last_applied_content &&
-      clipboard_text == last_applied_content
-    ) {
-      this.send_message({
-        command: 'CAN_APPLY_CLIPBOARD_CHANGED',
-        can_apply: false
-      })
-      return
-    }
-
-    if (!clipboard_text.trim()) {
-      this.send_message({
-        command: 'CAN_APPLY_CLIPBOARD_CHANGED',
-        can_apply: false
-      })
-      return
-    }
-
-    const is_single_root_folder_workspace =
-      (vscode.workspace.workspaceFolders?.length ?? 0) <= 1
-    const content = parse_response({
-      response: clipboard_text,
-      is_single_root_folder_workspace
-    })
-    const can_apply =
-      content.code_completion != null ||
-      (content.patches && content.patches.length > 0) ||
-      (content.files && content.files.length > 0) ||
-      false
-
-    this.send_message({ command: 'CAN_APPLY_CLIPBOARD_CHANGED', can_apply })
-  }
-
   public send_message(message: BackendMessage) {
     if (this._webview_view) {
       this._webview_view.webview.postMessage(message)
@@ -466,8 +419,6 @@ export class ViewProvider implements vscode.WebviewViewProvider {
               this.context,
               message
             )
-          } else if (message.command == 'CHECK_CLIPBOARD_FOR_APPLY') {
-            await this._check_clipboard_for_apply()
           } else if (message.command == 'GET_DONATIONS_VISIBILITY') {
             handle_get_donations_visibility(this)
           } else if (message.command == 'SAVE_DONATIONS_VISIBILITY') {
@@ -784,13 +735,6 @@ export class ViewProvider implements vscode.WebviewViewProvider {
     }
   }
 
-  public set_apply_button_state = (can_apply: boolean) => {
-    this.send_message({
-      command: 'CAN_APPLY_CLIPBOARD_CHANGED',
-      can_apply
-    })
-  }
-
   public set_undo_button_state = (can_undo: boolean) => {
     this.send_message({
       command: 'CAN_UNDO_CHANGED',

packages/vscode/src/views/panel/frontend/Main/Main.tsx

@@ -73,8 +73,6 @@ export const Main: React.FC<Props> = (props) => {
   >()
   const [has_changes_to_commit, set_has_changes_to_commit] =
     useState<boolean>(false)
-  const [can_apply_clipboard, set_can_apply_clipboard] =
-    useState<boolean>(false)
   const [can_undo, set_can_undo] = useState<boolean>(false)
 
   const is_in_code_completions_mode =
@@ -138,9 +136,6 @@ export const Main: React.FC<Props> = (props) => {
         case 'GIT_STATE_CHANGED':
           set_has_changes_to_commit(message.has_changes_to_commit)
           break
-        case 'CAN_APPLY_CLIPBOARD_CHANGED':
-          set_can_apply_clipboard(message.can_apply)
-          break
         case 'CAN_UNDO_CHANGED':
           set_can_undo(message.can_undo)
           break
@@ -172,7 +167,6 @@ export const Main: React.FC<Props> = (props) => {
       { command: 'GET_EDIT_FORMAT' },
       { command: 'GET_EDIT_FORMAT_INSTRUCTIONS' },
       { command: 'GET_API_TOOL_CONFIGURATIONS' },
-      { command: 'CHECK_CLIPBOARD_FOR_APPLY' },
       { command: 'REQUEST_GIT_STATE' }
     ]
     initial_messages.forEach((message) => post_message(props.vscode, message))
@@ -619,7 +613,6 @@ export const Main: React.FC<Props> = (props) => {
       has_active_editor={props.has_active_editor}
       has_active_selection={props.has_active_selection}
       has_changes_to_commit={has_changes_to_commit}
-      can_apply_clipboard={can_apply_clipboard}
       can_undo={can_undo}
       chat_history={current_history || []}
       token_count={token_count}

packages/vscode/src/views/panel/frontend/Main/MainView/MainView.tsx

@@ -47,7 +47,6 @@ type Props = {
   has_active_editor: boolean
   has_active_selection: boolean
   has_changes_to_commit: boolean
-  can_apply_clipboard: boolean
   can_undo: boolean
   chat_history: string[]
   token_count: number
@@ -183,8 +182,6 @@ export const MainView: React.FC<Props> = (props) => {
   }
 
   const handle_apply_click = () => {
-    if (!props.can_apply_clipboard) return
-
     set_is_apply_disabled_temporarily(true)
     props.on_quick_action_click('codeWebChat.applyChatResponse')
 
@@ -208,10 +205,6 @@ export const MainView: React.FC<Props> = (props) => {
     setTimeout(() => set_is_undo_disabled_temporarily(false), 10000)
   }
 
-  useEffect(() => {
-    set_is_undo_disabled_temporarily(false)
-  }, [props.can_apply_clipboard])
-
   const handle_commit_click = () => {
     if (!props.has_changes_to_commit) return
 
@@ -447,14 +440,8 @@ export const MainView: React.FC<Props> = (props) => {
                 styles['footer__button--outlined']
               )}
               onClick={handle_apply_click}
-              title={
-                props.can_apply_clipboard
-                  ? 'Integrate copied message or a code block'
-                  : 'Nothing applicable found in clipboard'
-              }
-              disabled={
-                !props.can_apply_clipboard || is_apply_disabled_temporarily
-              }
+              title={'Integrate copied message or a code block'}
+              disabled={is_apply_disabled_temporarily}
             >
               APPLY
             </button>

packages/vscode/src/views/panel/frontend/Panel.tsx

@@ -80,12 +80,6 @@ export const Panel = () => {
   const [chat_input_focus_and_select_key, set_chat_input_focus_and_select_key] =
     useState(0)
 
-  const handle_mouse_enter = () => {
-    post_message(vscode, {
-      command: 'CHECK_CLIPBOARD_FOR_APPLY'
-    })
-  }
-
   const handle_instructions_change = (
     value: string,
     mode: 'ask' | 'edit-context' | 'no-context' | 'code-completions'
@@ -309,7 +303,7 @@ export const Panel = () => {
       (!has_active_editor || has_active_selection))
 
   return (
-    <div className={styles.container} onMouseEnter={handle_mouse_enter}>
+    <div className={styles.container}>
       <div
         className={cn(styles.slot, {
           [styles['slot--hidden']]: active_view != 'main'

packages/vscode/src/views/panel/types/messages.ts

@@ -229,10 +229,6 @@ export interface GetVersionMessage extends BaseMessage {
   command: 'GET_VERSION'
 }
 
-export interface CheckClipboardForApplyMessage extends BaseMessage {
-  command: 'CHECK_CLIPBOARD_FOR_APPLY'
-}
-
 export interface EditsReviewMessage extends BaseMessage {
   command: 'EDITS_REVIEW'
   files: FileInReview[]
@@ -346,7 +342,6 @@ export type FrontendMessage =
   | ReorderApiToolConfigurationsMessage
   | SaveDonationsVisibilityMessage
   | GetVersionMessage
-  | CheckClipboardForApplyMessage
   | EditsReviewMessage
   | ToggleFileInReviewMessage
   | FocusOnFileInReviewMessage
@@ -471,11 +466,6 @@ export interface AtSignQuickPickForPresetAffixResultMessage
   text_to_insert: string
 }
 
-export interface CanApplyClipboardChangedMessage extends BaseMessage {
-  command: 'CAN_APPLY_CLIPBOARD_CHANGED'
-  can_apply: boolean
-}
-
 export interface CanUndoChangedMessage extends BaseMessage {
   command: 'CAN_UNDO_CHANGED'
   can_undo: boolean
@@ -571,7 +561,6 @@ export type BackendMessage =
   | ApiModeMessage
   | VersionMessage
   | AtSignQuickPickForPresetAffixResultMessage
-  | CanApplyClipboardChangedMessage
   | CanUndoChangedMessage
   | CodeReviewStartedMessage
   | CodeReviewFinishedMessage