Skip to content

Commit ce6202f

Browse files
committed
Update BrowserConnectionStatus to remain visible when responses exist and refine StatusBar styling for rounded corners
1 parent fd11d56 commit ce6202f

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎apps/editor/src/views/prompt/frontend/Main/MainView/MainView.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@ export const MainView: React.FC<Props> = (props) => {
250250
{props.target == TARGET.WEB && (
251251
<BrowserConnectionStatus
252252
is_connected={props.is_connected}
253-
has_responses={props.response_history.length > 0}
254253
on_install={props.on_install_browser_extension}
255254
translations={{
256255
connected: t('main.browser-connection.connected'),
@@ -261,6 +260,8 @@ export const MainView: React.FC<Props> = (props) => {
261260
/>
262261
)}
263262

263+
<UiSeparator height={6} />
264+
264265
{props.response_history.length > 0 && (
265266
<UiResponses
266267
response_history={props.response_history}

‎apps/editor/src/views/prompt/frontend/Main/MainView/components/BrowserConnectionStatus/BrowserConnectionStatus.tsx‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { StatusBar } from '@ui/components/editor/prompt/StatusBar'
33

44
type Props = {
55
is_connected: boolean
6-
has_responses: boolean
76
translations: {
87
connected: string
98
not_connected: string
@@ -18,13 +17,10 @@ export const BrowserConnectionStatus: React.FC<Props> = (props) => {
1817
const [has_been_closed, setHasBeenClosed] = useState(false)
1918

2019
useEffect(() => {
21-
if (props.has_responses) {
22-
setIsClosed(true)
23-
setHasBeenClosed(true)
24-
} else if (!props.is_connected) {
20+
if (!props.is_connected) {
2521
setIsClosed(false)
2622
}
27-
}, [props.has_responses, props.is_connected])
23+
}, [props.is_connected])
2824

2925
useEffect(() => {
3026
if (props.is_connected && !is_closed && has_been_closed) {
@@ -35,7 +31,7 @@ export const BrowserConnectionStatus: React.FC<Props> = (props) => {
3531
}
3632
}, [props.is_connected, is_closed, has_been_closed])
3733

38-
if (is_closed || props.has_responses) {
34+
if (is_closed) {
3935
return null
4036
}
4137

@@ -63,7 +59,6 @@ export const BrowserConnectionStatus: React.FC<Props> = (props) => {
6359

6460
return (
6561
<StatusBar
66-
placement="top"
6762
theme={props.is_connected ? 'success' : 'default'}
6863
icon={
6964
props.is_connected

‎packages/ui/src/components/editor/prompt/StatusBar/StatusBar.module.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
border-bottom-right-radius: 6px;
2525
}
2626

27+
.rounded {
28+
border-radius: 6px;
29+
}
30+
2731
.theme-default {
2832
color: var(--cwc-text-color);
2933
background-color: var(--cwc-bg-tertiary);

‎packages/ui/src/components/editor/prompt/StatusBar/StatusBar.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const StatusBar: React.FC<StatusBarProps> = ({
3636
className={cn(
3737
styles.container,
3838
styles[`theme-${theme}`],
39-
placement && styles[`placement-${placement}`],
39+
placement ? styles[`placement-${placement}`] : styles.rounded,
4040
className
4141
)}
4242
>

0 commit comments

Comments
 (0)