Refactor reorder handlers into a unified configuration reordering function

Author: robertpiosik

packages/vscode/src/views/settings/backend/message-handlers/handle-reorder-code-completions-configurations.ts

@@ -0,0 +1,68 @@
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import {
+  ModelProvidersManager,
+  ToolConfig,
+  get_tool_config_id
+} from '@/services/model-providers-manager'
+
+export const handle_reorder_configuration = async (
+  provider: SettingsProvider,
+  configurations: { id: string }[],
+  type:
+    | 'code-completions'
+    | 'edit-context'
+    | 'intelligent-update'
+    | 'commit-messages'
+    | 'prune-context'
+): Promise<void> => {
+  const providers_manager = new ModelProvidersManager(provider.context)
+
+  let get_configs: () => Promise<ToolConfig[]>
+  let save_configs: (configs: ToolConfig[]) => Promise<void>
+
+  switch (type) {
+    case 'code-completions':
+      get_configs = () => providers_manager.get_code_completions_tool_configs()
+      save_configs = (c) =>
+        providers_manager.save_code_completions_tool_configs(c)
+      break
+    case 'edit-context':
+      get_configs = () => providers_manager.get_edit_context_tool_configs()
+      save_configs = (c) => providers_manager.save_edit_context_tool_configs(c)
+      break
+    case 'intelligent-update':
+      get_configs = () =>
+        providers_manager.get_intelligent_update_tool_configs()
+      save_configs = (c) =>
+        providers_manager.save_intelligent_update_tool_configs(c)
+      break
+    case 'commit-messages':
+      get_configs = () => providers_manager.get_commit_messages_tool_configs()
+      save_configs = (c) =>
+        providers_manager.save_commit_messages_tool_configs(c)
+      break
+    case 'prune-context':
+      get_configs = () => providers_manager.get_prune_context_tool_configs()
+      save_configs = (c) => providers_manager.save_prune_context_tool_configs(c)
+      break
+  }
+
+  const current_configs = await get_configs()
+
+  const reordered_ids = configurations.map((p) => p.id)
+
+  const reordered_configs = reordered_ids
+    .map((id) => {
+      const found = current_configs.find((p) => get_tool_config_id(p) == id)
+      if (!found) {
+        console.error(`Config with id ${id} not found during reorder.`)
+        return null
+      }
+      return found
+    })
+    .filter((p): p is ToolConfig => p !== null)
+
+  if (reordered_configs.length == current_configs.length) {
+    await save_configs(reordered_configs)
+  }
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-reorder-commit-messages-configurations.ts

@@ -4,18 +4,14 @@ export * from './handle-add-model-provider'
 export * from './handle-delete-model-provider'
 export * from './handle-edit-custom-model-provider'
 export * from './handle-edit-model-provider-key'
-export * from './handle-reorder-code-completions-configurations'
+export * from './handle-reorder-configuration'
 export * from './handle-set-default-code-completions-configuration'
-export * from './handle-reorder-commit-messages-configurations'
 export * from './handle-set-default-commit-messages-configuration'
-export * from './handle-reorder-edit-context-configurations'
 export * from './handle-get-edit-context-system-instructions'
 export * from './handle-update-edit-context-system-instructions'
 export * from './handle-get-edit-format-instructions'
 export * from './handle-update-edit-format-instructions'
-export * from './handle-reorder-intelligent-update-configurations'
 export * from './handle-set-default-intelligent-update-configuration'
-export * from './handle-reorder-prune-context-configurations'
 export * from './handle-get-commit-message-instructions'
 export * from './handle-update-commit-message-instructions'
 export * from './handle-get-commit-message-auto-accept-after'

packages/vscode/src/views/settings/backend/message-handlers/handle-reorder-configuration.ts

@@ -23,12 +23,8 @@ import {
   handle_get_model_providers,
   handle_get_send_with_shift_enter,
   handle_get_checkpoint_lifespan,
-  handle_reorder_code_completions_configurations,
-  handle_reorder_commit_messages_configurations,
-  handle_reorder_edit_context_configurations,
-  handle_reorder_intelligent_update_configurations,
+  handle_reorder_configuration,
   handle_reorder_model_providers,
-  handle_reorder_prune_context_configurations,
   handle_set_default_code_completions_configuration,
   handle_set_default_commit_messages_configuration,
   handle_set_default_intelligent_update_configuration,
@@ -123,7 +119,11 @@ export class SettingsProvider {
         } else if (
           message.command == 'REORDER_CODE_COMPLETIONS_CONFIGURATIONS'
         ) {
-          await handle_reorder_code_completions_configurations(this, message)
+          await handle_reorder_configuration(
+            this,
+            message.configurations,
+            'code-completions'
+          )
         } else if (message.command == 'DELETE_CODE_COMPLETIONS_CONFIGURATION') {
           await handle_delete_configuration(
             this,
@@ -137,7 +137,11 @@ export class SettingsProvider {
         } else if (message.command == 'GET_EDIT_CONTEXT_CONFIGURATIONS') {
           await handle_get_configurations(this, 'edit-context')
         } else if (message.command == 'REORDER_EDIT_CONTEXT_CONFIGURATIONS') {
-          await handle_reorder_edit_context_configurations(this, message)
+          await handle_reorder_configuration(
+            this,
+            message.configurations,
+            'edit-context'
+          )
         } else if (message.command == 'DELETE_EDIT_CONTEXT_CONFIGURATION') {
           await handle_delete_configuration(
             this,
@@ -159,7 +163,11 @@ export class SettingsProvider {
         } else if (
           message.command == 'REORDER_INTELLIGENT_UPDATE_CONFIGURATIONS'
         ) {
-          await handle_reorder_intelligent_update_configurations(this, message)
+          await handle_reorder_configuration(
+            this,
+            message.configurations,
+            'intelligent-update'
+          )
         } else if (
           message.command == 'DELETE_INTELLIGENT_UPDATE_CONFIGURATION'
         ) {
@@ -178,7 +186,11 @@ export class SettingsProvider {
         } else if (message.command == 'GET_PRUNE_CONTEXT_CONFIGURATIONS') {
           await handle_get_configurations(this, 'prune-context')
         } else if (message.command == 'REORDER_PRUNE_CONTEXT_CONFIGURATIONS') {
-          await handle_reorder_prune_context_configurations(this, message)
+          await handle_reorder_configuration(
+            this,
+            message.configurations,
+            'prune-context'
+          )
         } else if (message.command == 'DELETE_PRUNE_CONTEXT_CONFIGURATION') {
           await handle_delete_configuration(
             this,
@@ -190,7 +202,11 @@ export class SettingsProvider {
         } else if (
           message.command == 'REORDER_COMMIT_MESSAGES_CONFIGURATIONS'
         ) {
-          await handle_reorder_commit_messages_configurations(this, message)
+          await handle_reorder_configuration(
+            this,
+            message.configurations,
+            'commit-messages'
+          )
         } else if (message.command == 'DELETE_COMMIT_MESSAGES_CONFIGURATION') {
           await handle_delete_configuration(
             this,