Remove checkNewFiles setting and always automatically include newly created files in context

- remove the 'check new files' setting

Author: robertpiosik

apps/editor/package.json

@@ -993,11 +993,6 @@
           "scope": "resource",
           "default": false
         },
-        "codeWebChat.checkNewFiles": {
-          "type": "boolean",
-          "default": true,
-          "scope": "resource"
-        },
         "codeWebChat.sendWithShiftEnter": {
           "type": "boolean",
           "scope": "resource",

apps/editor/src/context/providers/workspace/workspace-provider.ts

@@ -447,28 +447,22 @@ export class WorkspaceProvider
       await this._load_all_gitignore_files()
     }
 
-    const check_new_files = vscode.workspace
-      .getConfiguration('codeWebChat')
-      .get<boolean>('checkNewFiles')
-
     if (!this.is_excluded(is_directory ? relative_path + '/' : relative_path)) {
-      if (check_new_files) {
-        this._checked_items.set(
-          created_file_path,
-          vscode.TreeItemCheckboxState.Checked
-        )
-        this._checked_timestamps.set(
+      this._checked_items.set(
+        created_file_path,
+        vscode.TreeItemCheckboxState.Checked
+      )
+      this._checked_timestamps.set(
+        created_file_path,
+        Math.floor(Date.now() / 1000)
+      )
+
+      if (is_directory) {
+        await this._update_directory_check_state(
           created_file_path,
-          Math.floor(Date.now() / 1000)
+          vscode.TreeItemCheckboxState.Checked,
+          false
         )
-
-        if (is_directory) {
-          await this._update_directory_check_state(
-            created_file_path,
-            vscode.TreeItemCheckboxState.Checked,
-            false
-          )
-        }
       }
 
       let dir_path = parent_dir

apps/editor/src/views/settings/backend/message-handlers/handle-get-check-new-files.ts

@@ -39,8 +39,6 @@ export * from './handle-open-ignore-patterns-settings'
 export * from './handle-open-allow-patterns-settings'
 export * from './handle-get-send-with-shift-enter'
 export * from './handle-update-send-with-shift-enter'
-export * from './handle-get-check-new-files'
-export * from './handle-update-check-new-files'
 export * from './handle-get-reuse-last-tab'
 export * from './handle-update-reuse-last-tab'
 export * from './handle-get-api-configurations'

apps/editor/src/views/settings/backend/message-handlers/handle-update-check-new-files.ts

@@ -7,7 +7,6 @@ import {
   handle_add_model_provider,
   handle_update_model_provider,
   handle_delete_model_provider,
-  handle_get_check_new_files,
   handle_get_clear_checks_in_workspace_behavior,
   handle_get_are_automatic_checkpoints_disabled,
   handle_get_api_configurations,
@@ -26,7 +25,6 @@ import {
   handle_reorder_model_providers,
   handle_set_default_api_configuration,
   handle_select_default_api_configuration,
-  handle_update_check_new_files,
   handle_update_clear_checks_in_workspace_behavior,
   handle_update_are_automatic_checkpoints_disabled,
   handle_update_commit_message_instructions,
@@ -260,10 +258,6 @@ export class SettingsViewProvider {
           await handle_get_send_with_shift_enter(this)
         } else if (message.command == 'UPDATE_SEND_WITH_SHIFT_ENTER') {
           await handle_update_send_with_shift_enter(message)
-        } else if (message.command == 'GET_CHECK_NEW_FILES') {
-          await handle_get_check_new_files(this)
-        } else if (message.command == 'UPDATE_CHECK_NEW_FILES') {
-          await handle_update_check_new_files(message)
         } else if (message.command == 'GET_REUSE_LAST_TAB') {
           await handle_get_reuse_last_tab(this)
         } else if (message.command == 'UPDATE_REUSE_LAST_TAB') {
@@ -349,7 +343,6 @@ export class SettingsViewProvider {
           void handle_get_gemini_user_id(this)
           void handle_get_ai_studio_user_id(this)
           void handle_get_send_with_shift_enter(this)
-          void handle_get_check_new_files(this)
           void handle_get_reuse_last_tab(this)
           void handle_get_auto_run_intelligent_update(this)
           void handle_get_templates(this)

apps/editor/src/views/settings/backend/message-handlers/index.ts

@@ -118,7 +118,6 @@ type Props = {
   gemini_user_id: number | null
   ai_studio_user_id: number | null
   send_with_shift_enter: boolean
-  check_new_files: boolean
   reuse_last_tab: boolean
   are_automatic_checkpoints_disabled: boolean
   checkpoint_lifespan: number
@@ -154,7 +153,6 @@ type Props = {
   on_gemini_user_id_change: (id: number | null) => void
   on_ai_studio_user_id_change: (id: number | null) => void
   on_send_with_shift_enter_change: (enabled: boolean) => void
-  on_check_new_files_change: (enabled: boolean) => void
   on_reuse_last_tab_change: (enabled: boolean) => void
   on_clear_checks_in_workspace_behavior_change: (
     value: 'ignore-open-editors' | 'uncheck-all'
@@ -546,8 +544,6 @@ export const Home: React.FC<Props> = (props) => {
           on_send_with_shift_enter_change={
             props.on_send_with_shift_enter_change
           }
-          check_new_files={props.check_new_files}
-          on_check_new_files_change={props.on_check_new_files_change}
           clear_checks_in_workspace_behavior={
             props.clear_checks_in_workspace_behavior
           }

apps/editor/src/views/settings/backend/settings-view-provider.ts

@@ -19,12 +19,10 @@ type Props = {
   are_automatic_checkpoints_disabled: boolean
   synchronize_edit_format_between_targets: boolean
   send_with_shift_enter: boolean
-  check_new_files: boolean
   checkpoint_lifespan: number
   on_synchronize_edit_format_between_targets_change: (enabled: boolean) => void
   on_automatic_checkpoints_toggle: (disabled: boolean) => void
   on_send_with_shift_enter_change: (enabled: boolean) => void
-  on_check_new_files_change: (enabled: boolean) => void
   on_checkpoint_lifespan_change: (hours: number | undefined) => void
   clear_checks_in_workspace_behavior: ClearChecksBehavior
   on_clear_checks_in_workspace_behavior_change: (
@@ -160,16 +158,6 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
           }
         >
           <UiGroup title={t('general.context.title')}>
-            <UiItem
-              title={t('general.context.check-new-files.title')}
-              description={t('general.context.check-new-files.description')}
-              slot_right={
-                <UiToggler
-                  is_on={props.check_new_files}
-                  on_toggle={props.on_check_new_files_change}
-                />
-              }
-            />
             <UiItem
               title={t(
                 'general.context.clear-checks-in-workspace-behavior.title'

apps/editor/src/views/settings/frontend/Home/Home.tsx

@@ -100,7 +100,6 @@ export const Settings = () => {
       settings_hook.gemini_user_id !== undefined &&
       settings_hook.ai_studio_user_id !== undefined &&
       settings_hook.send_with_shift_enter !== undefined &&
-      settings_hook.check_new_files !== undefined &&
       settings_hook.reuse_last_tab !== undefined &&
       settings_hook.clear_checks_in_workspace_behavior !== undefined &&
       settings_hook.auto_run_intelligent_update !== undefined &&
@@ -165,7 +164,6 @@ export const Settings = () => {
         gemini_user_id={settings_hook.gemini_user_id!}
         ai_studio_user_id={settings_hook.ai_studio_user_id!}
         send_with_shift_enter={settings_hook.send_with_shift_enter!}
-        check_new_files={settings_hook.check_new_files!}
         reuse_last_tab={settings_hook.reuse_last_tab!}
         clear_checks_in_workspace_behavior={
           settings_hook.clear_checks_in_workspace_behavior!
@@ -224,7 +222,6 @@ export const Settings = () => {
         on_send_with_shift_enter_change={
           settings_hook.handle_send_with_shift_enter_change
         }
-        on_check_new_files_change={settings_hook.handle_check_new_files_change}
         on_reuse_last_tab_change={settings_hook.handle_reuse_last_tab_change}
         on_auto_run_intelligent_update_change={
           settings_hook.handle_auto_run_intelligent_update_change

apps/editor/src/views/settings/frontend/Home/sections/GeneralSection.tsx

@@ -62,9 +62,6 @@ export const use_settings = (vscode: any) => {
   const [send_with_shift_enter, set_send_with_shift_enter] = useState<
     boolean | undefined
   >(undefined)
-  const [check_new_files, set_check_new_files] = useState<boolean | undefined>(
-    undefined
-  )
   const [reuse_last_tab, set_reuse_last_tab] = useState<boolean | undefined>(
     undefined
   )
@@ -110,7 +107,6 @@ export const use_settings = (vscode: any) => {
     post_message(vscode, { command: 'GET_GEMINI_USER_ID' })
     post_message(vscode, { command: 'GET_AI_STUDIO_USER_ID' })
     post_message(vscode, { command: 'GET_SEND_WITH_SHIFT_ENTER' })
-    post_message(vscode, { command: 'GET_CHECK_NEW_FILES' })
     post_message(vscode, { command: 'GET_REUSE_LAST_TAB' })
     post_message(vscode, { command: 'GET_CLEAR_CHECKS_IN_WORKSPACE_BEHAVIOR' })
     post_message(vscode, { command: 'GET_AUTO_RUN_INTELLIGENT_UPDATE' })
@@ -158,8 +154,6 @@ export const use_settings = (vscode: any) => {
         set_ai_studio_user_id(message.aiStudioUserId)
       } else if (message.command == 'SEND_WITH_SHIFT_ENTER') {
         set_send_with_shift_enter(message.enabled)
-      } else if (message.command == 'CHECK_NEW_FILES') {
-        set_check_new_files(message.enabled)
       } else if (message.command == 'REUSE_LAST_TAB') {
         set_reuse_last_tab(message.enabled)
       } else if (message.command == 'CLEAR_CHECKS_IN_WORKSPACE_BEHAVIOR') {
@@ -389,14 +383,6 @@ export const use_settings = (vscode: any) => {
     })
   }
 
-  const handle_check_new_files_change = (enabled: boolean) => {
-    set_check_new_files(enabled)
-    post_message(vscode, {
-      command: 'UPDATE_CHECK_NEW_FILES',
-      enabled
-    })
-  }
-
   const handle_reuse_last_tab_change = (enabled: boolean) => {
     set_reuse_last_tab(enabled)
     post_message(vscode, {
@@ -499,7 +485,6 @@ export const use_settings = (vscode: any) => {
     gemini_user_id,
     ai_studio_user_id,
     send_with_shift_enter,
-    check_new_files,
     reuse_last_tab,
     clear_checks_in_workspace_behavior,
     auto_run_intelligent_update,
@@ -531,7 +516,6 @@ export const use_settings = (vscode: any) => {
     handle_gemini_user_id_change,
     handle_ai_studio_user_id_change,
     handle_send_with_shift_enter_change,
-    handle_check_new_files_change,
     handle_reuse_last_tab_change,
     handle_clear_checks_in_workspace_behavior_change,
     handle_auto_run_intelligent_update_change,