Update delete icon from "remove" to "trash" and consolidate configuration handlers into a unified get_configurations handler

Author: robertpiosik

packages/ui/src/components/editor/settings/ConfigurationsList/ConfigurationsList.tsx

@@ -60,7 +60,7 @@ export const ConfigurationsList: React.FC<ConfigurationsList.Props> = (
       <div className={styles['col-actions']}>
         {props.on_delete && (
           <IconButton
-            codicon_icon="remove"
+            codicon_icon="trash"
             title="Delete configuration"
             on_click={(e) => {
               e.stopPropagation()

packages/ui/src/components/editor/settings/ModelProviders/ModelProviders.tsx

@@ -58,7 +58,7 @@ export const ModelProviders: React.FC<ModelProviders.Props> = (props) => {
           />
         )}
         <IconButton
-          codicon_icon="remove"
+          codicon_icon="trash"
           on_click={() => props.on_delete_provider(provider.name)}
           title="Delete provider"
         />

packages/vscode/src/views/settings/backend/message-handlers/handle-get-code-completions-configurations.ts

@@ -0,0 +1,85 @@
+import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import {
+  ModelProvidersManager,
+  ToolConfig,
+  get_tool_config_id
+} from '@/services/model-providers-manager'
+import { ConfigurationForClient } from '@/views/settings/types/messages'
+
+const create_description = (config: ToolConfig): string => {
+  const description_parts = [config.provider_name]
+  if (config.temperature != null) {
+    description_parts.push(`${config.temperature}`)
+  }
+  if (config.reasoning_effort) {
+    description_parts.push(`${config.reasoning_effort}`)
+  }
+  return description_parts.join(' · ')
+}
+
+export const handle_get_configurations = async (
+  provider: SettingsProvider,
+  type:
+    | 'code-completions'
+    | 'edit-context'
+    | 'intelligent-update'
+    | 'commit-messages'
+    | 'prune-context'
+): Promise<void> => {
+  const providers_manager = new ModelProvidersManager(provider.context)
+
+  let saved_configs: ToolConfig[] = []
+  let default_config: ToolConfig | undefined
+  let command: string
+
+  switch (type) {
+    case 'code-completions':
+      saved_configs =
+        await providers_manager.get_code_completions_tool_configs()
+      default_config =
+        await providers_manager.get_default_code_completions_config()
+      command = 'CODE_COMPLETIONS_CONFIGURATIONS'
+      break
+    case 'edit-context':
+      saved_configs = await providers_manager.get_edit_context_tool_configs()
+      command = 'EDIT_CONTEXT_CONFIGURATIONS'
+      break
+    case 'intelligent-update':
+      saved_configs =
+        await providers_manager.get_intelligent_update_tool_configs()
+      default_config =
+        await providers_manager.get_default_intelligent_update_config()
+      command = 'INTELLIGENT_UPDATE_CONFIGURATIONS'
+      break
+    case 'commit-messages':
+      saved_configs = await providers_manager.get_commit_messages_tool_configs()
+      default_config =
+        await providers_manager.get_default_commit_messages_config()
+      command = 'COMMIT_MESSAGES_CONFIGURATIONS'
+      break
+    case 'prune-context':
+      saved_configs = await providers_manager.get_prune_context_tool_configs()
+      command = 'PRUNE_CONTEXT_CONFIGURATIONS'
+      break
+  }
+
+  const default_config_id = default_config
+    ? get_tool_config_id(default_config)
+    : null
+
+  const configs_for_client: ConfigurationForClient[] = saved_configs.map(
+    (config) => {
+      return {
+        id: get_tool_config_id(config),
+        model: config.model,
+        description: create_description(config),
+        is_default: get_tool_config_id(config) === default_config_id
+      }
+    }
+  )
+
+  provider.postMessage({
+    command,
+    configurations: configs_for_client
+  } as any)
+}

packages/vscode/src/views/settings/backend/message-handlers/handle-get-commit-messages-configurations.ts

@@ -4,22 +4,17 @@ export * from './handle-add-model-provider'
 export * from './handle-delete-model-provider'
 export * from './handle-edit-custom-model-provider'
 export * from './handle-edit-model-provider-key'
-export * from './handle-get-code-completions-configurations'
 export * from './handle-reorder-code-completions-configurations'
 export * from './handle-set-default-code-completions-configuration'
-export * from './handle-get-commit-messages-configurations'
 export * from './handle-reorder-commit-messages-configurations'
 export * from './handle-set-default-commit-messages-configuration'
-export * from './handle-get-edit-context-configurations'
 export * from './handle-reorder-edit-context-configurations'
 export * from './handle-get-edit-context-system-instructions'
 export * from './handle-update-edit-context-system-instructions'
 export * from './handle-get-edit-format-instructions'
 export * from './handle-update-edit-format-instructions'
-export * from './handle-get-intelligent-update-configurations'
 export * from './handle-reorder-intelligent-update-configurations'
 export * from './handle-set-default-intelligent-update-configuration'
-export * from './handle-get-prune-context-configurations'
 export * from './handle-reorder-prune-context-configurations'
 export * from './handle-get-commit-message-instructions'
 export * from './handle-update-commit-message-instructions'
@@ -44,3 +39,4 @@ export * from './handle-update-send-with-shift-enter'
 export * from './handle-get-check-new-files'
 export * from './handle-update-check-new-files'
 export * from './handle-delete-configuration'
+export * from './handle-get-configurations'