Propagate the created_at timestamp through the response preview process to correctly handle history items during acceptance or rejection

Author: robertpiosik

packages/vscode/src/commands/apply-chat-response-command/utils/preview/preview.ts

@@ -115,7 +115,8 @@ export const preview = async (params: {
       params.panel_provider.send_message({
         command: 'RESPONSE_PREVIEW_STARTED',
         items: items_for_preview,
-        raw_instructions: params.raw_instructions
+        raw_instructions: params.raw_instructions,
+        created_at: params.created_at
       })
     }
 

packages/vscode/src/views/panel/frontend/Panel.tsx

@@ -46,6 +46,7 @@ export const Panel = () => {
     selected_history_item_created_at,
     set_selected_history_item_created_at,
     response_history,
+    preview_item_created_at,
     set_response_history,
     workspace_folder_count,
     is_connected,
@@ -309,16 +310,18 @@ export const Panel = () => {
               footer_slot={
                 <UiResponsePreviewFooter
                   on_reject={() => {
-                    set_response_history((prev) =>
-                      prev.filter(
-                        (i) => i.created_at != selected_history_item_created_at
+                    if (preview_item_created_at) {
+                      set_response_history((prev) =>
+                        prev.filter(
+                          (i) => i.created_at != preview_item_created_at
+                        )
                       )
-                    )
+                    }
                     set_selected_history_item_created_at(undefined)
                     post_message(vscode, {
                       command: 'RESPONSE_PREVIEW',
                       files: [],
-                      created_at: selected_history_item_created_at
+                      created_at: preview_item_created_at
                     })
                   }}
                   on_accept={() => {
@@ -330,7 +333,7 @@ export const Panel = () => {
                     post_message(vscode, {
                       command: 'RESPONSE_PREVIEW',
                       files: accepted_files,
-                      created_at: selected_history_item_created_at
+                      created_at: preview_item_created_at
                     })
                   }}
                   is_accept_disabled={

packages/vscode/src/views/panel/frontend/hooks/use-panel.ts

@@ -44,6 +44,8 @@ export const use_panel = (vscode: any) => {
     selected_history_item_created_at,
     set_selected_history_item_created_at
   ] = useState<number>()
+  const [preview_item_created_at, set_preview_item_created_at] =
+    useState<number>()
   const [response_history, set_response_history] = useState<
     ResponseHistoryItem[]
   >([])
@@ -139,6 +141,7 @@ export const use_panel = (vscode: any) => {
       } else if (message.command == 'RESPONSE_PREVIEW_STARTED') {
         set_items_to_review(message.items)
         set_raw_instructions(message.raw_instructions)
+        set_preview_item_created_at(message.created_at)
       } else if (message.command == 'UPDATE_FILE_IN_REVIEW') {
         set_items_to_review((current_items) => {
           const items = current_items ?? []
@@ -166,6 +169,7 @@ export const use_panel = (vscode: any) => {
       } else if (message.command == 'RESPONSE_PREVIEW_FINISHED') {
         set_items_to_review(undefined)
         set_raw_instructions(undefined)
+        set_preview_item_created_at(undefined)
       } else if (message.command == 'WORKSPACE_STATE') {
         set_workspace_folder_count(message.folder_count)
       } else if (message.command == 'SHOW_PROGRESS') {
@@ -332,6 +336,7 @@ export const use_panel = (vscode: any) => {
     selected_history_item_created_at,
     set_selected_history_item_created_at,
     response_history,
+    preview_item_created_at,
     set_response_history,
     workspace_folder_count,
     is_connected,

packages/vscode/src/views/panel/types/messages.ts

@@ -540,6 +540,7 @@ export interface ResponsePreviewStartedMessage extends BaseMessage {
   command: 'RESPONSE_PREVIEW_STARTED'
   items: ItemInPreview[]
   raw_instructions?: string
+  created_at?: number
 }
 
 export interface ResponsePreviewFinishedMessage extends BaseMessage {