Skip to content

Commit f798f2f

Browse files
committed
Rename the setting codeWebChat.clearChecksInWorkspace to codeWebChat.clearChecksInWorkspaceBehavior and update related frontend components
1 parent e31678d commit f798f2f

5 files changed

Lines changed: 27 additions & 22 deletions

File tree

‎packages/vscode/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@
542542
"default": 60000,
543543
"description": "Threshold for the context size to show a warning."
544544
},
545-
"codeWebChat.clearChecksInWorkspace": {
545+
"codeWebChat.clearChecksInWorkspaceBehavior": {
546546
"type": "string",
547547
"enum": [
548548
"ignore-open-editors",

‎packages/vscode/src/views/settings/frontend/Home/Home.tsx‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ type Props = {
6060
commit_message_instructions: string
6161
context_size_warning_threshold: number
6262
gemini_user_id: number | null
63-
clear_checks_in_workspace: 'ignore-open-editors' | 'uncheck-all'
63+
clear_checks_in_workspace_behavior: 'ignore-open-editors' | 'uncheck-all'
6464

6565
// handlers
6666
set_providers: (providers: ProviderForClient[]) => void
@@ -71,7 +71,7 @@ type Props = {
7171
on_context_size_warning_threshold_change: (threshold: number) => void
7272
on_commit_instructions_change: (instructions: string) => void
7373
on_gemini_user_id_change: (id: number | null) => void
74-
on_clear_checks_in_workspace_change: (
74+
on_clear_checks_in_workspace_behavior_change: (
7575
value: 'ignore-open-editors' | 'uncheck-all'
7676
) => void
7777
on_open_editor_settings: () => void
@@ -237,9 +237,11 @@ export const Home: React.FC<Props> = (props) => {
237237
on_context_size_warning_threshold_change={
238238
props.on_context_size_warning_threshold_change
239239
}
240-
clear_checks_in_workspace={props.clear_checks_in_workspace}
241-
on_clear_checks_in_workspace_change={
242-
props.on_clear_checks_in_workspace_change
240+
clear_checks_in_workspace_behavior={
241+
props.clear_checks_in_workspace_behavior
242+
}
243+
on_clear_checks_in_workspace_behavior_change={
244+
props.on_clear_checks_in_workspace_behavior_change
243245
}
244246
on_open_editor_settings={props.on_open_editor_settings}
245247
on_stuck_change={general_on_stuck_change}

‎packages/vscode/src/views/settings/frontend/Home/sections/GeneralSection.tsx‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import { TextButton } from '@ui/components/editor/settings/TextButton'
66

77
type Props = {
88
context_size_warning_threshold: number
9-
clear_checks_in_workspace: 'ignore-open-editors' | 'uncheck-all'
9+
clear_checks_in_workspace_behavior: 'ignore-open-editors' | 'uncheck-all'
1010
on_context_size_warning_threshold_change: (threshold: number) => void
11-
on_clear_checks_in_workspace_change: (
11+
on_clear_checks_in_workspace_behavior_change: (
1212
value: 'ignore-open-editors' | 'uncheck-all'
1313
) => void
1414
on_open_editor_settings: () => void
@@ -74,13 +74,13 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
7474
}
7575
/>
7676
<Item
77-
title="Clear Checks in Workspace"
77+
title="Clear Checks in Workspace Behavior"
7878
description="Behavior of the 'Clear Checks' command in the Workspace view."
7979
slot={
8080
<select
81-
value={props.clear_checks_in_workspace}
81+
value={props.clear_checks_in_workspace_behavior}
8282
onChange={(e) =>
83-
props.on_clear_checks_in_workspace_change(
83+
props.on_clear_checks_in_workspace_behavior_change(
8484
e.target.value as 'ignore-open-editors' | 'uncheck-all'
8585
)
8686
}

‎packages/vscode/src/views/settings/frontend/Settings.tsx‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const Settings = () => {
3030
settings_hook.commit_message_instructions !== undefined &&
3131
settings_hook.context_size_warning_threshold !== undefined &&
3232
settings_hook.gemini_user_id !== undefined &&
33-
settings_hook.clear_checks_in_workspace !== undefined
33+
settings_hook.clear_checks_in_workspace_behavior !== undefined
3434
)
3535
}, [settings_hook])
3636

@@ -60,7 +60,9 @@ export const Settings = () => {
6060
}
6161
commit_message_instructions={settings_hook.commit_message_instructions!}
6262
gemini_user_id={settings_hook.gemini_user_id!}
63-
clear_checks_in_workspace={settings_hook.clear_checks_in_workspace!}
63+
clear_checks_in_workspace_behavior={
64+
settings_hook.clear_checks_in_workspace_behavior!
65+
}
6466
set_providers={settings_hook.set_providers}
6567
set_code_completions_configs={settings_hook.set_code_completions_configs}
6668
set_commit_messages_configs={settings_hook.set_commit_messages_configs}
@@ -74,8 +76,8 @@ export const Settings = () => {
7476
on_commit_instructions_change={
7577
settings_hook.handle_commit_instructions_change
7678
}
77-
on_clear_checks_in_workspace_change={
78-
settings_hook.handle_clear_checks_in_workspace_change
79+
on_clear_checks_in_workspace_behavior_change={
80+
settings_hook.handle_clear_checks_in_workspace_behavior_change
7981
}
8082
on_gemini_user_id_change={settings_hook.handle_gemini_user_id_change}
8183
on_open_editor_settings={settings_hook.handle_open_editor_settings}

‎packages/vscode/src/views/settings/frontend/hooks/use-settings.ts‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@ export const use_settings = (vscode: any) => {
3030
const [gemini_user_id, set_gemini_user_id] = useState<
3131
number | null | undefined
3232
>(undefined)
33-
const [clear_checks_in_workspace, set_clear_checks_in_workspace] = useState<
34-
'ignore-open-editors' | 'uncheck-all' | undefined
35-
>(undefined)
33+
const [
34+
clear_checks_in_workspace_behavior,
35+
set_clear_checks_in_workspace_behavior
36+
] = useState<'ignore-open-editors' | 'uncheck-all' | undefined>(undefined)
3637

3738
useEffect(() => {
3839
// Request initial data
@@ -76,7 +77,7 @@ export const use_settings = (vscode: any) => {
7677
set_gemini_user_id(message.geminiUserId)
7778
break
7879
case 'CLEAR_CHECKS_IN_WORKSPACE_BEHAVIOR':
79-
set_clear_checks_in_workspace(message.value)
80+
set_clear_checks_in_workspace_behavior(message.value)
8081
break
8182
}
8283
}
@@ -194,7 +195,7 @@ export const use_settings = (vscode: any) => {
194195
geminiUserId
195196
})
196197

197-
const handle_clear_checks_in_workspace_change = (
198+
const handle_clear_checks_in_workspace_behavior_change = (
198199
value: 'ignore-open-editors' | 'uncheck-all'
199200
) =>
200201
post_message(vscode, {
@@ -216,7 +217,7 @@ export const use_settings = (vscode: any) => {
216217
commit_message_instructions,
217218
context_size_warning_threshold,
218219
gemini_user_id,
219-
clear_checks_in_workspace,
220+
clear_checks_in_workspace_behavior,
220221
handle_reorder_providers,
221222
handle_add_provider,
222223
handle_delete_provider,
@@ -232,6 +233,6 @@ export const use_settings = (vscode: any) => {
232233
handle_open_editor_settings,
233234
handle_context_size_warning_threshold_change,
234235
handle_gemini_user_id_change,
235-
handle_clear_checks_in_workspace_change
236+
handle_clear_checks_in_workspace_behavior_change
236237
}
237238
}

0 commit comments

Comments
 (0)