Simplify prompt handling by retrieving current instructions directly from the provider

- do we always refer to [Fragment] as 'current instructions'? we should
- 'copy prompt' should take instructions directly from the provider
- on prompt copying, 'web configuration name' is no longer relevant

└── apps
    └── editor
        └── src
            └── views
                └── prompt
                    ├── backend
                    │   ├── message-handlers
                    │   │   ├── handle-autofill.ts
                    │   │   ├── handle-copy-prompt.ts
                    │   │   ├── handle-make-api-call.ts
                    │   │   ├── handle-preview-web-configuration.ts
                    │   │   └── index.ts
                    │   └── prompt-view-provider.ts
                    ├── frontend
                    │   ├── Main
                    │   │   ├── Main.tsx
                    │   │   └── MainView
                    │   │       └── MainView.tsx
                    │   ├── Prompt.tsx
                    │   └── hooks
                    │       └── use-prompt
                    │           └── use-prompt.ts
                    └── types
                        └── messages.ts

Author: robertpiosik

apps/editor/src/views/prompt/backend/message-handlers/handle-autofill.ts

@@ -33,8 +33,6 @@ export const handle_autofill = async (params: {
     return
   }
 
-  const current_instructions = params.prompt_view_provider.current_instructions
-
   const resolution = await resolve_web_configuration({
     prompt_view_provider: params.prompt_view_provider,
     web_configuration_name: params.web_configuration_name,
@@ -67,6 +65,8 @@ export const handle_autofill = async (params: {
   })
   const context_text = collected.other_files + collected.recent_files
 
+  const current_instructions = params.prompt_view_provider.current_instructions
+
   const { instructions: processed_instructions, skill_definitions } =
     await replace_symbols({
       instructions: current_instructions,
@@ -131,7 +131,6 @@ const show_web_configuration_quick_pick = async (params: {
   get_is_web_configuration_disabled: (
     web_configuration: ConfigWebConfigurationFormat
   ) => boolean
-  current_instructions: string
 }): Promise<{ web_configuration_name: string | undefined } | null> => {
   const {
     web_configurations,
@@ -226,19 +225,6 @@ const resolve_web_configuration = async (params: {
     'webConfigurations',
     []
   )
-  let current_instructions = ''
-  if (params.prompt_view_provider.web_prompt_type == 'ask-about-files') {
-    current_instructions =
-      params.prompt_view_provider.ask_about_context_instructions.instructions[
-        params.prompt_view_provider.ask_about_context_instructions.active_index
-      ] || ''
-  } else if (params.prompt_view_provider.web_prompt_type == 'edit-files') {
-    current_instructions =
-      params.prompt_view_provider.edit_files_instructions.instructions[
-        params.prompt_view_provider.edit_files_instructions.active_index
-      ] || ''
-  }
-
   const get_is_web_configuration_disabled = (
     web_configuration: ConfigWebConfigurationFormat
   ) =>
@@ -285,8 +271,7 @@ const resolve_web_configuration = async (params: {
     extension_context: params.extension_context,
     prompt_type: params.prompt_view_provider.web_prompt_type,
     prompt_view_provider: params.prompt_view_provider,
-    get_is_web_configuration_disabled,
-    current_instructions
+    get_is_web_configuration_disabled
   })
 
   return resolution ?? { web_configuration_name: undefined }

apps/editor/src/views/prompt/backend/message-handlers/handle-copy-prompt.ts

@@ -13,18 +13,18 @@ import { t } from '@/i18n'
 
 export const handle_copy_prompt = async (params: {
   prompt_view_provider: PromptViewProvider
-  instructions: string
-  web_configuration_name?: string
 }): Promise<void> => {
   const collected = await FilesCollector.collect_files({
     workspace_provider: params.prompt_view_provider.workspace_provider,
     open_editors_provider: params.prompt_view_provider.open_editors_provider
   })
   const context_text = collected.other_files + collected.recent_files
 
+  const current_instructions = params.prompt_view_provider.current_instructions
+
   const { instructions: processed_instructions, skill_definitions } =
     await replace_symbols({
-      instructions: params.instructions,
+      instructions: current_instructions,
       extension_context: params.prompt_view_provider.extension_context,
       workspace_provider: params.prompt_view_provider.workspace_provider,
       remove_images: true

apps/editor/src/views/prompt/backend/message-handlers/handle-make-api-call.ts

@@ -153,12 +153,9 @@ export const handle_make_api_call = async (
     prompt_view_provider.extension_context
   )
 
-  let instructions = ''
-  if (prompt_type == 'edit-files') {
-    instructions = prompt_view_provider.current_edit_files_instruction
-  }
+  const current_instructions = prompt_view_provider.current_instructions
 
-  if (!instructions) {
+  if (!current_instructions) {
     prompt_view_provider.send_message({
       command: 'SHOW_AUTO_CLOSING_MODAL',
       title: t(
@@ -171,7 +168,7 @@ export const handle_make_api_call = async (
 
   const { instructions: processed_instructions, skill_definitions } =
     await replace_symbols({
-      instructions,
+      instructions: current_instructions,
       extension_context: prompt_view_provider.extension_context,
       workspace_provider: prompt_view_provider.workspace_provider
     })
@@ -279,7 +276,7 @@ export const handle_make_api_call = async (
             provider_name: api_configuration.model_provider_name,
             model: api_configuration.model,
             reasoning_effort: api_configuration.reasoning_effort,
-            raw_instructions: instructions
+            raw_instructions: current_instructions
           }
         )
 
@@ -293,7 +290,7 @@ export const handle_make_api_call = async (
         if (prompt_type == 'edit-files') {
           vscode.commands.executeCommand('codeWebChat.applyResponse', {
             response: result.response,
-            raw_instructions: instructions,
+            raw_instructions: current_instructions,
             edit_format,
             recent_api_configuration
           })

apps/editor/src/views/prompt/backend/prompt-view-provider.ts

@@ -655,9 +655,7 @@ export class PromptViewProvider implements vscode.WebviewViewProvider {
             await handle_preview_web_configuration(this, message)
           } else if (message.command == 'COPY_PROMPT') {
             await handle_copy_prompt({
-              prompt_view_provider: this,
-              instructions: message.instructions,
-              web_configuration_name: message.web_configuration_name
+              prompt_view_provider: this
             })
           } else if (message.command == 'REQUEST_EDITOR_STATE') {
             handle_request_editor_state(this)

apps/editor/src/views/prompt/frontend/Main/Main.tsx

@@ -226,11 +226,9 @@ export const Main: React.FC<Props> = (props) => {
     update_chat_history(instructions)
   }
 
-  const handle_copy_to_clipboard = (web_configuration_name?: string) => {
+  const handle_copy = () => {
     post_message(props.vscode, {
-      command: 'COPY_PROMPT',
-      instructions,
-      web_configuration_name
+      command: 'COPY_PROMPT'
     })
 
     if (instructions.trim()) {
@@ -469,7 +467,7 @@ export const Main: React.FC<Props> = (props) => {
       scroll_reset_key={props.scroll_reset_key}
       on_show_home={props.on_show_home}
       initialize_chats={handle_initialize_chats}
-      copy_to_clipboard={handle_copy_to_clipboard}
+      on_copy={handle_copy}
       api_configurations={api_configurations}
       on_api_configuration_click={handle_api_configuration_click}
       on_api_configurations_reorder={handle_api_configurations_reorder}

apps/editor/src/views/prompt/frontend/Main/MainView/MainView.tsx

@@ -32,7 +32,7 @@ type Props = {
     web_configuration_name?: string
     show_quick_pick?: boolean
   }) => void
-  copy_to_clipboard: (web_configuration_name?: string) => void
+  on_copy: () => void
   on_show_home: () => void
   on_create_web_configuration: (params?: {
     insertion_index?: number
@@ -311,7 +311,7 @@ export const MainView: React.FC<Props> = (props) => {
             on_change={handle_input_change}
             on_submit={handle_submit}
             on_submit_with_control={handle_submit_with_control}
-            on_copy={props.copy_to_clipboard}
+            on_copy={props.on_copy}
             on_at_sign_click={props.on_at_sign_click}
             on_hash_sign_click={props.on_hash_sign_click}
             on_slash_click={props.on_slash_click}

apps/editor/src/views/prompt/types/messages.ts

@@ -120,8 +120,6 @@ export interface AutofillMessage extends BaseMessage {
 
 export interface CopyPromptMessage extends BaseMessage {
   command: 'COPY_PROMPT'
-  instructions: string
-  web_configuration_name?: string
 }
 
 export interface RequestEditorStateMessage extends BaseMessage {