Skip to content

Commit 4abb6da

Browse files
committed
Separate test group into 2 groups and remove some tests
1 parent 441d1bf commit 4abb6da

1 file changed

Lines changed: 5 additions & 13 deletions

File tree

‎practice-tdd/get-ordinal-number.test.js‎

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,15 @@ test("should append 'th' for all other whole numbers", () => {
6161
expect(getOrdinalNumber(-100)).toEqual("-100th");
6262
});
6363

64-
// Case 8: Throw error for invalid numbers
64+
// Case 8: Throw error for invalid-numbers
6565
test("should throw error for all invalid numbers", () => {
6666
expect(() => {
6767
getOrdinalNumber(5.7);
6868
}).toThrow("Error: whole number is needed");
69+
})
70+
71+
// Case 9: Throw error for non-numbers
72+
test("should throw error for all non-numbers", () => {
6973
expect(() => {
7074
getOrdinalNumber();
7175
}).toThrow("Error: whole number is needed");
@@ -75,19 +79,7 @@ test("should throw error for all invalid numbers", () => {
7579
expect(() => {
7680
getOrdinalNumber(undefined);
7781
}).toThrow("Error: whole number is needed");
78-
expect(() => {
79-
getOrdinalNumber(null);
80-
}).toThrow("Error: whole number is needed");
81-
expect(() => {
82-
getOrdinalNumber(false);
83-
}).toThrow("Error: whole number is needed");
8482
expect(() => {
8583
getOrdinalNumber(true);
8684
}).toThrow("Error: whole number is needed");
87-
expect(() => {
88-
getOrdinalNumber([1, 2, 3]);
89-
}).toThrow("Error: whole number is needed");
90-
expect(() => {
91-
getOrdinalNumber({ 4: "hey", bye: 39 });
92-
}).toThrow("Error: whole number is needed");
9385
});

0 commit comments

Comments
 (0)