Skip to content

Commit 7e24720

Browse files
re-orgnise test cases into meaningful category
1 parent 4e6e1c9 commit 7e24720

1 file changed

Lines changed: 29 additions & 36 deletions

File tree

‎practice-tdd/get-ordinal-number.test.js‎

Lines changed: 29 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -9,73 +9,66 @@ import { getOrdinalNumber } from "./get-ordinal-number.js";
99
// into meaningful categories. Then, select representative samples from each category to test.
1010
// This approach improves coverage and makes our tests easier to maintain.
1111

12-
// Case 1:
13-
test("should append 'st' for numbers ending with 1, except those ending with 11", () => {
12+
// ---------- Normal rules (decided by the last digit) ----------
13+
14+
// Category 1: ends in 1 (not 11) -> "st"
15+
test("should append 'st' for numbers ending in 1, except those ending in 11", () => {
1416
expect(getOrdinalNumber(1)).toEqual("1st");
1517
expect(getOrdinalNumber(21)).toEqual("21st");
18+
expect(getOrdinalNumber(101)).toEqual("101st");
1619
expect(getOrdinalNumber(131)).toEqual("131st");
1720
});
1821

19-
// Case 2:
20-
test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
22+
// Category 2: ends in 2 (not 12) -> "nd"
23+
test("should append 'nd' for numbers ending in 2, except those ending in 12", () => {
2124
expect(getOrdinalNumber(2)).toEqual("2nd");
2225
expect(getOrdinalNumber(32)).toEqual("32nd");
23-
expect(getOrdinalNumber(72)).toEqual("72nd");
26+
expect(getOrdinalNumber(102)).toEqual("102nd");
2427
expect(getOrdinalNumber(452)).toEqual("452nd");
2528
expect(getOrdinalNumber(862)).toEqual("862nd");
2629
});
2730

28-
// Case 3: N
29-
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
31+
// Category 3: ends in 3 (not 13) -> "rd"
32+
test("should append 'rd' for numbers ending in 3, except those ending in 13", () => {
3033
expect(getOrdinalNumber(3)).toEqual("3rd");
3134
expect(getOrdinalNumber(43)).toEqual("43rd");
32-
expect(getOrdinalNumber(93)).toEqual("93rd");
33-
expect(getOrdinalNumber(823)).toEqual("823rd");
35+
expect(getOrdinalNumber(103)).toEqual("103rd");
3436
expect(getOrdinalNumber(183)).toEqual("183rd");
37+
expect(getOrdinalNumber(823)).toEqual("823rd");
3538
});
3639

37-
// Case 4:
38-
test("should append 'th' for numbers ending with 0,4,5,6 ,7 ,8 or 9 ", () => {
39-
expect(getOrdinalNumber(0)).toEqual("0th");
40+
// Category 4: ends in 4, 5, 6, 7, 8 or 9 -> "th"
41+
test("should append 'th' for numbers ending in 4, 5, 6, 7, 8 or 9", () => {
4042
expect(getOrdinalNumber(4)).toEqual("4th");
43+
expect(getOrdinalNumber(14)).toEqual("14th");
44+
expect(getOrdinalNumber(19)).toEqual("19th");
4145
expect(getOrdinalNumber(25)).toEqual("25th");
4246
expect(getOrdinalNumber(656)).toEqual("656th");
4347
expect(getOrdinalNumber(1007)).toEqual("1007th");
4448
expect(getOrdinalNumber(638398)).toEqual("638398th");
4549
expect(getOrdinalNumber(34454559)).toEqual("34454559th");
4650
});
4751

48-
// Case 5:
49-
test("should append 'th' for ending with 11, 12 , 13,14 and 19", () => {
52+
// Category 5: ends in 0 -> "th"
53+
test("should append 'th' for numbers ending in 0", () => {
54+
expect(getOrdinalNumber(0)).toEqual("0th");
55+
expect(getOrdinalNumber(10)).toEqual("10th");
56+
expect(getOrdinalNumber(20)).toEqual("20th");
57+
expect(getOrdinalNumber(100)).toEqual("100th");
58+
expect(getOrdinalNumber(1000)).toEqual("1000th");
59+
});
60+
61+
// ---------- Exception (decided by the last TWO digits) ----------
62+
63+
// Category 6: ends in 11, 12 or 13 -> "th"
64+
test("should append 'th' for numbers ending in 11, 12 or 13", () => {
5065
expect(getOrdinalNumber(11)).toEqual("11th");
5166
expect(getOrdinalNumber(12)).toEqual("12th");
5267
expect(getOrdinalNumber(13)).toEqual("13th");
53-
expect(getOrdinalNumber(14)).toEqual("14th");
54-
expect(getOrdinalNumber(19)).toEqual("19th");
5568
expect(getOrdinalNumber(111)).toEqual("111th");
5669
expect(getOrdinalNumber(112)).toEqual("112th");
5770
expect(getOrdinalNumber(113)).toEqual("113th");
5871
expect(getOrdinalNumber(1011)).toEqual("1011th");
5972
expect(getOrdinalNumber(3112)).toEqual("3112th");
6073
expect(getOrdinalNumber(4813)).toEqual("4813th");
61-
6274
});
63-
64-
// Case 6:
65-
66-
test("should append 'st' for 101 and 'rd' for 103", () => {
67-
68-
expect(getOrdinalNumber(101)).toEqual("101st");
69-
expect(getOrdinalNumber(103)).toEqual("103rd");
70-
});
71-
test("should append 'th' for numbers ending with 0 ", () => {
72-
expect(getOrdinalNumber(0)).toEqual("0th");
73-
expect(getOrdinalNumber(10)).toEqual("10th");
74-
expect(getOrdinalNumber(20)).toEqual("20th");
75-
expect(getOrdinalNumber(100)).toEqual("100th");
76-
expect(getOrdinalNumber(1000)).toEqual("1000th");
77-
});
78-
79-
80-
81-

0 commit comments

Comments
 (0)