Skip to content

Commit f263f07

Browse files
committed
Negative numbers now throw an error, and tests for them are added
1 parent 57792ce commit f263f07

2 files changed

Lines changed: 17 additions & 11 deletions

File tree

‎practice-tdd/get-ordinal-number.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export function getOrdinalNumber(num) {
2-
if (num % 1 !== 0 || !num || typeof num !== "number" || num.length > 1) {
3-
throw new Error("Error: whole number is needed");
2+
if (num <= 0 || num % 1 !== 0 || !num || typeof num !== "number" || num.length > 1) {
3+
throw new Error("Error: positive whole number is needed");
44
}
55

66
if (

‎practice-tdd/get-ordinal-number.test.js‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,32 +54,38 @@ test("should append 'th' for numbers ending with 13", () => {
5454
expect(getOrdinalNumber(4213)).toEqual("4213th");
5555
});
5656

57-
// Case 7: All other whole numbers. Should append "th" to the number
58-
test("should append 'th' for all other whole numbers", () => {
59-
expect(getOrdinalNumber(-1834)).toEqual("-1834th");
57+
// Case 7: All other positive whole numbers. Should append "th" to the number
58+
test("should append 'th' for all other positive whole numbers", () => {
59+
expect(getOrdinalNumber(1834)).toEqual("1834th");
6060
expect(getOrdinalNumber(23151509)).toEqual("23151509th");
61-
expect(getOrdinalNumber(-100)).toEqual("-100th");
61+
expect(getOrdinalNumber(100)).toEqual("100th");
6262
});
6363

6464
// Case 8: Throw error for invalid-numbers
6565
test("should throw error for all invalid numbers", () => {
6666
expect(() => {
6767
getOrdinalNumber(5.7);
68-
}).toThrow("Error: whole number is needed");
68+
}).toThrow("Error: positive whole number is needed");
69+
expect(() => {
70+
getOrdinalNumber(-3859);
71+
}).toThrow("Error: positive whole number is needed");
72+
expect(() => {
73+
getOrdinalNumber(0);
74+
}).toThrow("Error: positive whole number is needed");
6975
})
7076

7177
// Case 9: Throw error for non-numbers
7278
test("should throw error for all non-numbers", () => {
7379
expect(() => {
7480
getOrdinalNumber();
75-
}).toThrow("Error: whole number is needed");
81+
}).toThrow("Error: positive whole number is needed");
7682
expect(() => {
7783
getOrdinalNumber("hey");
78-
}).toThrow("Error: whole number is needed");
84+
}).toThrow("Error: positive whole number is needed");
7985
expect(() => {
8086
getOrdinalNumber(undefined);
81-
}).toThrow("Error: whole number is needed");
87+
}).toThrow("Error: positive whole number is needed");
8288
expect(() => {
8389
getOrdinalNumber(true);
84-
}).toThrow("Error: whole number is needed");
90+
}).toThrow("Error: positive whole number is needed");
8591
});

0 commit comments

Comments
 (0)